From: Brian Norris <briannorris@chromium.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Caesar Wang <wxt@rock-chips.com>,
Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Stephen Barber <smbarber@chromium.org>,
linux-arm-kernel@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH 8/9] arm64: dts: rockchip: partially describe PWM regulators for Gru
Date: Wed, 7 Dec 2016 09:09:17 -0800 [thread overview]
Message-ID: <20161207170916.GA84287@google.com> (raw)
In-Reply-To: <2418784.7dMdkAyuIx@phil>
Hi Heiko,
On Wed, Dec 07, 2016 at 05:48:24PM +0100, Heiko Stuebner wrote:
> Am Donnerstag, 1. Dezember 2016, 18:27:32 CET schrieb Brian Norris:
> > We need to add regulators to the CPU nodes, so cpufreq doesn't think it
> > can crank up the clock speed without changing the voltage. However, we
> > don't yet have the DT bindings to fully describe the Over Voltage
> > Protection (OVP) circuits on these boards. Without that description, we
> > might end up changing the voltage too much, too fast.
> >
> > Add the pwm-regulator descriptions and associate the CPU OPPs, but leave
> > them disabled.
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> is there a specific reason for keeping this change separate?
Maybe not a great one. I figured they were somewhat controversial, so I
at least wanted to split the "cpufreq patches" (i.e., this and the
previous) from the main DTS(I) additions. I also figured we typically
like to keep the base SoC changes separate from the board DTS(I)
changes.
> While it is nice for documentation reasons, as it stands now the previous
> patch introduces a regression (cpufreq trying to scale without regulators) and
> immediately fixes it here.
Right. Additionally, as noted on the previous patch, we might do the
same with EVB. But I don't know what the regulators are like for EVB.
This is probably a bigger deal, since EVB has been working (allegedly)
upstream for a while now.
There's no way to split these up without either breaking compilation or
breaking bisectability. For Kevin/Gru, they don't function at all before
this series, so I figured some "settle" time wasn't a huge deal.
> So if you're ok with it, I'd like to merge this one back into the previous
> patch when applying.
That'd be OK with me, as long as we're also confident about EVB.
Maybe at a minimum, I should just patch in some empty regulator nodes,
so cpufreq doesn't think there's no need to handle voltage.
Brian
next prev parent reply other threads:[~2016-12-07 17:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 2:27 [PATCH 0/9] arm64: dts: rockchip: support Google Kevin Brian Norris
2016-12-02 2:27 ` [PATCH 1/9] arm64: dts: Add symlinks for cros-ec-keyboard and cros-ec-sbs Brian Norris
2016-12-02 2:27 ` [PATCH 2/9] arm64: dts: rockchip: add rk3399 thermal_zones phandle Brian Norris
2016-12-07 16:55 ` Heiko Stuebner
2016-12-02 2:27 ` [PATCH 3/9] arm64: dts: rockchip: add rk3399 eDP HPD pinctrl Brian Norris
2016-12-07 16:56 ` Heiko Stuebner
2016-12-02 2:27 ` [PATCH 4/9] arm64: dts: rockchip: support dwc3 USB for rk3399 Brian Norris
2016-12-07 17:09 ` Heiko Stuebner
2016-12-07 17:52 ` Brian Norris
2016-12-07 19:01 ` Heiko Stuebner
2016-12-07 19:03 ` Brian Norris
2016-12-07 19:09 ` Heiko Stuebner
2016-12-02 2:27 ` [PATCH 5/9] arm64: dts: rockchip: add rk3399 OPPs Brian Norris
2016-12-02 2:27 ` [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Brian Norris
2016-12-07 17:12 ` Heiko Stuebner
2016-12-07 17:41 ` Brian Norris
2016-12-07 19:15 ` Heiko Stuebner
2016-12-09 17:54 ` Rob Herring
2016-12-09 18:28 ` Heiko Stuebner
2016-12-02 2:27 ` [PATCH 7/9] arm64: dts: rockchip: add Gru/Kevin DTS Brian Norris
2016-12-02 2:27 ` [PATCH 8/9] arm64: dts: rockchip: partially describe PWM regulators for Gru Brian Norris
2016-12-07 16:48 ` Heiko Stuebner
2016-12-07 17:09 ` Brian Norris [this message]
2016-12-13 17:48 ` Heiko Stuebner
2016-12-22 16:09 ` Heiko Stübner
2016-12-02 2:27 ` [PATCH 9/9] arm64: dts: rockchip: add regulator info for Kevin digitizer Brian Norris
2016-12-13 17:36 ` Heiko Stuebner
2017-02-08 1:01 ` [PATCH 0/9] arm64: dts: rockchip: support Google Kevin Heiko Stuebner
2017-02-08 1:03 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207170916.GA84287@google.com \
--to=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=smbarber@chromium.org \
--cc=wxt@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).