From: Heiko Stuebner <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Caesar Wang <wxt@rock-chips.com>,
Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Stephen Barber <smbarber@chromium.org>,
linux-arm-kernel@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin
Date: Wed, 07 Dec 2016 20:15:32 +0100 [thread overview]
Message-ID: <4532061.zEGHLIjg0t@phil> (raw)
In-Reply-To: <20161207174139.GA87970@google.com>
Am Mittwoch, 7. Dezember 2016, 09:41:39 CET schrieb Brian Norris:
> On Wed, Dec 07, 2016 at 06:12:13PM +0100, Heiko Stuebner wrote:
> > Hi Brian,
> >
> > Am Donnerstag, 1. Dezember 2016, 18:27:30 CET schrieb Brian Norris:
> > > Gru is a base dev board for a family of devices, including Kevin. Both
> > > utilize Rockchip RK3399, and they share much of their design.
> > >
> > > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > > ---
> > >
> > > Documentation/devicetree/bindings/arm/rockchip.txt | 20
> > >
> > > ++++++++++++++++++++ 1 file changed, 20 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> > > b/Documentation/devicetree/bindings/arm/rockchip.txt index
> > > cc4ace6397ab..830e13f5890c 100644
> > > --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> > > @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings
> > >
> > > "google,veyron-speedy-rev3", "google,veyron-speedy-rev2",
> > > "google,veyron-speedy", "google,veyron", "rockchip,rk3288";
> > >
> > > +- Google Gru (dev-board):
> > boards sorted alphabetically please
> >
> > Brian, Gru, Jaq, ... Kevin, ...
> >
> > While the sorting of old boards is not right yet, new boards should be
> > sorted.
> I got the idea that there was some attempt to group logically before
> alphabetically. Like keeping board/SoC families together. But maybe not.
>
> I can do as you suggested, if you don't care about keeping actual
> similar boards together (i.e., veyron/3288 vs gru/3399).
I'd prefer a simple alphabetical sorting.
I think people reading the document will know what device they have, but not
necessarily the actual soc in it. At least I would look for Google Kevin
primarily without thinking of the soc at first.
And in general, most Rockchip boards (maybe except Google-boards) tend to
follow the reference design quite closely, so it may become hard to decide
when one is similar to another :-) . So best to keep it simple.
next prev parent reply other threads:[~2016-12-07 19:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 2:27 [PATCH 0/9] arm64: dts: rockchip: support Google Kevin Brian Norris
2016-12-02 2:27 ` [PATCH 1/9] arm64: dts: Add symlinks for cros-ec-keyboard and cros-ec-sbs Brian Norris
2016-12-02 2:27 ` [PATCH 2/9] arm64: dts: rockchip: add rk3399 thermal_zones phandle Brian Norris
2016-12-07 16:55 ` Heiko Stuebner
2016-12-02 2:27 ` [PATCH 3/9] arm64: dts: rockchip: add rk3399 eDP HPD pinctrl Brian Norris
2016-12-07 16:56 ` Heiko Stuebner
2016-12-02 2:27 ` [PATCH 4/9] arm64: dts: rockchip: support dwc3 USB for rk3399 Brian Norris
2016-12-07 17:09 ` Heiko Stuebner
2016-12-07 17:52 ` Brian Norris
2016-12-07 19:01 ` Heiko Stuebner
2016-12-07 19:03 ` Brian Norris
2016-12-07 19:09 ` Heiko Stuebner
2016-12-02 2:27 ` [PATCH 5/9] arm64: dts: rockchip: add rk3399 OPPs Brian Norris
2016-12-02 2:27 ` [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Brian Norris
2016-12-07 17:12 ` Heiko Stuebner
2016-12-07 17:41 ` Brian Norris
2016-12-07 19:15 ` Heiko Stuebner [this message]
2016-12-09 17:54 ` Rob Herring
2016-12-09 18:28 ` Heiko Stuebner
2016-12-02 2:27 ` [PATCH 7/9] arm64: dts: rockchip: add Gru/Kevin DTS Brian Norris
2016-12-02 2:27 ` [PATCH 8/9] arm64: dts: rockchip: partially describe PWM regulators for Gru Brian Norris
2016-12-07 16:48 ` Heiko Stuebner
2016-12-07 17:09 ` Brian Norris
2016-12-13 17:48 ` Heiko Stuebner
2016-12-22 16:09 ` Heiko Stübner
2016-12-02 2:27 ` [PATCH 9/9] arm64: dts: rockchip: add regulator info for Kevin digitizer Brian Norris
2016-12-13 17:36 ` Heiko Stuebner
2017-02-08 1:01 ` [PATCH 0/9] arm64: dts: rockchip: support Google Kevin Heiko Stuebner
2017-02-08 1:03 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4532061.zEGHLIjg0t@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=smbarber@chromium.org \
--cc=wxt@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).