* [PATCH] dts: sun8i-h3: correct UART3 pin definitions
@ 2016-12-06 14:27 jorik
2016-12-06 14:31 ` Maxime Ripard
2016-12-07 20:40 ` Olof Johansson
0 siblings, 2 replies; 5+ messages in thread
From: jorik @ 2016-12-06 14:27 UTC (permalink / raw)
To: arm, maxime.ripard, wens
Cc: robh+dt, mark.rutland, linux, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi, Jorik Jonker
From: Jorik Jonker <jorik@kippendief.biz>
In a previous commit, I made a copy/paste error in the pinmux
definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes
care of that. I have tested this commit on Orange Pi PC and Orange Pi
Plus, and it works for these boards.
Fixes: e3d11d3c45c5 ("dts: sun8i-h3: add pinmux definitions for
UART2-3")
Signed-off-by: Jorik Jonker <jorik@kippendief.biz>
---
arch/arm/boot/dts/sun8i-h3.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 75a8654..f4ba088 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -410,7 +410,7 @@
};
uart3_pins: uart3 {
- allwinner,pins = "PG13", "PG14";
+ allwinner,pins = "PA13", "PA14";
allwinner,function = "uart3";
allwinner,drive = <SUN4I_PINCTRL_10_MA>;
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dts: sun8i-h3: correct UART3 pin definitions
2016-12-06 14:27 [PATCH] dts: sun8i-h3: correct UART3 pin definitions jorik
@ 2016-12-06 14:31 ` Maxime Ripard
2016-12-07 20:40 ` Olof Johansson
1 sibling, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2016-12-06 14:31 UTC (permalink / raw)
To: arm, jorik
Cc: wens, robh+dt, mark.rutland, linux, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Hi Arnd, Olof,
On Tue, Dec 06, 2016 at 03:27:10PM +0100, jorik@kippendief.biz wrote:
> From: Jorik Jonker <jorik@kippendief.biz>
>
> In a previous commit, I made a copy/paste error in the pinmux
> definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes
> care of that. I have tested this commit on Orange Pi PC and Orange Pi
> Plus, and it works for these boards.
>
> Fixes: e3d11d3c45c5 ("dts: sun8i-h3: add pinmux definitions for
> UART2-3")
>
> Signed-off-by: Jorik Jonker <jorik@kippendief.biz>
Could you please queue that patch for 4.9, with
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dts: sun8i-h3: correct UART3 pin definitions
2016-12-06 14:27 [PATCH] dts: sun8i-h3: correct UART3 pin definitions jorik
2016-12-06 14:31 ` Maxime Ripard
@ 2016-12-07 20:40 ` Olof Johansson
1 sibling, 0 replies; 5+ messages in thread
From: Olof Johansson @ 2016-12-07 20:40 UTC (permalink / raw)
To: jorik
Cc: arm, maxime.ripard, wens, mark.rutland, devicetree, linux,
linux-kernel, linux-sunxi, robh+dt, linux-arm-kernel
On Tue, Dec 06, 2016 at 03:27:10PM +0100, jorik@kippendief.biz wrote:
> From: Jorik Jonker <jorik@kippendief.biz>
>
> In a previous commit, I made a copy/paste error in the pinmux
> definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes
> care of that. I have tested this commit on Orange Pi PC and Orange Pi
> Plus, and it works for these boards.
>
> Fixes: e3d11d3c45c5 ("dts: sun8i-h3: add pinmux definitions for
> UART2-3")
>
> Signed-off-by: Jorik Jonker <jorik@kippendief.biz>
Applied to fixes. Thanks.
-Olof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dts: sun8i-h3: correct UART3 pin definitions
2016-12-04 12:29 jorik
@ 2016-12-06 14:05 ` Maxime Ripard
0 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2016-12-06 14:05 UTC (permalink / raw)
To: jorik
Cc: wens, robh+dt, mark.rutland, linux, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi, arm
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
Hi Jorik,
On Sun, Dec 04, 2016 at 01:29:48PM +0100, jorik@kippendief.biz wrote:
> From: Jorik Jonker <jorik@kippendief.biz>
>
> In a previous commit, I made a copy/paste error in the pinmux
> definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes
> care of that. I have tested this commit on Orange Pi PC and Orange Pi
> Plus, and it works for these boards.
>
> Fixes: e3d11d3c45c5 ("dts: sun8i-h3: add pinmux definitions for
> UART2-3")
>
> Signed-off-by: Jorik Jonker <jorik@kippendief.biz>
Thanks!
This looks like a late fix for the current release which comes to an
end. Can you resend it with arm@kernel.org as a recipient, so that the
ARM SoC maintainers can apply it directly?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] dts: sun8i-h3: correct UART3 pin definitions
@ 2016-12-04 12:29 jorik
2016-12-06 14:05 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: jorik @ 2016-12-04 12:29 UTC (permalink / raw)
To: maxime.ripard, wens
Cc: robh+dt, mark.rutland, linux, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi, Jorik Jonker
From: Jorik Jonker <jorik@kippendief.biz>
In a previous commit, I made a copy/paste error in the pinmux
definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes
care of that. I have tested this commit on Orange Pi PC and Orange Pi
Plus, and it works for these boards.
Fixes: e3d11d3c45c5 ("dts: sun8i-h3: add pinmux definitions for
UART2-3")
Signed-off-by: Jorik Jonker <jorik@kippendief.biz>
---
arch/arm/boot/dts/sun8i-h3.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 75a8654..f4ba088 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -410,7 +410,7 @@
};
uart3_pins: uart3 {
- allwinner,pins = "PG13", "PG14";
+ allwinner,pins = "PA13", "PA14";
allwinner,function = "uart3";
allwinner,drive = <SUN4I_PINCTRL_10_MA>;
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-07 20:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-06 14:27 [PATCH] dts: sun8i-h3: correct UART3 pin definitions jorik
2016-12-06 14:31 ` Maxime Ripard
2016-12-07 20:40 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2016-12-04 12:29 jorik
2016-12-06 14:05 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).