From: Sakari Ailus <sakari.ailus@iki.fi>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
mchehab@kernel.org, tiwai@suse.com, perex@perex.cz,
hans.verkuil@cisco.com, javier@osg.samsung.com,
chehabrafael@gmail.com, g.liakhovetski@gmx.de, ONeukum@suse.com,
k@oikw.org, daniel@zonque.org, mahasler@gmail.com,
clemens@ladisch.de, geliangtang@163.com, vdronov@redhat.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources
Date: Thu, 8 Dec 2016 00:27:38 +0200 [thread overview]
Message-ID: <20161207222738.GY16630@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <f83b60c1-9e1a-df5c-b1ec-de2ddd219307@osg.samsung.com>
Hi Shuah,
On Wed, Dec 07, 2016 at 01:03:59PM -0700, Shuah Khan wrote:
> Hi Sakari,
>
> On 12/07/2016 03:52 AM, Sakari Ailus wrote:
> > Hi Shuah,
> >
> > On Mon, Dec 05, 2016 at 05:38:23PM -0700, Shuah Khan wrote:
> >> On 12/05/2016 04:21 PM, Laurent Pinchart wrote:
> >>> Hi Shuah,
> >>>
> >>> On Monday 05 Dec 2016 15:44:30 Shuah Khan wrote:
> >>>> On 11/30/2016 03:01 PM, Shuah Khan wrote:
> >>>>> Change ALSA driver to use Media Controller API to share media resources
> >>>>> with DVB, and V4L2 drivers on a AU0828 media device.
> >>>>>
> >>>>> Media Controller specific initialization is done after sound card is
> >>>>> registered. ALSA creates Media interface and entity function graph
> >>>>> nodes for Control, Mixer, PCM Playback, and PCM Capture devices.
> >>>>>
> >>>>> snd_usb_hw_params() will call Media Controller enable source handler
> >>>>> interface to request the media resource. If resource request is granted,
> >>>>> it will release it from snd_usb_hw_free(). If resource is busy, -EBUSY is
> >>>>> returned.
> >>>>>
> >>>>> Media specific cleanup is done in usb_audio_disconnect().
> >>>>>
> >>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> >>>>
> >>>> Hi Takashi,
> >>>>
> >>>> If you are good with this patch, could you please Ack it, so Mauro
> >>>> can pull it into media tree with the other two patches in this series,
> >>>> when he is ready to do so.
> >>>
> >>> I *really* want to address the concerns raised by Sakari before pulling more
> >>> code that makes fixing the race conditions more difficult. Please, let's all
> >>> work on fixing the core code to build a stable base on which we can build
> >>> additional features. V4L2 and MC need teamwork, it's time to give the
> >>> subsystem the love it deserves.
> >>>
> >>
> >> Hi Laurent,
> >>
> >> The issue Sakari brought up is specific to using devm for video_device in
> >> omap3 and vsp1. I tried reproducing the problem on two different drivers
> >> and couldn't on Linux 4.9-rc7.
> >>
> >> After sharing that with Sakari, I suggested to Sakari to pull up his patch
> >> that removes the devm usage and see if he still needs all the patches in his
> >> patch series. He didn't back to me on that. I also requested him to rebase on
> >
> > Just to see what remains, I made a small hack to test this with omap3isp by
> > just replacing the devm_() functions by their plain counterparts. The memory
> > is thus never released, for there is no really a proper moment to release it
> > --- something which the patchset resolves. The result is here:
> >
> > <URL:http://www.retiisi.org.uk/v4l2/tmp/media-ref-dmesg.txt>
>
> Did you test this on 4.9-rc7 without any of your other patches? If you
> haven't could you please run this test with just the removing devm usage
> from omap3isp?
>
> It would be good to get a baseline on the current with just the not using
> devm first and then see what needs fixing.
>
> Also, could you please send me the complete dmesg.
Updated from v4.9-rc6 to rc7 and with increased CONFIG_LOG_BUF_SHIFT. The
diff and dmesg are here:
<URL:http://www.retiisi.org.uk/v4l2/tmp/media-ref-diff2.txt>
<URL:http://www.retiisi.org.uk/v4l2/tmp/media-ref-dmesg2.txt>
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2016-12-07 22:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 22:01 [PATCH v6 0/3] Media Device Allocator API Shuah Khan
2016-11-30 22:01 ` [PATCH v6 1/3] media: " Shuah Khan
2016-11-30 22:01 ` [PATCH v6 2/3] media: change au0828 to use " Shuah Khan
2016-11-30 22:01 ` [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources Shuah Khan
2016-12-05 22:44 ` Shuah Khan
2016-12-05 23:21 ` Laurent Pinchart
2016-12-06 0:38 ` Shuah Khan
2016-12-06 13:17 ` Laurent Pinchart
2016-12-07 10:52 ` Sakari Ailus
2016-12-07 20:03 ` Shuah Khan
2016-12-07 22:27 ` Sakari Ailus [this message]
2016-12-08 14:46 ` Shuah Khan
2016-12-08 23:44 ` Sakari Ailus
2016-12-09 13:17 ` Sakari Ailus
2016-12-09 16:40 ` Shuah Khan
2016-12-06 7:11 ` Takashi Iwai
2016-12-06 6:50 ` Takashi Iwai
2016-12-06 18:41 ` Shuah Khan
2016-12-06 19:06 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207222738.GY16630@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=ONeukum@suse.com \
--cc=alsa-devel@alsa-project.org \
--cc=chehabrafael@gmail.com \
--cc=clemens@ladisch.de \
--cc=daniel@zonque.org \
--cc=g.liakhovetski@gmx.de \
--cc=geliangtang@163.com \
--cc=hans.verkuil@cisco.com \
--cc=javier@osg.samsung.com \
--cc=k@oikw.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mahasler@gmail.com \
--cc=mchehab@kernel.org \
--cc=perex@perex.cz \
--cc=shuahkh@osg.samsung.com \
--cc=tiwai@suse.com \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).