From: Takashi Iwai <tiwai@suse.de>
To: "Shuah Khan" <shuahkh@osg.samsung.com>
Cc: <mchehab@kernel.org>, <geliangtang@163.com>,
<alsa-devel@alsa-project.org>, <hans.verkuil@cisco.com>,
<chehabrafael@gmail.com>, <mahasler@gmail.com>,
<g.liakhovetski@gmx.de>, <laurent.pinchart@ideasonboard.com>,
<sakari.ailus@iki.fi>, <clemens@ladisch.de>, <k@oikw.org>,
<javier@osg.samsung.com>, <perex@perex.cz>, <vdronov@redhat.com>,
"Oliver Neukum" <ONeukum@suse.com>,
<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
<daniel@zonque.org>
Subject: Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources
Date: Tue, 06 Dec 2016 08:11:59 +0100 [thread overview]
Message-ID: <s5h4m2h5y68.wl-tiwai@suse.de> (raw)
In-Reply-To: <69ad05a8-8572-43e7-ef76-7510edd904c6@osg.samsung.com>
On Mon, 05 Dec 2016 23:44:30 +0100,
Shuah Khan wrote:
>
> On 11/30/2016 03:01 PM, Shuah Khan wrote:
> > Change ALSA driver to use Media Controller API to share media resources
> > with DVB, and V4L2 drivers on a AU0828 media device.
> >
> > Media Controller specific initialization is done after sound card is
> > registered. ALSA creates Media interface and entity function graph
> > nodes for Control, Mixer, PCM Playback, and PCM Capture devices.
> >
> > snd_usb_hw_params() will call Media Controller enable source handler
> > interface to request the media resource. If resource request is granted,
> > it will release it from snd_usb_hw_free(). If resource is busy, -EBUSY is
> > returned.
> >
> > Media specific cleanup is done in usb_audio_disconnect().
> >
> > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>
> Hi Takashi,
>
> If you are good with this patch, could you please Ack it, so Mauro
> can pull it into media tree with the other two patches in this series,
> when he is ready to do so.
Sorry for the late review.
The biggest concern right now is the way the driver is probed. As
mentioned in the review reply, we need to consider the cases where the
probe is called multiple times. Other things are minor.
thanks,
Takashi
next prev parent reply other threads:[~2016-12-06 7:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 22:01 [PATCH v6 0/3] Media Device Allocator API Shuah Khan
2016-11-30 22:01 ` [PATCH v6 1/3] media: " Shuah Khan
2016-11-30 22:01 ` [PATCH v6 2/3] media: change au0828 to use " Shuah Khan
2016-11-30 22:01 ` [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources Shuah Khan
2016-12-05 22:44 ` Shuah Khan
2016-12-05 23:21 ` Laurent Pinchart
2016-12-06 0:38 ` Shuah Khan
2016-12-06 13:17 ` Laurent Pinchart
2016-12-07 10:52 ` Sakari Ailus
2016-12-07 20:03 ` Shuah Khan
2016-12-07 22:27 ` Sakari Ailus
2016-12-08 14:46 ` Shuah Khan
2016-12-08 23:44 ` Sakari Ailus
2016-12-09 13:17 ` Sakari Ailus
2016-12-09 16:40 ` Shuah Khan
2016-12-06 7:11 ` Takashi Iwai [this message]
2016-12-06 6:50 ` Takashi Iwai
2016-12-06 18:41 ` Shuah Khan
2016-12-06 19:06 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4m2h5y68.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=ONeukum@suse.com \
--cc=alsa-devel@alsa-project.org \
--cc=chehabrafael@gmail.com \
--cc=clemens@ladisch.de \
--cc=daniel@zonque.org \
--cc=g.liakhovetski@gmx.de \
--cc=geliangtang@163.com \
--cc=hans.verkuil@cisco.com \
--cc=javier@osg.samsung.com \
--cc=k@oikw.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mahasler@gmail.com \
--cc=mchehab@kernel.org \
--cc=perex@perex.cz \
--cc=sakari.ailus@iki.fi \
--cc=shuahkh@osg.samsung.com \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).