linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux.com>, Michal Hocko <mhocko@suse.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Linux-MM <linux-mm@kvack.org>,
	Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7
Date: Wed, 7 Dec 2016 23:25:31 +0000	[thread overview]
Message-ID: <20161207232531.fxqdgrweilej5gs6@techsingularity.net> (raw)
In-Reply-To: <20161207211958.s3ymjva54wgakpkm@techsingularity.net>

On Wed, Dec 07, 2016 at 09:19:58PM +0000, Mel Gorman wrote:
> At small packet sizes on localhost, I see relatively low page allocator
> activity except during the socket setup and other unrelated activity
> (khugepaged, irqbalance, some btrfs stuff) which is curious as it's
> less clear why the performance was improved in that case. I considered
> the possibility that it was cache hotness of pages but that's not a
> good fit. If it was true then the first test would be slow and the rest
> relatively fast and I'm not seeing that. The other side-effect is that
> all the high-order pages that are allocated at the start are physically
> close together but that shouldn't have that big an impact. So for now,
> the gain is unexplained even though it happens consistently.
> 

Further investigation led me to conclude that the netperf automation on
my side had some methodology errors that could account for an artifically
low score in some cases. The netperf automation is years old and would
have been developed against a much older and smaller machine which may be
why I missed it until I went back looking at exactly what the automation
was doing. Minimally in a server/client test on remote maching there was
potentially higher packet loss than is acceptable. This would account why
some machines "benefitted" while others did not -- there would be boot to
boot variations that some machines happened to be "lucky". I believe I've
corrected the errors, discarded all the old data and scheduled a rest to
see what falls out.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2016-12-07 23:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07 10:12 [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman
2016-12-07 14:52 ` Christoph Lameter
2016-12-07 15:57   ` Mel Gorman
2016-12-07 16:40     ` Christoph Lameter
2016-12-07 16:45       ` Mel Gorman
2016-12-07 17:11         ` Christoph Lameter
2016-12-07 17:35           ` Mel Gorman
2016-12-07 19:00 ` Eric Dumazet
2016-12-07 19:11   ` Eric Dumazet
2016-12-07 19:48   ` Mel Gorman
2016-12-07 20:10     ` Eric Dumazet
2016-12-07 21:19       ` Mel Gorman
2016-12-07 23:25         ` Mel Gorman [this message]
2016-12-08  8:22           ` Jesper Dangaard Brouer
2016-12-08  9:18             ` Mel Gorman
2016-12-08 10:43               ` Jesper Dangaard Brouer
2016-12-08 11:06                 ` Mel Gorman
2016-12-08 14:48                   ` Jesper Dangaard Brouer
2016-12-08 15:11                     ` Mel Gorman
2016-12-08 17:19                       ` Jesper Dangaard Brouer
2016-12-08 17:39                         ` Mel Gorman
2016-12-08 16:04               ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161207232531.fxqdgrweilej5gs6@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=akpm@linux-foundation.org \
    --cc=brouer@redhat.com \
    --cc=cl@linux.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).