From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>, Michal Hocko <mhocko@suse.com>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Linux-MM <linux-mm@kvack.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
brouer@redhat.com
Subject: Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7
Date: Thu, 8 Dec 2016 15:48:13 +0100 [thread overview]
Message-ID: <20161208154813.5dafae7b@redhat.com> (raw)
In-Reply-To: <20161208110656.bnkvqg73qnjkehbc@techsingularity.net>
On Thu, 8 Dec 2016 11:06:56 +0000
Mel Gorman <mgorman@techsingularity.net> wrote:
> On Thu, Dec 08, 2016 at 11:43:08AM +0100, Jesper Dangaard Brouer wrote:
> > > That's expected. In the initial sniff-test, I saw negligible packet loss.
> > > I'm waiting to see what the full set of network tests look like before
> > > doing any further adjustments.
> >
> > For netperf I will not recommend adjusting the global default
> > /proc/sys/net/core/rmem_default as netperf have means of adjusting this
> > value from the application (which were the options you setup too low
> > and just removed). I think you should keep this as the default for now
> > (unless Eric says something else), as this should cover most users.
> >
>
> Ok, the current state is that buffer sizes are only set for netperf
> UDP_STREAM and only when running over a real network. The values selected
> were specific to the network I had available so milage may vary.
> localhost is left at the defaults.
Looks like you made a mistake when re-implementing using buffer sizes
for netperf. See patch below signature.
Besides I think you misunderstood me, you can adjust:
sysctl net.core.rmem_max
sysctl net.core.wmem_max
And you should if you plan to use/set 851968 as socket size for UDP
remote tests, else you will be limited to the "max" values (212992 well
actually 425984 2x default value, for reasons I cannot remember)
https://github.com/gormanm/mmtests/commit/de9f8cdb7146021
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
[PATCH] mmtests: actually use variable SOCKETSIZE_OPT
From: Jesper Dangaard Brouer <brouer@redhat.com>
commit 7f16226577b2 ("netperf: Set remote and local socket max buffer
sizes") removed netperf's setting of the socket buffer sizes and
instead used global /proc/sys settings.
commit de9f8cdb7146 ("netperf: Only adjust socket sizes for
UDP_STREAM") re-added explicit netperf setting socket buffer sizes for
remote-host testing (saved in SOCKETSIZE_OPT). Only problem is this
variable is not used after commit 7f16226577b2.
Simply use $SOCKETSIZE_OPT when invoking netperf command.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
shellpack_src/src/netperf/netperf-bench | 2 +-
shellpacks/shellpack-bench-netperf | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/shellpack_src/src/netperf/netperf-bench b/shellpack_src/src/netperf/netperf-bench
index 8e7d02864c4a..b2820610936e 100755
--- a/shellpack_src/src/netperf/netperf-bench
+++ b/shellpack_src/src/netperf/netperf-bench
@@ -93,7 +93,7 @@ mmtests_server_ctl start --serverside-name $PROTOCOL-$SIZE
-t $PROTOCOL \
-i 3,3 -I 95,5 \
-H $SERVER_HOST \
- -- $MSGSIZE_OPT $EXTRA \
+ -- $SOCKETSIZE_OPT $MSGSIZE_OPT $EXTRA \
2>&1 | tee $LOGDIR_RESULTS/$PROTOCOL-${SIZE}.$ITERATION \
|| die Failed to run netperf
monitor_post_hook $LOGDIR_RESULTS $SIZE
diff --git a/shellpacks/shellpack-bench-netperf b/shellpacks/shellpack-bench-netperf
index 2ce26ba39f1b..7356082d5a78 100755
--- a/shellpacks/shellpack-bench-netperf
+++ b/shellpacks/shellpack-bench-netperf
@@ -190,7 +190,7 @@ for ITERATION in `seq 1 $ITERATIONS`; do
-t $PROTOCOL \
-i 3,3 -I 95,5 \
-H $SERVER_HOST \
- -- $MSGSIZE_OPT $EXTRA \
+ -- $SOCKETSIZE_OPT $MSGSIZE_OPT $EXTRA \
2>&1 | tee $LOGDIR_RESULTS/$PROTOCOL-${SIZE}.$ITERATION \
|| die Failed to run netperf
monitor_post_hook $LOGDIR_RESULTS $SIZE
next prev parent reply other threads:[~2016-12-08 14:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 10:12 [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman
2016-12-07 14:52 ` Christoph Lameter
2016-12-07 15:57 ` Mel Gorman
2016-12-07 16:40 ` Christoph Lameter
2016-12-07 16:45 ` Mel Gorman
2016-12-07 17:11 ` Christoph Lameter
2016-12-07 17:35 ` Mel Gorman
2016-12-07 19:00 ` Eric Dumazet
2016-12-07 19:11 ` Eric Dumazet
2016-12-07 19:48 ` Mel Gorman
2016-12-07 20:10 ` Eric Dumazet
2016-12-07 21:19 ` Mel Gorman
2016-12-07 23:25 ` Mel Gorman
2016-12-08 8:22 ` Jesper Dangaard Brouer
2016-12-08 9:18 ` Mel Gorman
2016-12-08 10:43 ` Jesper Dangaard Brouer
2016-12-08 11:06 ` Mel Gorman
2016-12-08 14:48 ` Jesper Dangaard Brouer [this message]
2016-12-08 15:11 ` Mel Gorman
2016-12-08 17:19 ` Jesper Dangaard Brouer
2016-12-08 17:39 ` Mel Gorman
2016-12-08 16:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208154813.5dafae7b@redhat.com \
--to=brouer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).