From: "Michał Kępień" <kernel@kempniu.pl>
To: "Richard Purdie" <rpurdie@rpsys.net>,
"Jacek Anaszewski" <j.anaszewski@samsung.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Darren Hart" <dvhart@infradead.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>
Cc: Bob Rodgers <Robert_Rodgers@dell.com>,
Louis Davis <Louis_Davis@dell.com>,
Jim Dailey <Jim_Dailey@dell.com>,
Alex Hung <alex.hung@canonical.com>,
Hui Wang <hui.wang@canonical.com>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] Move dell-led to drivers/platform/x86
Date: Thu, 8 Dec 2016 13:36:11 +0100 [thread overview]
Message-ID: <20161208123618.28603-1-kernel@kempniu.pl> (raw)
This patch series moves the dell-led driver from the LED subsystem to
the x86 platform driver subsystem. I decided to also CC the sound
subsystem contacts for the whole series as
sound/pci/hda/dell_wmi_helper.c is also affected.
The original motivation behind this effort was to move all code using
the dell-smbios module to the x86 platform driver subsystem. While I
was investigating the possibilites to do that, it quickly emerged that
dell-led can and in fact should be moved to the x86 platform driver
subsystem in its entirety.
dell-led consists of two major parts:
- the part exposing a microphone mute LED interface, introduced in
db6d8cc ("dell-led: add mic mute led interface"); this interface is
used by sound/pci/hda/dell_wmi_helper.c; while the original
implementation used a WMI interface, it was changed to use
dell-smbios in cf0d7ea ("dell-led: use dell_smbios_find_token() for
finding mic DMI tokens") and 0c41a08 ("dell-led: use
dell_smbios_send_request() for performing SMBIOS calls"),
- the part handling an activity LED present in Dell Latitude 2100
netbooks, introduced in 72dcd8d ("leds: Add Dell Business Class
Netbook LED driver"); it binds to a specific WMI GUID and then
registers a LED device which is controlled using WMI (i.e. it is
basically a WMI driver).
Patches 1-4 clean up the microphone mute LED interface to minimize the
amount of code moved around.
Patch 5 moves the microphone mute LED interface to
drivers/platform/x86/dell-laptop.c, effectively causing
sound/pci/hda/dell_wmi_helper.c to depend on CONFIG_DELL_LAPTOP instead
of CONFIG_LEDS_DELL_NETBOOKS.
Patch 6 reverts dell-led to the state it was in after its initial commit
72dcd8d ("leds: Add Dell Business Class Netbook LED driver") by removing
all remnants of the microphone mute LED handling code.
Patch 7 moves all that is left of dell-led (i.e. the activity LED part,
as originally implemented), to a new module which is placed in
drivers/platform/x86/dell-wmi-led.c.
This patch series is based on linux-leds/for-4.11 as the LED subsystem
is affected by all patches except patch 3.
If anyone reading this has access to a Dell device which has an activity
LED and/or a microphone mute LED currently supported by dell-led, I
would love to hear from you as I do not have the hardware needed to
practically test this patch series.
drivers/leds/Kconfig | 9 ---
drivers/leds/Makefile | 1 -
drivers/platform/x86/Kconfig | 8 +++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/dell-laptop.c | 28 ++++++++
.../dell-led.c => platform/x86/dell-wmi-led.c} | 75 +++-------------------
include/linux/dell-led.h | 6 +-
sound/pci/hda/dell_wmi_helper.c | 18 +++---
8 files changed, 55 insertions(+), 91 deletions(-)
rename drivers/{leds/dell-led.c => platform/x86/dell-wmi-led.c} (73%)
--
2.10.2
next reply other threads:[~2016-12-08 12:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161208123909epcas3p23229f5e0d337e19a27b272211798d364@epcas3p2.samsung.com>
2016-12-08 12:36 ` Michał Kępień [this message]
2016-12-08 12:36 ` [PATCH 1/7] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień
2016-12-09 9:20 ` Pali Rohár
2016-12-15 14:34 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 2/7] dell-led: export dell_micmute_led_set() Michał Kępień
2016-12-08 12:36 ` [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set() Michał Kępień
2016-12-11 10:40 ` Pali Rohár
2016-12-15 14:46 ` Michał Kępień
2016-12-15 15:43 ` Pali Rohár
2016-12-15 19:22 ` Michał Kępień
2017-01-09 13:26 ` Michał Kępień
2017-01-09 14:47 ` Takashi Iwai
2017-01-10 5:28 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Michał Kępień
2016-12-11 10:40 ` Pali Rohár
2016-12-14 1:54 ` Andy Shevchenko
2016-12-14 1:57 ` Andy Shevchenko
2016-12-15 14:48 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 5/7] dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c Michał Kępień
2016-12-08 12:36 ` [PATCH 6/7] dell-led: remove code related to mic mute LED Michał Kępień
2016-12-08 12:36 ` [PATCH 7/7] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c Michał Kępień
2016-12-14 2:05 ` Andy Shevchenko
2016-12-15 14:54 ` Michał Kępień
2016-12-08 14:26 ` [PATCH 0/7] Move dell-led to drivers/platform/x86 Jacek Anaszewski
2016-12-11 10:45 ` Pali Rohár
[not found] <00c7k8btg2g3lgupdy340rwj.1481476421177@email.android.com>
[not found] ` <CAE7LaDAQokSHNvwEfVnUiAQT=hzsgXtq9rgi5dw3qTewnBkSSg@mail.gmail.com>
2016-12-15 14:57 ` Michał Kępień
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208123618.28603-1-kernel@kempniu.pl \
--to=kernel@kempniu.pl \
--cc=Jim_Dailey@dell.com \
--cc=Louis_Davis@dell.com \
--cc=Robert_Rodgers@dell.com \
--cc=alex.hung@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=dvhart@infradead.org \
--cc=hui.wang@canonical.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).