linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Kępień" <kernel@kempniu.pl>
To: "Richard Purdie" <rpurdie@rpsys.net>,
	"Jacek Anaszewski" <j.anaszewski@samsung.com>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Darren Hart" <dvhart@infradead.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>
Cc: Bob Rodgers <Robert_Rodgers@dell.com>,
	Louis Davis <Louis_Davis@dell.com>,
	Jim Dailey <Jim_Dailey@dell.com>,
	Alex Hung <alex.hung@canonical.com>,
	Hui Wang <hui.wang@canonical.com>,
	linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] dell-led: export dell_micmute_led_set()
Date: Thu,  8 Dec 2016 13:36:13 +0100	[thread overview]
Message-ID: <20161208123618.28603-3-kernel@kempniu.pl> (raw)
In-Reply-To: <20161208123618.28603-1-kernel@kempniu.pl>

When the dell_app_wmi_led_set() method was introduced in db6d8cc
("dell-led: add mic mute led interface"), it was implemented as an
easily extensible entry point for other modules to set the state of
various LEDs.  However, almost three years later it is still only used
to control the mic mute LED, so it will be replaced with direct calls to
dell_micmute_led_set().  For this to be possible, dell_micmute_led_set()
has to be exported first.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
---
 drivers/leds/dell-led.c  | 3 ++-
 include/linux/dell-led.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c
index e8e8f67..b215248 100644
--- a/drivers/leds/dell-led.c
+++ b/drivers/leds/dell-led.c
@@ -46,7 +46,7 @@ MODULE_ALIAS("wmi:" DELL_LED_BIOS_GUID);
 #define GLOBAL_MIC_MUTE_ENABLE	0x364
 #define GLOBAL_MIC_MUTE_DISABLE	0x365
 
-static int dell_micmute_led_set(int state)
+int dell_micmute_led_set(int state)
 {
 	struct calling_interface_buffer *buffer;
 	struct calling_interface_token *token;
@@ -69,6 +69,7 @@ static int dell_micmute_led_set(int state)
 
 	return state;
 }
+EXPORT_SYMBOL_GPL(dell_micmute_led_set);
 
 int dell_app_wmi_led_set(int whichled, int on)
 {
diff --git a/include/linux/dell-led.h b/include/linux/dell-led.h
index 7009b8b..1b03275 100644
--- a/include/linux/dell-led.h
+++ b/include/linux/dell-led.h
@@ -5,6 +5,7 @@ enum {
 	DELL_LED_MICMUTE,
 };
 
+int dell_micmute_led_set(int on);
 int dell_app_wmi_led_set(int whichled, int on);
 
 #endif
-- 
2.10.2

  parent reply	other threads:[~2016-12-08 12:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161208123909epcas3p23229f5e0d337e19a27b272211798d364@epcas3p2.samsung.com>
2016-12-08 12:36 ` [PATCH 0/7] Move dell-led to drivers/platform/x86 Michał Kępień
2016-12-08 12:36   ` [PATCH 1/7] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień
2016-12-09  9:20     ` Pali Rohár
2016-12-15 14:34       ` Michał Kępień
2016-12-08 12:36   ` Michał Kępień [this message]
2016-12-08 12:36   ` [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set() Michał Kępień
2016-12-11 10:40     ` Pali Rohár
2016-12-15 14:46       ` Michał Kępień
2016-12-15 15:43         ` Pali Rohár
2016-12-15 19:22           ` Michał Kępień
2017-01-09 13:26             ` Michał Kępień
2017-01-09 14:47               ` Takashi Iwai
2017-01-10  5:28                 ` Michał Kępień
2016-12-08 12:36   ` [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Michał Kępień
2016-12-11 10:40     ` Pali Rohár
2016-12-14  1:54       ` Andy Shevchenko
2016-12-14  1:57         ` Andy Shevchenko
2016-12-15 14:48           ` Michał Kępień
2016-12-08 12:36   ` [PATCH 5/7] dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c Michał Kępień
2016-12-08 12:36   ` [PATCH 6/7] dell-led: remove code related to mic mute LED Michał Kępień
2016-12-08 12:36   ` [PATCH 7/7] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c Michał Kępień
2016-12-14  2:05     ` Andy Shevchenko
2016-12-15 14:54       ` Michał Kępień
2016-12-08 14:26   ` [PATCH 0/7] Move dell-led to drivers/platform/x86 Jacek Anaszewski
2016-12-11 10:45     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161208123618.28603-3-kernel@kempniu.pl \
    --to=kernel@kempniu.pl \
    --cc=Jim_Dailey@dell.com \
    --cc=Louis_Davis@dell.com \
    --cc=Robert_Rodgers@dell.com \
    --cc=alex.hung@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dvhart@infradead.org \
    --cc=hui.wang@canonical.com \
    --cc=j.anaszewski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali.rohar@gmail.com \
    --cc=perex@perex.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).