* [PATCH] xen/pci: Bubble up error and fix description.
@ 2016-12-06 14:28 Konrad Rzeszutek Wilk
2016-12-06 14:34 ` Juergen Gross
2016-12-08 6:58 ` Juergen Gross
0 siblings, 2 replies; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-06 14:28 UTC (permalink / raw)
To: linux-kernel, xen-devel, boris.ostrovsky, bhelgaas, jgross, x86,
linux-pci
Cc: Konrad Rzeszutek Wilk
The function is never called under PV guests, and only shows up
when MSI (or MSI-X) cannot be allocated. Convert the message
to include the error value.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/pci/xen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index bedfab9..e1fb269 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
return 0;
error:
- dev_err(&dev->dev,
- "Xen PCI frontend has not registered MSI/MSI-X support!\n");
+ dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n",
+ type == PCI_CAP_ID_MSI ? "" : "-X", irq);
return irq;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/pci: Bubble up error and fix description.
2016-12-06 14:28 [PATCH] xen/pci: Bubble up error and fix description Konrad Rzeszutek Wilk
@ 2016-12-06 14:34 ` Juergen Gross
2016-12-08 6:58 ` Juergen Gross
1 sibling, 0 replies; 4+ messages in thread
From: Juergen Gross @ 2016-12-06 14:34 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, linux-kernel, xen-devel, boris.ostrovsky,
bhelgaas, x86, linux-pci
Cc: Konrad Rzeszutek Wilk
On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote:
> The function is never called under PV guests, and only shows up
> when MSI (or MSI-X) cannot be allocated. Convert the message
> to include the error value.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
> ---
> arch/x86/pci/xen.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index bedfab9..e1fb269 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> return 0;
>
> error:
> - dev_err(&dev->dev,
> - "Xen PCI frontend has not registered MSI/MSI-X support!\n");
> + dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n",
> + type == PCI_CAP_ID_MSI ? "" : "-X", irq);
> return irq;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/pci: Bubble up error and fix description.
2016-12-06 14:28 [PATCH] xen/pci: Bubble up error and fix description Konrad Rzeszutek Wilk
2016-12-06 14:34 ` Juergen Gross
@ 2016-12-08 6:58 ` Juergen Gross
2016-12-08 18:53 ` Konrad Rzeszutek Wilk
1 sibling, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2016-12-08 6:58 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, linux-kernel, xen-devel, boris.ostrovsky,
bhelgaas, x86, linux-pci
Cc: Konrad Rzeszutek Wilk
On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote:
> The function is never called under PV guests, and only shows up
> when MSI (or MSI-X) cannot be allocated. Convert the message
> to include the error value.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Commited to xen/tip.git for-linus-4.10
Juergen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/pci: Bubble up error and fix description.
2016-12-08 6:58 ` Juergen Gross
@ 2016-12-08 18:53 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-08 18:53 UTC (permalink / raw)
To: Juergen Gross, f
Cc: Konrad Rzeszutek Wilk, linux-kernel, xen-devel, boris.ostrovsky,
bhelgaas, x86, linux-pci
On Thu, Dec 08, 2016 at 07:58:29AM +0100, Juergen Gross wrote:
> On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote:
> > The function is never called under PV guests, and only shows up
> > when MSI (or MSI-X) cannot be allocated. Convert the message
> > to include the error value.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Commited to xen/tip.git for-linus-4.10
Thank you!
>
>
> Juergen
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-08 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-06 14:28 [PATCH] xen/pci: Bubble up error and fix description Konrad Rzeszutek Wilk
2016-12-06 14:34 ` Juergen Gross
2016-12-08 6:58 ` Juergen Gross
2016-12-08 18:53 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).