* [v2] clk:mmp:clk-of-mmp2: Free memory and Unmap region obtained by kzalloc and of_iomap
@ 2016-09-20 11:08 Arvind Yadav
2016-12-09 0:20 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2016-09-20 11:08 UTC (permalink / raw)
To: mturquette, sboyd; +Cc: linux-clk, linux-kernel, Arvind Yadav
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Free memory and memory mapping , if mmp2_clk_init is not successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clk/mmp/clk-of-mmp2.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/mmp/clk-of-mmp2.c b/drivers/clk/mmp/clk-of-mmp2.c
index 3a51fff..2376d28 100644
--- a/drivers/clk/mmp/clk-of-mmp2.c
+++ b/drivers/clk/mmp/clk-of-mmp2.c
@@ -309,21 +309,23 @@ static void __init mmp2_clk_init(struct device_node *np)
pxa_unit->mpmu_base = of_iomap(np, 0);
if (!pxa_unit->mpmu_base) {
pr_err("failed to map mpmu registers\n");
- return;
+ goto free_memory;
}
pxa_unit->apmu_base = of_iomap(np, 1);
if (!pxa_unit->mpmu_base) {
pr_err("failed to map apmu registers\n");
- return;
+ goto unmap_mpmu_region;
}
pxa_unit->apbc_base = of_iomap(np, 2);
if (!pxa_unit->apbc_base) {
pr_err("failed to map apbc registers\n");
- return;
+ goto unmap_apmu_region;
}
+ return;
+
mmp_clk_init(np, &pxa_unit->unit, MMP2_NR_CLKS);
mmp2_pll_init(pxa_unit);
@@ -333,6 +335,13 @@ static void __init mmp2_clk_init(struct device_node *np)
mmp2_axi_periph_clk_init(pxa_unit);
mmp2_clk_reset_init(np, pxa_unit);
+
+unmap_apmu_region:
+ iounmap(pxa_unit->apmu_base);
+unmap_mpmu_region:
+ iounmap(pxa_unit->mpmu_base);
+free_memory:
+ kfree(pxa_unit);
}
CLK_OF_DECLARE(mmp2_clk, "marvell,mmp2-clock", mmp2_clk_init);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v2] clk:mmp:clk-of-mmp2: Free memory and Unmap region obtained by kzalloc and of_iomap
2016-09-20 11:08 [v2] clk:mmp:clk-of-mmp2: Free memory and Unmap region obtained by kzalloc and of_iomap Arvind Yadav
@ 2016-12-09 0:20 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2016-12-09 0:20 UTC (permalink / raw)
To: Arvind Yadav; +Cc: mturquette, linux-clk, linux-kernel
On 09/20, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Free memory and memory mapping , if mmp2_clk_init is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/clk/mmp/clk-of-mmp2.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/mmp/clk-of-mmp2.c b/drivers/clk/mmp/clk-of-mmp2.c
> index 3a51fff..2376d28 100644
> --- a/drivers/clk/mmp/clk-of-mmp2.c
> +++ b/drivers/clk/mmp/clk-of-mmp2.c
> @@ -309,21 +309,23 @@ static void __init mmp2_clk_init(struct device_node *np)
> pxa_unit->mpmu_base = of_iomap(np, 0);
> if (!pxa_unit->mpmu_base) {
> pr_err("failed to map mpmu registers\n");
> - return;
> + goto free_memory;
> }
>
> pxa_unit->apmu_base = of_iomap(np, 1);
> if (!pxa_unit->mpmu_base) {
> pr_err("failed to map apmu registers\n");
> - return;
> + goto unmap_mpmu_region;
> }
>
> pxa_unit->apbc_base = of_iomap(np, 2);
> if (!pxa_unit->apbc_base) {
> pr_err("failed to map apbc registers\n");
> - return;
> + goto unmap_apmu_region;
> }
>
> + return;
That doesn't seem right. I moved the return...
> +
> mmp_clk_init(np, &pxa_unit->unit, MMP2_NR_CLKS);
>
> mmp2_pll_init(pxa_unit);
> @@ -333,6 +335,13 @@ static void __init mmp2_clk_init(struct device_node *np)
> mmp2_axi_periph_clk_init(pxa_unit);
>
> mmp2_clk_reset_init(np, pxa_unit);
To here.
> +
> +unmap_apmu_region:
> + iounmap(pxa_unit->apmu_base);
> +unmap_mpmu_region:
> + iounmap(pxa_unit->mpmu_base);
> +free_memory:
> + kfree(pxa_unit);
> }
>
> CLK_OF_DECLARE(mmp2_clk, "marvell,mmp2-clock", mmp2_clk_init);
> --
> 1.7.9.5
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-09 0:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-20 11:08 [v2] clk:mmp:clk-of-mmp2: Free memory and Unmap region obtained by kzalloc and of_iomap Arvind Yadav
2016-12-09 0:20 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).