From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh@kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Linux-DT <devicetree@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
linux-clk@vger.kernel.org,
Linux-ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] clkdev: add devm_get_clk_from_child()
Date: Fri, 9 Dec 2016 20:31:27 +0000 [thread overview]
Message-ID: <20161209203127.GR14217@n2100.armlinux.org.uk> (raw)
In-Reply-To: <8737i3vtl7.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Dec 05, 2016 at 05:23:20AM +0000, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Some driver is using this type of DT bindings for clock (more detail,
> see ${LINUX}/Documentation/devicetree/bindings/sound/simple-card.txt).
>
> sound_soc {
> ...
> cpu {
> clocks = <&xxx>;
> ...
> };
> codec {
> clocks = <&xxx>;
> ...
> };
> };
>
> Current driver in this case uses of_clk_get() for each node, but there
> is no devm_of_clk_get() today.
> OTOH, the problem of having devm_of_clk_get() is that it encourages the
> use of of_clk_get() when clk_get() is more desirable.
>
> Thus, this patch adds new devm_get_clk_from_chile() which explicitly
> reads as get a clock from a child node of this device.
> By this function, we can also use this type of DT bindings
>
> sound_soc {
> clocks = <&xxx>, <&xxx>;
> clock-names = "cpu", "codec";
> ...
> cpu {
> ...
> };
> codec {
> ...
> };
> };
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
This looks lots better, thanks.
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-12-09 20:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 5:22 [PATCH 0/3] clkdev: add devm_get_clk_from_child() Kuninori Morimoto
2016-12-05 5:23 ` [PATCH 1/3] " Kuninori Morimoto
2016-12-09 20:31 ` Russell King - ARM Linux [this message]
2016-12-05 5:23 ` [PATCH 2/3] ASoC: simple-card: use devm_get_clk_from_child() Kuninori Morimoto
2016-12-08 22:09 ` Stephen Boyd
2016-12-09 0:20 ` Kuninori Morimoto
2016-12-09 0:28 ` Stephen Boyd
2016-12-09 0:33 ` Kuninori Morimoto
2017-01-24 18:39 ` Applied "ASoC: simple-card: use devm_get_clk_from_child()" to the asoc tree Mark Brown
2016-12-05 5:23 ` [PATCH 3/3] ASoC: simple-card-utils: enable clocks/clock-names/clock-ranges Kuninori Morimoto
2016-12-08 22:09 ` Stephen Boyd
2016-12-09 0:21 ` Kuninori Morimoto
2016-12-09 0:22 ` Kuninori Morimoto
2016-12-09 0:26 ` Stephen Boyd
2016-12-09 0:55 ` Kuninori Morimoto
2016-12-08 22:08 ` [PATCH 0/3] clkdev: add devm_get_clk_from_child() Stephen Boyd
2016-12-09 0:25 ` Kuninori Morimoto
2016-12-15 12:21 ` Mark Brown
2016-12-16 0:02 ` Kuninori Morimoto
2017-03-29 1:16 ` Question about of_clk_put ? Kuninori Morimoto
2017-03-30 1:46 ` [alsa-devel] " Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209203127.GR14217@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).