From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Rob Herring <robh@kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Linux-DT <devicetree@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>, <linux-clk@vger.kernel.org>,
Linux-ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ASoC: simple-card-utils: enable clocks/clock-names/clock-ranges
Date: Fri, 9 Dec 2016 00:22:21 +0000 [thread overview]
Message-ID: <874m2eymu3.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20161208220901.GN5423@codeaurora.org>
Hi Stephen
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Current simple-card is supporting this style for clocks
> >
> > sound {
> > ...
> > simple-audio-card,cpu {
> > sound-dai = <&xxx>;
> > clocks = <&cpu_clock>;
> > };
> > simple-audio-card,codec {
> > sound-dai = <&xxx>;
> > clocks = <&codec_clock>;
> > };
> > };
> >
> > Now, it can support this style too, because we can use
> > devm_get_clk_from_child() now.
> >
> > sound {
> > ...
> > clocks = <&cpu_clock>, <&codec_clock>;
> > clock-names = "cpu", "codec";
> > clock-ranges;
> > ...
> > simple-audio-card,cpu {
> > sound-dai = <&xxx>;
> > };
> > simple-audio-card,codec {
> > sound-dai = <&xxx>;
> > };
> > };
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> I don't see any reason why we need this patch though. The binding
> works as is, so supporting different styles doesn't seem like a
> good idea to me. Let's just keep what we have? Even if a sub-node
> like cpu or codec gets more than one element in the clocks list
> property, we can make that work by passing a clock-name then
> based on some sort of other knowledge.
OK, thanks. Let's skip this patch.
But I believe this idea/method itself is not wrong (?)
next prev parent reply other threads:[~2016-12-09 0:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 5:22 [PATCH 0/3] clkdev: add devm_get_clk_from_child() Kuninori Morimoto
2016-12-05 5:23 ` [PATCH 1/3] " Kuninori Morimoto
2016-12-09 20:31 ` Russell King - ARM Linux
2016-12-05 5:23 ` [PATCH 2/3] ASoC: simple-card: use devm_get_clk_from_child() Kuninori Morimoto
2016-12-08 22:09 ` Stephen Boyd
2016-12-09 0:20 ` Kuninori Morimoto
2016-12-09 0:28 ` Stephen Boyd
2016-12-09 0:33 ` Kuninori Morimoto
2017-01-24 18:39 ` Applied "ASoC: simple-card: use devm_get_clk_from_child()" to the asoc tree Mark Brown
2016-12-05 5:23 ` [PATCH 3/3] ASoC: simple-card-utils: enable clocks/clock-names/clock-ranges Kuninori Morimoto
2016-12-08 22:09 ` Stephen Boyd
2016-12-09 0:21 ` Kuninori Morimoto
2016-12-09 0:22 ` Kuninori Morimoto [this message]
2016-12-09 0:26 ` Stephen Boyd
2016-12-09 0:55 ` Kuninori Morimoto
2016-12-08 22:08 ` [PATCH 0/3] clkdev: add devm_get_clk_from_child() Stephen Boyd
2016-12-09 0:25 ` Kuninori Morimoto
2016-12-15 12:21 ` Mark Brown
2016-12-16 0:02 ` Kuninori Morimoto
2017-03-29 1:16 ` Question about of_clk_put ? Kuninori Morimoto
2017-03-30 1:46 ` [alsa-devel] " Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m2eymu3.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).