From: Baoquan He <bhe@redhat.com>
To: Borislav Petkov <bp@suse.de>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com,
mingo@redhat.com, x86@kernel.org, keescook@chromium.org,
yinghai@kernel.org, thgarnie@google.com, kuleshovmail@gmail.com,
luto@kernel.org, mcgrof@kernel.org, anderson@redhat.com,
dyoung@redhat.com, xlpang@redhat.com
Subject: Re: [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size at runtime
Date: Sat, 10 Dec 2016 20:27:57 +0800 [thread overview]
Message-ID: <20161210122757.GE1034@x1> (raw)
In-Reply-To: <20161210103151.56d7k2iwwwu5acmw@pd.tnic>
On 12/10/16 at 11:31am, Borislav Petkov wrote:
> On Fri, Dec 09, 2016 at 10:41:58PM +0800, Baoquan He wrote:
> > X86 64 kernel takes KERNEL_IMAGE_SIZE as the kernel text mapping size,
> > and it's fixed as compiling time, changing from 512M to 1G as long as
> > CONFIG_RANDOMIZE_BASE is enabled, though people specify kernel option
> > "nokaslr" explicitly.
> >
> > This could be a wrong behaviour.
>
> A bunch of changes just because "this could be a wrong behavior". I'm
> not really persuaded.
Well, then apologize for this wrong expression. It should be "This is
a wrong behaviour."
Whether CONFIG_RANDOMIZE_BASE is yes or not, with 'nokaslr' specified,
Kernel text mapping size should be 512M, just the same as no kaslr code
compiled in.
Thanks
Baoquan
next prev parent reply other threads:[~2016-12-10 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 14:41 [PATCH v2 0/2] Determine kernel text mapping size at runtime for x86_64 Baoquan He
2016-12-09 14:41 ` [PATCH v2 1/2] x86/64: Make kernel text mapping always take one whole page table in early boot code Baoquan He
2016-12-09 14:41 ` [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size at runtime Baoquan He
2016-12-10 10:31 ` Borislav Petkov
2016-12-10 12:27 ` Baoquan He [this message]
2016-12-10 12:33 ` Borislav Petkov
2016-12-10 13:41 ` Baoquan He
2016-12-10 16:28 ` Borislav Petkov
2016-12-11 10:58 ` Baoquan He
2016-12-11 12:06 ` Borislav Petkov
2016-12-12 2:32 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210122757.GE1034@x1 \
--to=bhe@redhat.com \
--cc=anderson@redhat.com \
--cc=bp@suse.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
--cc=xlpang@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).