From: Borislav Petkov <bp@suse.de>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com,
mingo@redhat.com, x86@kernel.org, keescook@chromium.org,
yinghai@kernel.org, thgarnie@google.com, kuleshovmail@gmail.com,
luto@kernel.org, mcgrof@kernel.org, anderson@redhat.com,
dyoung@redhat.com, xlpang@redhat.com
Subject: Re: [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size at runtime
Date: Sat, 10 Dec 2016 13:33:41 +0100 [thread overview]
Message-ID: <20161210123340.begeyyiegktangh2@pd.tnic> (raw)
In-Reply-To: <20161210122757.GE1034@x1>
On Sat, Dec 10, 2016 at 08:27:57PM +0800, Baoquan He wrote:
> Whether CONFIG_RANDOMIZE_BASE is yes or not, with 'nokaslr' specified,
> Kernel text mapping size should be 512M, just the same as no kaslr code
> compiled in.
"should be" still doesn't really explain what the problem is. What's
wrong with it remaining 1G?
IOW, something like "The problem is X and the issues it causes are Y.
That's why we need to do Z."
Now please replace X,Y and Z with the real content.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2016-12-10 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 14:41 [PATCH v2 0/2] Determine kernel text mapping size at runtime for x86_64 Baoquan He
2016-12-09 14:41 ` [PATCH v2 1/2] x86/64: Make kernel text mapping always take one whole page table in early boot code Baoquan He
2016-12-09 14:41 ` [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size at runtime Baoquan He
2016-12-10 10:31 ` Borislav Petkov
2016-12-10 12:27 ` Baoquan He
2016-12-10 12:33 ` Borislav Petkov [this message]
2016-12-10 13:41 ` Baoquan He
2016-12-10 16:28 ` Borislav Petkov
2016-12-11 10:58 ` Baoquan He
2016-12-11 12:06 ` Borislav Petkov
2016-12-12 2:32 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210123340.begeyyiegktangh2@pd.tnic \
--to=bp@suse.de \
--cc=anderson@redhat.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
--cc=xlpang@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).