From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 4/5] perf tools: Allow to ignore missing pid
Date: Mon, 12 Dec 2016 11:33:30 -0300 [thread overview]
Message-ID: <20161212143330.GC5650@kernel.org> (raw)
In-Reply-To: <20161212143209.GB5650@kernel.org>
Em Mon, Dec 12, 2016 at 11:32:09AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Dec 12, 2016 at 11:35:42AM +0100, Jiri Olsa escreveu:
> > Adding perf_evsel::ignore_missing_cpu_thread bool.
> >
> > When set true, it allows perf to ignore error of missing
> > pid of perf event syscall.
> >
> > We remove missing thread id from the thread_map, so the
> > rest of the processing like ioctl and mmap won't get
> > disturbed with -1 fd
>
> What was the test performed? I tried it here the following while doing
> a 'make -j4 allmodconfig' in the background, i.e. tons of threads coming
> and going, and I sometimes get:
>
> [root@jouet ~]# perf record -u acme
> Error:
> The sys_perf_event_open() syscall returned with 3 (No such process) for
> event (cycles:ppp).
> /bin/dmesg may provide additional information.
> No CONFIG_PERF_EVENTS=y kernel support configured?
> [root@jouet ~]#
So I applied the first three patches, will continue after discussing
this.
- Arnaldo
> > The reason for supporting this is to ease up monitoring
> > group of pids, that 'disappear' before perf opens their
> > event. This currently leads perf to report error and exit
> > and makes perf record's -u option unusable under certain
> > setup.
> >
> > With this change we will allow this race and ignore such
> > failure with following warning:
> >
> > WARNING: Ignored open failure for pid 8605
> >
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Link: http://lkml.kernel.org/n/tip-atmzsjyhrt1j6xjwwmb84upg@git.kernel.org
> > ---
> > tools/perf/perf.h | 1 +
> > tools/perf/util/evsel.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> > tools/perf/util/evsel.h | 1 +
> > 3 files changed, 46 insertions(+)
> >
> > diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> > index 9a0236a4cf95..1c27d947c2fe 100644
> > --- a/tools/perf/perf.h
> > +++ b/tools/perf/perf.h
> > @@ -55,6 +55,7 @@ struct record_opts {
> > bool all_user;
> > bool tail_synthesize;
> > bool overwrite;
> > + bool ignore_missing_thread;
> > unsigned int freq;
> > unsigned int mmap_pages;
> > unsigned int auxtrace_mmap_pages;
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> > index fd61ebd77c26..ac87f1637ae9 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -990,6 +990,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts,
> > * it overloads any global configuration.
> > */
> > apply_config_terms(evsel, opts);
> > +
> > + evsel->ignore_missing_thread = opts->ignore_missing_thread;
> > }
> >
> > static int perf_evsel__alloc_fd(struct perf_evsel *evsel, int ncpus, int nthreads)
> > @@ -1419,6 +1421,33 @@ static int __open_attr__fprintf(FILE *fp, const char *name, const char *val,
> > return fprintf(fp, " %-32s %s\n", name, val);
> > }
> >
> > +static bool ignore_missing_thread(struct perf_evsel *evsel,
> > + struct thread_map *threads,
> > + int thread, int err)
> > +{
> > + if (!evsel->ignore_missing_thread)
> > + return false;
> > +
> > + /* The system wide setup does not work with threads. */
> > + if (!evsel->system_wide)
> > + return false;
> > +
> > + /* The -ESRCH is perf event syscall errno for pid's not found. */
> > + if (err != -ESRCH)
> > + return false;
> > +
> > + /* If there's only one thread, let it fail. */
> > + if (threads->nr == 1)
> > + return false;
> > +
> > + if (thread_map__remove(threads, thread))
> > + return false;
> > +
> > + pr_warning("WARNING: Ignored open failure for pid %d\n",
> > + thread_map__pid(threads, thread));
> > + return true;
> > +}
> > +
> > static int __perf_evsel__open(struct perf_evsel *evsel, struct cpu_map *cpus,
> > struct thread_map *threads)
> > {
> > @@ -1491,6 +1520,21 @@ static int __perf_evsel__open(struct perf_evsel *evsel, struct cpu_map *cpus,
> >
> > if (fd < 0) {
> > err = -errno;
> > +
> > + if (ignore_missing_thread(evsel, threads, thread, err)) {
> > + /*
> > + * We just removed 1 thread, so take a step
> > + * back on thread index and lower the upper
> > + * nthreads limit.
> > + */
> > + nthreads--;
> > + thread--;
> > +
> > + /* ... and pretend like nothing have happened. */
> > + err = 0;
> > + continue;
> > + }
> > +
> > pr_debug2("\nsys_perf_event_open failed, error %d\n",
> > err);
> > goto try_fallback;
> > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> > index 6abb89cd27f9..06ef6f29efa1 100644
> > --- a/tools/perf/util/evsel.h
> > +++ b/tools/perf/util/evsel.h
> > @@ -120,6 +120,7 @@ struct perf_evsel {
> > bool tracking;
> > bool per_pkg;
> > bool precise_max;
> > + bool ignore_missing_thread;
> > /* parse modifier helper */
> > int exclude_GH;
> > int nr_members;
> > --
> > 2.7.4
next prev parent reply other threads:[~2016-12-12 14:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 10:35 [PATCH 0/5] perf record: Allow to ignore missing pid Jiri Olsa
2016-12-12 10:35 ` [PATCH 1/5] perf mem: Fix --all-user/--all-kernel options Jiri Olsa
2016-12-12 13:43 ` Arnaldo Carvalho de Melo
2016-12-12 13:44 ` Jiri Olsa
2016-12-20 19:23 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2016-12-12 10:35 ` [PATCH 2/5] perf tools: Use variable instead of repeating lengthy FD macro Jiri Olsa
2016-12-20 19:23 ` [tip:perf/urgent] perf evsel: " tip-bot for Jiri Olsa
2016-12-12 10:35 ` [PATCH 3/5] perf tools: Add thread_map__remove function Jiri Olsa
2016-12-12 20:08 ` Arnaldo Carvalho de Melo
2016-12-12 20:21 ` Arnaldo Carvalho de Melo
2016-12-20 19:24 ` [tip:perf/urgent] perf thread_map: " tip-bot for Jiri Olsa
2016-12-12 10:35 ` [PATCH 4/5] perf tools: Allow to ignore missing pid Jiri Olsa
2016-12-12 14:32 ` Arnaldo Carvalho de Melo
2016-12-12 14:33 ` Arnaldo Carvalho de Melo [this message]
2016-12-12 14:53 ` Jiri Olsa
2016-12-12 15:21 ` Arnaldo Carvalho de Melo
2016-12-12 15:38 ` Jiri Olsa
2016-12-12 19:30 ` Arnaldo Carvalho de Melo
2016-12-12 16:58 ` Namhyung Kim
2016-12-13 7:46 ` [PATCHv2 " Jiri Olsa
2016-12-20 19:24 ` [tip:perf/urgent] perf evsel: " tip-bot for Jiri Olsa
2016-12-12 10:35 ` [PATCH 5/5] perf record: Force ignore_missing_thread for uid option Jiri Olsa
2016-12-20 19:25 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212143330.GC5650@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).