From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/5] perf mem: Fix --all-user/--all-kernel options
Date: Mon, 12 Dec 2016 14:44:52 +0100 [thread overview]
Message-ID: <20161212134452.GA25975@krava> (raw)
In-Reply-To: <20161212134311.GA5650@kernel.org>
On Mon, Dec 12, 2016 at 10:43:11AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Dec 12, 2016 at 11:35:39AM +0100, Jiri Olsa escreveu:
> > Removing extra '--' prefix.
>
> Please add a Fixes: tag in such cases, as this helps backporters to
> figure out what affects packages they published, in this case I'm
> adding:
>
> Fixes: ad16511b0e40 ("perf mem: Add -U/-K (--all-user/--all-kernel)
> options")
>
> And I just added this to the Todo[1] list:
>
> * Improve git pre-commit hook script to check for OPTION() with -- in
> its name, to fix bugs like ad16511b0e40 ("perf mem: Add -U/-K
> (--all-user/--all-kernel) options") (acme)
>
> :-)
I forgot ;-) thanks
jirka
>
> Thanks,
>
> - Arnaldo
>
> [1] https://perf.wiki.kernel.org/index.php/Todo
>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Link: http://lkml.kernel.org/n/tip-p8x8lf2ekjpqc2x5ixw61505@git.kernel.org
> > ---
> > tools/perf/builtin-mem.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
> > index d1ce29be560e..cd7bc4d104e2 100644
> > --- a/tools/perf/builtin-mem.c
> > +++ b/tools/perf/builtin-mem.c
> > @@ -70,8 +70,8 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
> > OPT_UINTEGER(0, "ldlat", &perf_mem_events__loads_ldlat, "mem-loads latency"),
> > OPT_INCR('v', "verbose", &verbose,
> > "be more verbose (show counter open errors, etc)"),
> > - OPT_BOOLEAN('U', "--all-user", &all_user, "collect only user level data"),
> > - OPT_BOOLEAN('K', "--all-kernel", &all_kernel, "collect only kernel level data"),
> > + OPT_BOOLEAN('U', "all-user", &all_user, "collect only user level data"),
> > + OPT_BOOLEAN('K', "all-kernel", &all_kernel, "collect only kernel level data"),
> > OPT_END()
> > };
> >
> > --
> > 2.7.4
next prev parent reply other threads:[~2016-12-12 13:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 10:35 [PATCH 0/5] perf record: Allow to ignore missing pid Jiri Olsa
2016-12-12 10:35 ` [PATCH 1/5] perf mem: Fix --all-user/--all-kernel options Jiri Olsa
2016-12-12 13:43 ` Arnaldo Carvalho de Melo
2016-12-12 13:44 ` Jiri Olsa [this message]
2016-12-20 19:23 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2016-12-12 10:35 ` [PATCH 2/5] perf tools: Use variable instead of repeating lengthy FD macro Jiri Olsa
2016-12-20 19:23 ` [tip:perf/urgent] perf evsel: " tip-bot for Jiri Olsa
2016-12-12 10:35 ` [PATCH 3/5] perf tools: Add thread_map__remove function Jiri Olsa
2016-12-12 20:08 ` Arnaldo Carvalho de Melo
2016-12-12 20:21 ` Arnaldo Carvalho de Melo
2016-12-20 19:24 ` [tip:perf/urgent] perf thread_map: " tip-bot for Jiri Olsa
2016-12-12 10:35 ` [PATCH 4/5] perf tools: Allow to ignore missing pid Jiri Olsa
2016-12-12 14:32 ` Arnaldo Carvalho de Melo
2016-12-12 14:33 ` Arnaldo Carvalho de Melo
2016-12-12 14:53 ` Jiri Olsa
2016-12-12 15:21 ` Arnaldo Carvalho de Melo
2016-12-12 15:38 ` Jiri Olsa
2016-12-12 19:30 ` Arnaldo Carvalho de Melo
2016-12-12 16:58 ` Namhyung Kim
2016-12-13 7:46 ` [PATCHv2 " Jiri Olsa
2016-12-20 19:24 ` [tip:perf/urgent] perf evsel: " tip-bot for Jiri Olsa
2016-12-12 10:35 ` [PATCH 5/5] perf record: Force ignore_missing_thread for uid option Jiri Olsa
2016-12-20 19:25 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212134452.GA25975@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).