From: Rob Herring <robh@kernel.org>
To: Sergio Prado <sergio.prado@e-labworks.com>
Cc: gregkh@linuxfoundation.org, mark.rutland@arm.com,
balbi@kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: add DT binding for s3c2410 USB device controller
Date: Tue, 13 Dec 2016 12:59:15 -0600 [thread overview]
Message-ID: <20161213185915.z2ze7wzx4im5hxdh@rob-hp-laptop> (raw)
In-Reply-To: <1481310400-28676-2-git-send-email-sergio.prado@e-labworks.com>
On Fri, Dec 09, 2016 at 05:06:39PM -0200, Sergio Prado wrote:
> Adds the device tree bindings description for Samsung S3C2410 and
> compatible USB device controller.
>
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
> .../devicetree/bindings/usb/s3c2410-usb.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/s3c2410-usb.txt b/Documentation/devicetree/bindings/usb/s3c2410-usb.txt
> index e45b38ce2986..4d3f9894c2d4 100644
> --- a/Documentation/devicetree/bindings/usb/s3c2410-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/s3c2410-usb.txt
> @@ -20,3 +20,31 @@ usb0: ohci@49000000 {
> clocks = <&clocks UCLK>, <&clocks HCLK_USBH>;
> clock-names = "usb-bus-host", "usb-host";
> };
> +
> +Samsung S3C2410 and compatible USB device controller
> +
> +Required properties:
> + - compatible: Should be one of the following
> + "samsung,s3c2410-udc"
> + "samsung,s3c2440-udc"
> + - reg: address and length of the controller memory mapped region
> + - interrupts: interrupt number for the USB device controller
> + - clocks: Should reference the bus and host clocks
> + - clock-names: Should contain two strings
> + "usb-bus-gadget" for the USB bus clock
Pretty sure the h/w clock name in the datasheet does not use the Linux
term gadget.
> + "usb-device" for the USB device clock
> +
> +Optional properties:
> + - samsung,vbus-gpio: If present, specifies a gpio that needs to be
> + activated for the bus to be powered.
Isn't it the host side that controls Vbus?
> + - samsung,pullup-gpio: If present, specifies a gpio to control the
Both GPIOs need to specify the active state.
> + USB D+ pullup.
> +
> +usb1: udc@52000000 {
> + compatible = "samsung,s3c2440-udc";
> + reg = <0x52000000 0x100000>;
> + interrupts = <0 0 25 3>;
> + clocks = <&clocks UCLK>, <&clocks HCLK_USBD>;
> + clock-names = "usb-bus-gadget", "usb-device";
> + samsung,pullup-gpio = <&gpc 5 GPIO_ACTIVE_HIGH>;
> +};
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-12-13 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 19:06 [PATCH 0/2] usb: gadget: s3c2410: add device tree support Sergio Prado
2016-12-09 19:06 ` [PATCH 1/2] dt-bindings: usb: add DT binding for s3c2410 USB device controller Sergio Prado
2016-12-13 18:59 ` Rob Herring [this message]
2016-12-17 12:50 ` Sergio Prado
2016-12-09 19:06 ` [PATCH 2/2] usb: gadget: s3c2410: allow probing from device tree Sergio Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213185915.z2ze7wzx4im5hxdh@rob-hp-laptop \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sergio.prado@e-labworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).