* [PATCH v3] ACPI: small formatting fixes
@ 2016-12-12 23:28 Nick Desaulniers
2016-12-12 23:47 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2016-12-12 23:28 UTC (permalink / raw)
Cc: rjw, len.brown, pavel, tglx, mingo, hpa, x86, linux-pm,
linux-kernel, joe, Nick Desaulniers
A quick cleanup with scripts/checkpatch.pl -f <file>.
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
arch/x86/kernel/acpi/cstate.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
index af15f44..8233a63 100644
--- a/arch/x86/kernel/acpi/cstate.c
+++ b/arch/x86/kernel/acpi/cstate.c
@@ -12,7 +12,6 @@
#include <linux/sched.h>
#include <acpi/processor.h>
-#include <asm/acpi.h>
#include <asm/mwait.h>
#include <asm/special_insns.h>
@@ -89,7 +88,8 @@ static long acpi_processor_ffh_cstate_probe_cpu(void *_cx)
retval = 0;
/* If the HW does not support any sub-states in this C-state */
if (num_cstate_subtype == 0) {
- pr_warn(FW_BUG "ACPI MWAIT C-state 0x%x not supported by HW (0x%x)\n", cx->address, edx_part);
+ pr_warn(FW_BUG "ACPI MWAIT C-state 0x%x not supported by HW (0x%x)\n",
+ cx->address, edx_part);
retval = -1;
goto out;
}
@@ -104,8 +104,8 @@ static long acpi_processor_ffh_cstate_probe_cpu(void *_cx)
if (!mwait_supported[cstate_type]) {
mwait_supported[cstate_type] = 1;
printk(KERN_DEBUG
- "Monitor-Mwait will be used to enter C-%d "
- "state\n", cx->type);
+ "Monitor-Mwait will be used to enter C-%d state\n",
+ cx->type);
}
snprintf(cx->desc,
ACPI_CX_DESC_LEN, "ACPI FFH INTEL MWAIT 0x%x",
@@ -166,6 +166,7 @@ EXPORT_SYMBOL_GPL(acpi_processor_ffh_cstate_enter);
static int __init ffh_cstate_init(void)
{
struct cpuinfo_x86 *c = &boot_cpu_data;
+
if (c->x86_vendor != X86_VENDOR_INTEL)
return -1;
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ACPI: small formatting fixes
2016-12-12 23:28 [PATCH v3] ACPI: small formatting fixes Nick Desaulniers
@ 2016-12-12 23:47 ` Joe Perches
2016-12-13 0:01 ` Nick Desaulniers
2016-12-13 19:00 ` Pavel Machek
0 siblings, 2 replies; 5+ messages in thread
From: Joe Perches @ 2016-12-12 23:47 UTC (permalink / raw)
To: Nick Desaulniers
Cc: rjw, len.brown, pavel, tglx, mingo, hpa, x86, linux-pm, linux-kernel
On Mon, 2016-12-12 at 15:28 -0800, Nick Desaulniers wrote:
> A quick cleanup with scripts/checkpatch.pl -f <file>.
>
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
What Pavel wrote was "Rest is good". That's not an ack.
You don't get to add "Acked-by" or any signature
without a specific use of that signature by the
other party.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ACPI: small formatting fixes
2016-12-12 23:47 ` Joe Perches
@ 2016-12-13 0:01 ` Nick Desaulniers
2016-12-13 0:23 ` Joe Perches
2016-12-13 19:00 ` Pavel Machek
1 sibling, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2016-12-13 0:01 UTC (permalink / raw)
To: Joe Perches
Cc: rjw, len.brown, pavel, tglx, mingo, hpa, x86, linux-pm, linux-kernel
>From https://lkml.org/lkml/2016/12/12/610:
>> Anyway with that fixed,
>> Acked-by: Pavel Machek <pavel@ucw.cz>
> That's not an ack.
Oh, sorry, should I resubmit v4 with the Ack removed from the commit
message?
~Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ACPI: small formatting fixes
2016-12-13 0:01 ` Nick Desaulniers
@ 2016-12-13 0:23 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2016-12-13 0:23 UTC (permalink / raw)
To: Nick Desaulniers
Cc: rjw, len.brown, pavel, tglx, mingo, hpa, x86, linux-pm, linux-kernel
On Mon, 2016-12-12 at 16:01 -0800, Nick Desaulniers wrote:
> From https://lkml.org/lkml/2016/12/12/610:
>
> > > Anyway with that fixed,
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > That's not an ack.
>
> Oh, sorry, should I resubmit v4 with the Ack removed from the commit
> message?
No, that's an ack I didn't notice.
cheers, Joe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ACPI: small formatting fixes
2016-12-12 23:47 ` Joe Perches
2016-12-13 0:01 ` Nick Desaulniers
@ 2016-12-13 19:00 ` Pavel Machek
1 sibling, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2016-12-13 19:00 UTC (permalink / raw)
To: Joe Perches
Cc: Nick Desaulniers, rjw, len.brown, tglx, mingo, hpa, x86,
linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On Mon 2016-12-12 15:47:54, Joe Perches wrote:
> On Mon, 2016-12-12 at 15:28 -0800, Nick Desaulniers wrote:
> > A quick cleanup with scripts/checkpatch.pl -f <file>.
> >
> > Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
>
> What Pavel wrote was "Rest is good". That's not an ack.
>
> You don't get to add "Acked-by" or any signature
> without a specific use of that signature by the
> other party.
Actually, it was ACK. Sorry if I was unclear.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-13 19:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-12 23:28 [PATCH v3] ACPI: small formatting fixes Nick Desaulniers
2016-12-12 23:47 ` Joe Perches
2016-12-13 0:01 ` Nick Desaulniers
2016-12-13 0:23 ` Joe Perches
2016-12-13 19:00 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).