linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] power: supply: bq24735-charger: optionally poll the ac-detect gpio
Date: Tue, 13 Dec 2016 13:30:09 -0600	[thread overview]
Message-ID: <20161213193009.5cqyaii3gjrttqyk@rob-hp-laptop> (raw)
In-Reply-To: <1481540424-19293-3-git-send-email-peda@axentia.se>

On Mon, Dec 12, 2016 at 12:00:23PM +0100, Peter Rosin wrote:
> If the ac-detect gpio does not support interrupts, provide a fallback
> to poll the gpio at a configurable interval.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../bindings/power/supply/ti,bq24735.txt           |  2 +
>  drivers/power/supply/bq24735-charger.c             | 50 +++++++++++++++++++---
>  2 files changed, 47 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power/supply/ti,bq24735.txt
> index 3bf55757ceec..59c4dde589cf 100644
> --- a/Documentation/devicetree/bindings/power/supply/ti,bq24735.txt
> +++ b/Documentation/devicetree/bindings/power/supply/ti,bq24735.txt
> @@ -25,6 +25,8 @@ Optional properties :
>   - ti,external-control : Indicates that the charger is configured externally
>     and that the host should not attempt to enable/disable charging or set the
>     charge voltage/current.
> + - ti,poll-interval-ms : In case there is no interrupts specified, poll AC
> +   presense on the ti,ac-detect-gpios GPIO with this interval.

We already have poll-interval and cm-poll-interval properties. Just use 
poll-interval here.

Rob

  reply	other threads:[~2016-12-13 19:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 11:00 [PATCH 0/3] bq24735-charger: allow gpio polling and sharing Peter Rosin
2016-12-12 11:00 ` [PATCH 1/3] power: supply: bq24735-charger: simplify register update to stop charging Peter Rosin
2016-12-12 11:00 ` [PATCH 2/3] power: supply: bq24735-charger: optionally poll the ac-detect gpio Peter Rosin
2016-12-13 19:30   ` Rob Herring [this message]
2016-12-12 11:00 ` [PATCH 3/3] power: supply: bq24735-charger: allow chargers to share " Peter Rosin
2016-12-12 11:39   ` Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161213193009.5cqyaii3gjrttqyk@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).