linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Max Bires <jbires@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: /drivers/char/Kconfig Bug Kernel Patch
Date: Tue, 13 Dec 2016 14:45:30 -0800	[thread overview]
Message-ID: <20161213224529.zbrm5tbtvxryvvux@x> (raw)
In-Reply-To: <CALVgH4SEM85zasRmkeKO6Kv4wMWgcAeM4eRMe00oFXUDDeAYhA@mail.gmail.com>

> From c4a21c2ac0c587094000a3daeb13eec6056dc63f Mon Sep 17 00:00:00 2001
> From: Max <jbires@google.com>
> Date: Fri, 9 Dec 2016 15:16:47 -0800
> Subject: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on
> 
> Without a bool string present, using "# CONFIG_DEVPORT is not set" in
> defconfig files would not actually unset devport. This ensured that
> /dev/port was always on, but there are reasons a user may wish to disable
> it (smaller kernel, attack surface reduction) if it's not being used. Adding
> a message here in order to make this user visible.
> 
> Signed-off-by: Max Bires <jbires@google.com>

This patch seems reasonable to me.

>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 7ad3127..70e626c 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -589,10 +589,13 @@ config TELCLOCK
>  	  controlling the behavior of this hardware.
> 
>  config DEVPORT
> -	bool
> +	bool "/dev/port character device"
>  	depends on !M68K
>  	depends on ISA || PCI
>  	default y
> +  help
> +    Say Y here if you want to support the /dev/port device. The
> +	  /dev/port device is similar to /dev/mem, but for I/O ports.
> 
>  config DCC_TTY
>  	tristate "DCC tty driver"
> -- 
> 2.8.0.rc3.226.g39d4020

  reply	other threads:[~2016-12-13 22:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CALVgH4QHDYw=j4k2iogL4FTvLXMExi6GqrskQoQ0bxP1MjN0Ew@mail.gmail.com>
2016-12-13 21:37 ` /drivers/char/Kconfig Bug Kernel Patch Arnd Bergmann
2016-12-13 22:42   ` Max Bires
2016-12-13 22:45     ` Josh Triplett [this message]
2016-12-14  0:05     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161213224529.zbrm5tbtvxryvvux@x \
    --to=josh@joshtriplett.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbires@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).