From: Arnd Bergmann <arnd@arndb.de>
To: Max Bires <jbires@google.com>
Cc: gregkh@linuxfoundation.org, josh@joshtriplett.org,
linux-kernel@vger.kernel.org
Subject: Re: /drivers/char/Kconfig Bug Kernel Patch
Date: Tue, 13 Dec 2016 22:37:58 +0100 [thread overview]
Message-ID: <25312310.aENfjP0Zdi@wuerfel> (raw)
In-Reply-To: <CALVgH4QHDYw=j4k2iogL4FTvLXMExi6GqrskQoQ0bxP1MjN0Ew@mail.gmail.com>
On Tuesday, December 13, 2016 1:30:39 PM CET Max Bires wrote:
> While trying to turn off the port device in defconfig, I ran into a bug
> caused by the fact that the Kconfig for port didn't have a string after the
> bool declaration. I fixed this in the attached patch (though I figure the
> description might need tuning up). Let me know if there's anything else I
> need to do.
The change looks reasonable, however there are a few things to improve
to get the patch applied:
- clarify that the current behavior is not a bug, but was done intentionally.
Making the option user-visible would help avoid a potential attack vector
and make the kernel smaller, both of which are useful.
- remove the "Change-id" line from the submission, it has no meaning in
an upstream kernel
- send the patch inline rather than as an attachment, this is usually done
with git-send-email.
Arnd
next parent reply other threads:[~2016-12-13 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALVgH4QHDYw=j4k2iogL4FTvLXMExi6GqrskQoQ0bxP1MjN0Ew@mail.gmail.com>
2016-12-13 21:37 ` Arnd Bergmann [this message]
2016-12-13 22:42 ` /drivers/char/Kconfig Bug Kernel Patch Max Bires
2016-12-13 22:45 ` Josh Triplett
2016-12-14 0:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25312310.aENfjP0Zdi@wuerfel \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jbires@google.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).