* linux-next: build warning after merge of the btrfs-kdave tree
@ 2016-11-28 0:02 Stephen Rothwell
2016-12-06 22:38 ` Stephen Rothwell
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2016-11-28 0:02 UTC (permalink / raw)
To: David Sterba; +Cc: linux-next, linux-kernel, Wang Xiaoguang
Hi David,
After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/btrfs/inode.c: In function 'run_delalloc_range':
fs/btrfs/inode.c:1219:9: warning: 'cur_end' may be used uninitialized in this function [-Wmaybe-uninitialized]
start = cur_end + 1;
^
fs/btrfs/inode.c:1172:6: note: 'cur_end' was declared here
u64 cur_end;
^
Introduced by commit
cow_file_range_async ("btrfs: Introduce COMPRESS reserve type to fix false enospc for compression")
Presumably a false positive because ASSERT(0) panics?
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2016-11-28 0:02 linux-next: build warning after merge of the btrfs-kdave tree Stephen Rothwell
@ 2016-12-06 22:38 ` Stephen Rothwell
2016-12-14 15:19 ` David Sterba
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2016-12-06 22:38 UTC (permalink / raw)
To: David Sterba; +Cc: linux-next, linux-kernel, Wang Xiaoguang
Hi David,
On Mon, 28 Nov 2016 11:02:30 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/btrfs/inode.c: In function 'run_delalloc_range':
> fs/btrfs/inode.c:1219:9: warning: 'cur_end' may be used uninitialized in this function [-Wmaybe-uninitialized]
> start = cur_end + 1;
> ^
> fs/btrfs/inode.c:1172:6: note: 'cur_end' was declared here
> u64 cur_end;
> ^
>
> Introduced by commit
>
> cow_file_range_async ("btrfs: Introduce COMPRESS reserve type to fix false enospc for compression")
>
> Presumably a false positive because ASSERT(0) panics?
Actually it does not if CONFIG_BTRFS_ASSERT is not set (which it isn't
for the above build), so this is not a false positive. I am still
seeing this.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2016-12-06 22:38 ` Stephen Rothwell
@ 2016-12-14 15:19 ` David Sterba
0 siblings, 0 replies; 16+ messages in thread
From: David Sterba @ 2016-12-14 15:19 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Wang Xiaoguang
On Wed, Dec 07, 2016 at 09:38:19AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> On Mon, 28 Nov 2016 11:02:30 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the btrfs-kdave tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > fs/btrfs/inode.c: In function 'run_delalloc_range':
> > fs/btrfs/inode.c:1219:9: warning: 'cur_end' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > start = cur_end + 1;
> > ^
> > fs/btrfs/inode.c:1172:6: note: 'cur_end' was declared here
> > u64 cur_end;
> > ^
> >
> > Introduced by commit
> >
> > cow_file_range_async ("btrfs: Introduce COMPRESS reserve type to fix false enospc for compression")
> >
> > Presumably a false positive because ASSERT(0) panics?
>
> Actually it does not if CONFIG_BTRFS_ASSERT is not set (which it isn't
> for the above build), so this is not a false positive. I am still
> seeing this.
Sorry for late reply. I've updatd the for-next branch now, the patches
introducing the warning have been removed temporarily. Arnd Bergmann
sent a patch to fix the warning, I'll make sure to include it so the
warning does not reappear.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2019-05-03 0:21 Stephen Rothwell
@ 2019-05-03 13:37 ` David Sterba
0 siblings, 0 replies; 16+ messages in thread
From: David Sterba @ 2019-05-03 13:37 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Josef Bacik
On Fri, May 03, 2019 at 10:21:05AM +1000, Stephen Rothwell wrote:
> Hi David,
>
> After merging the btrfs-kdave tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> fs/btrfs/props.c: In function 'inherit_props':
> fs/btrfs/props.c:389:4: warning: 'num_bytes' may be used uninitialized in this function [-Wmaybe-uninitialized]
> btrfs_block_rsv_release(fs_info, trans->block_rsv,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> num_bytes);
> ~~~~~~~~~~
>
> Probably introduced by commit
>
> b835a4a3faec ("btrfs: use the existing reserved items for our first prop for inheritance")
>
> Looks like a false positive to me.
Agreed and gcc 8.3.1 does not report that. Kbuild bot reported that as
well and it uses 7.x.
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the btrfs-kdave tree
@ 2019-05-03 0:21 Stephen Rothwell
2019-05-03 13:37 ` David Sterba
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2019-05-03 0:21 UTC (permalink / raw)
To: David Sterba
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Josef Bacik
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
Hi David,
After merging the btrfs-kdave tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
fs/btrfs/props.c: In function 'inherit_props':
fs/btrfs/props.c:389:4: warning: 'num_bytes' may be used uninitialized in this function [-Wmaybe-uninitialized]
btrfs_block_rsv_release(fs_info, trans->block_rsv,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
num_bytes);
~~~~~~~~~~
Probably introduced by commit
b835a4a3faec ("btrfs: use the existing reserved items for our first prop for inheritance")
Looks like a false positive to me.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2019-01-23 22:53 Stephen Rothwell
@ 2019-01-28 16:53 ` David Sterba
0 siblings, 0 replies; 16+ messages in thread
From: David Sterba @ 2019-01-28 16:53 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Qu Wenruo
On Thu, Jan 24, 2019 at 09:53:38AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/btrfs/relocation.c: In function 'insert_dirty_subv':
> fs/btrfs/relocation.c:2138:6: warning: unused variable 'root_objectid' [-Wunused-variable]
> u64 root_objectid = root->root_key.objectid;
> ^~~~~~~~~~~~~
>
> Introduced by commit
>
> 7b837199c581 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots()")
>
> Presumably the ASSERT is compiled out in this configuration.
Agreed, thanks for the report. I'll drop the temporary variable.
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the btrfs-kdave tree
@ 2019-01-23 22:53 Stephen Rothwell
2019-01-28 16:53 ` David Sterba
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2019-01-23 22:53 UTC (permalink / raw)
To: David Sterba
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Qu Wenruo
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
Hi David,
After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/btrfs/relocation.c: In function 'insert_dirty_subv':
fs/btrfs/relocation.c:2138:6: warning: unused variable 'root_objectid' [-Wunused-variable]
u64 root_objectid = root->root_key.objectid;
^~~~~~~~~~~~~
Introduced by commit
7b837199c581 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots()")
Presumably the ASSERT is compiled out in this configuration.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2018-11-26 0:06 Stephen Rothwell
@ 2018-11-26 7:56 ` Christoph Hellwig
0 siblings, 0 replies; 16+ messages in thread
From: Christoph Hellwig @ 2018-11-26 7:56 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David Sterba, Kees Cook, Linux Next Mailing List,
Linux Kernel Mailing List, Christoph Hellwig
On Mon, Nov 26, 2018 at 11:06:29AM +1100, Stephen Rothwell wrote:
> Introduced by commit
>
> cf8cddd38bab3 ("btrfs: don't abuse REQ_OP_* flags for btrfs_map_block")
>
> exposed by my new use of -Wimplicit-fallthrough
>
> I am not sure why this has only turned up now (as opposed to earlier
> today).
It looks like something only in linux-next moved the code around a bit.
Either way the fallthough looks fine, it will just need a little
/*FALLTHRU*/ annotation.
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the btrfs-kdave tree
@ 2018-11-26 0:06 Stephen Rothwell
2018-11-26 7:56 ` Christoph Hellwig
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2018-11-26 0:06 UTC (permalink / raw)
To: David Sterba, Kees Cook
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Christoph Hellwig
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
Hi David,
After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
In file included from include/linux/string.h:6,
from arch/powerpc/include/asm/paca.h:19,
from arch/powerpc/include/asm/current.h:16,
from include/linux/sched.h:12,
from fs/btrfs/volumes.c:6:
fs/btrfs/volumes.h: In function 'btrfs_op':
include/linux/compiler.h:77:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
# define unlikely(x) __builtin_expect(!!(x), 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bug.h:72:2: note: in expansion of macro 'unlikely'
unlikely(__ret_warn_on); \
^~~~~~~~
fs/btrfs/volumes.h:395:3: note: in expansion of macro 'WARN_ON_ONCE'
WARN_ON_ONCE(1);
^~~~~~~~~~~~
In file included from fs/btrfs/volumes.c:22:
fs/btrfs/volumes.h:396:2: note: here
case REQ_OP_READ:
^~~~
Introduced by commit
cf8cddd38bab3 ("btrfs: don't abuse REQ_OP_* flags for btrfs_map_block")
exposed by my new use of -Wimplicit-fallthrough
I am not sure why this has only turned up now (as opposed to earlier
today).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2017-12-21 16:49 ` David Sterba
@ 2017-12-22 0:32 ` Qu Wenruo
0 siblings, 0 replies; 16+ messages in thread
From: Qu Wenruo @ 2017-12-22 0:32 UTC (permalink / raw)
To: dsterba, Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List, arnd
[-- Attachment #1.1: Type: text/plain, Size: 1159 bytes --]
On 2017年12月22日 00:49, David Sterba wrote:
> On Wed, Dec 20, 2017 at 08:12:11AM +0800, Qu Wenruo wrote:
>> On 2017年12月20日 06:20, Stephen Rothwell wrote:
>>> After merging the btrfs-kdave tree, today's linux-next build (powerpc
>>> ppc64_defconfig) produced this warning:
>>>
>>> fs/btrfs/qgroup.c: In function 'qgroup_reserve':
>>> fs/btrfs/qgroup.c:2432:1: warning: label 'retry' defined but not used [-Wunused-label]
>>> retry:
>>> ^
>>>
>>> Introduced by commit
>>>
>>> b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"")
>>>
>> Sorry, I forgot to clean it up.
>>
>> I'll update the patchset along with new patches to handle qgroup limit
>> better.
>
> Meanwhile I've applied the fix from Arnd to silence the warning in
> linux-next builds.
>
Some (not much, may be 2 or 3) patches is going to be updated:
btrfs: delayed-inode: Use new qgroup meta rsv for delayed inode and item
Revert "btrfs: qgroups: Retry after commit on getting EDQUOT" ( For the
lable)
And with 2 more new patches.
Do I need to resend the patchset or use separate patches for them?
Thanks,
Qu
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2017-12-20 0:12 ` Qu Wenruo
@ 2017-12-21 16:49 ` David Sterba
2017-12-22 0:32 ` Qu Wenruo
0 siblings, 1 reply; 16+ messages in thread
From: David Sterba @ 2017-12-21 16:49 UTC (permalink / raw)
To: Qu Wenruo
Cc: Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List, arnd
On Wed, Dec 20, 2017 at 08:12:11AM +0800, Qu Wenruo wrote:
> On 2017年12月20日 06:20, Stephen Rothwell wrote:
> > After merging the btrfs-kdave tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > fs/btrfs/qgroup.c: In function 'qgroup_reserve':
> > fs/btrfs/qgroup.c:2432:1: warning: label 'retry' defined but not used [-Wunused-label]
> > retry:
> > ^
> >
> > Introduced by commit
> >
> > b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"")
> >
> Sorry, I forgot to clean it up.
>
> I'll update the patchset along with new patches to handle qgroup limit
> better.
Meanwhile I've applied the fix from Arnd to silence the warning in
linux-next builds.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2017-12-19 22:20 Stephen Rothwell
@ 2017-12-20 0:12 ` Qu Wenruo
2017-12-21 16:49 ` David Sterba
0 siblings, 1 reply; 16+ messages in thread
From: Qu Wenruo @ 2017-12-20 0:12 UTC (permalink / raw)
To: Stephen Rothwell, David Sterba
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 606 bytes --]
On 2017年12月20日 06:20, Stephen Rothwell wrote:
> Hi David,
>
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/btrfs/qgroup.c: In function 'qgroup_reserve':
> fs/btrfs/qgroup.c:2432:1: warning: label 'retry' defined but not used [-Wunused-label]
> retry:
> ^
>
> Introduced by commit
>
> b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"")
>
Sorry, I forgot to clean it up.
I'll update the patchset along with new patches to handle qgroup limit
better.
Thanks,
Qu
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the btrfs-kdave tree
@ 2017-12-19 22:20 Stephen Rothwell
2017-12-20 0:12 ` Qu Wenruo
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2017-12-19 22:20 UTC (permalink / raw)
To: David Sterba
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Qu Wenruo
Hi David,
After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/btrfs/qgroup.c: In function 'qgroup_reserve':
fs/btrfs/qgroup.c:2432:1: warning: label 'retry' defined but not used [-Wunused-label]
retry:
^
Introduced by commit
b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2017-05-18 12:50 ` David Sterba
@ 2017-05-25 1:31 ` Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2017-05-25 1:31 UTC (permalink / raw)
To: David Sterba; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Liu Bo
Hi David,
On Thu, 18 May 2017 14:50:00 +0200 David Sterba <dsterba@suse.cz> wrote:
>
> On Thu, May 18, 2017 at 09:41:46AM +1000, Stephen Rothwell wrote:
> > Hi David,
> >
> > After merging the btrfs-kdave tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > fs/btrfs/inode.c: In function 'btrfs_submit_direct':
> > fs/btrfs/inode.c:8467:14: warning: 'bio' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > struct bio *bio;
> > ^
> >
> > I can't tell if it is a false positive or not.
>
> It seems to be a false positive. Patch updated and will be part of the
> next for-next.
I am still getting this. Just checking that you didn't forget to push.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the btrfs-kdave tree
2017-05-17 23:41 Stephen Rothwell
@ 2017-05-18 12:50 ` David Sterba
2017-05-25 1:31 ` Stephen Rothwell
0 siblings, 1 reply; 16+ messages in thread
From: David Sterba @ 2017-05-18 12:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Liu Bo
On Thu, May 18, 2017 at 09:41:46AM +1000, Stephen Rothwell wrote:
> Hi David,
>
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/btrfs/inode.c: In function 'btrfs_submit_direct':
> fs/btrfs/inode.c:8467:14: warning: 'bio' may be used uninitialized in this function [-Wmaybe-uninitialized]
> struct bio *bio;
> ^
>
> I can't tell if it is a false positive or not.
It seems to be a false positive. Patch updated and will be part of the
next for-next.
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the btrfs-kdave tree
@ 2017-05-17 23:41 Stephen Rothwell
2017-05-18 12:50 ` David Sterba
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2017-05-17 23:41 UTC (permalink / raw)
To: David Sterba; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Liu Bo
Hi David,
After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/btrfs/inode.c: In function 'btrfs_submit_direct':
fs/btrfs/inode.c:8467:14: warning: 'bio' may be used uninitialized in this function [-Wmaybe-uninitialized]
struct bio *bio;
^
I can't tell if it is a false positive or not.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-05-03 13:36 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-28 0:02 linux-next: build warning after merge of the btrfs-kdave tree Stephen Rothwell
2016-12-06 22:38 ` Stephen Rothwell
2016-12-14 15:19 ` David Sterba
2017-05-17 23:41 Stephen Rothwell
2017-05-18 12:50 ` David Sterba
2017-05-25 1:31 ` Stephen Rothwell
2017-12-19 22:20 Stephen Rothwell
2017-12-20 0:12 ` Qu Wenruo
2017-12-21 16:49 ` David Sterba
2017-12-22 0:32 ` Qu Wenruo
2018-11-26 0:06 Stephen Rothwell
2018-11-26 7:56 ` Christoph Hellwig
2019-01-23 22:53 Stephen Rothwell
2019-01-28 16:53 ` David Sterba
2019-05-03 0:21 Stephen Rothwell
2019-05-03 13:37 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).