From: Vinod Koul <vinod.koul@intel.com>
To: Holger Dengler <dengler@linutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Siewior <bigeasy@linutronix.de>,
Juergen Bubeck <bubeck@xkrug.com>,
Peter Mahler <mahler@xkrug.com>,
Benedikt Spranger <b.spranger@linutronix.de>
Subject: Re: [PATCH 12/12] dma: Flexcard DMA ringbuffer demux driver
Date: Thu, 15 Dec 2016 10:08:51 +0530 [thread overview]
Message-ID: <20161215043851.GH25795@localhost> (raw)
In-Reply-To: <1481674313-30378-13-git-send-email-dengler@linutronix.de>
On Wed, Dec 14, 2016 at 01:11:53AM +0100, Holger Dengler wrote:
> The Flexcard interface design split packet receive and transmit. All
> received packets and card status information are multiplexed with a
> Flexcard specific protocol and handled through a DMA capable ringbuffer.
> The TX path has to poke each available component separate.
>
> Add a Flexcard DMA ringbuffer driver and packet demultiplexer.
so the dma driver should only provide service and not do demuxing...
> +config FLEXCARD_DMA
> + tristate "DMA support for Eberspaecher Flexcard PMC II Carrier Board"
> + depends on MFD_FLEXCARD
> + help
> + The Eberspaecher Flexcard PMC (PCI Mezzanine Card) II carrier
> + board support one DMA capable receive ringbuffer for all devices.
> + A card specific protocol is used to multiplex the received packets
> + through the ringbuffer. Enable DMA and Packet parser.
> +
This file is sorted alphabetically, so please add it it relavant place
> +#define DMA_TOTAL_BUF_SIZE (2*FLEXCARD_DMA_BUF_SIZE)
space around * pls
> +#define FLEXCARD_DMA_BUF_SIZE 0x200000
> +#define FLEXCARD_DMA_BUF_MASK (FLEXCARD_DMA_BUF_SIZE - 1)
> +
> +#define FLEXCARD_DMA_CTRL_DMA_ENA (1 << 0)
> +#define FLEXCARD_DMA_CTRL_MAN_ENA (1 << 1)
> +#define FLEXCARD_DMA_CTRL_STOP_REQ (1 << 16)
> +#define FLEXCARD_DMA_CTRL_DMA_IDLE (1 << 17)
> +#define FLEXCARD_DMA_CTRL_RST_DMA (1 << 31)
BIT() and friends please
> +
> +#define FLEXCARD_DMA_STAT_BUSY (1 << 15)
> +#define FLEXCARD_DMA_STAT_OFL (1 << 31)
> +
> +#define FLEXCARD_MAX_PAKET_SIZE 0x200
> +
> +#define FLEXCARD_BUF_HEADER_LEN_SHIFT 15
> +#define FLEXCARD_BUF_HEADER_LEN_MASK 0xfe
> +
> +#define FLEXCARD_CANIF_OFFSET 0x20
Okay I have skipped over the parser and other stuff and still looking for
the dmaengine APIs.
This driver _doesn't_ do that, and am not sure why.
Anyway, if this driver doesnt need dmaengine APIs it doesnt belong in
drivers/dma/. Otherwise please port to dmanegine APIs, possibly use parser
as a client. You cna use virt-channels as well for managing the transfers.
So I am not considering this submission
Thanks
--
~Vinod
next prev parent reply other threads:[~2016-12-15 4:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 0:11 [PATCH 00/12] Eberspaecher Flexcard PMC II base support Holger Dengler
2016-12-14 0:11 ` [PATCH 01/12] mfd: Eberspaecher Flexcard PMC II Carrier Board support Holger Dengler
2016-12-14 8:38 ` Arnd Bergmann
2017-01-05 13:52 ` Holger Dengler
2016-12-14 0:11 ` [PATCH 02/12] mfd: flexcard: add flexcard misc mfd-cell Holger Dengler
2016-12-14 0:11 ` [PATCH 03/12] mfd: flexcard: add posix clock mfd-cell Holger Dengler
2016-12-14 0:11 ` [PATCH 04/12] mfd: flexcard: add interrupt support Holger Dengler
2016-12-14 2:47 ` kbuild test robot
2016-12-14 3:37 ` kbuild test robot
2016-12-14 0:11 ` [PATCH 05/12] mfd: flexcard: add DMA interrupts Holger Dengler
2016-12-14 3:08 ` kbuild test robot
2016-12-14 0:11 ` [PATCH 06/12] mfd: flexcard: add DMA device Holger Dengler
2016-12-14 0:11 ` [PATCH 07/12] mfd: flexcard: add UIO IRQ devices Holger Dengler
2016-12-14 0:11 ` [PATCH 08/12] misc: Flexcard misc device support Holger Dengler
2016-12-14 8:42 ` Arnd Bergmann
2016-12-14 9:28 ` Holger Dengler
2017-01-10 16:59 ` Greg Kroah-Hartman
2016-12-14 0:11 ` [PATCH 09/12] misc: flexcard: add device attributes Holger Dengler
2016-12-14 1:33 ` kbuild test robot
2017-01-10 16:58 ` Greg Kroah-Hartman
2016-12-14 0:11 ` [PATCH 10/12] misc: Flexcard basic timestamp counter support Holger Dengler
2016-12-14 3:28 ` kbuild test robot
2016-12-14 8:46 ` Arnd Bergmann
2016-12-14 9:16 ` Thomas Gleixner
2016-12-14 0:11 ` [PATCH 11/12] misc: flexcard: Support timestamp trigger selection Holger Dengler
2016-12-14 0:11 ` [PATCH 12/12] dma: Flexcard DMA ringbuffer demux driver Holger Dengler
2016-12-14 1:54 ` kbuild test robot
2016-12-15 4:38 ` Vinod Koul [this message]
2016-12-19 10:54 ` Holger Dengler
2017-01-04 9:43 ` [PATCH 00/12] Eberspaecher Flexcard PMC II base support Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215043851.GH25795@localhost \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=b.spranger@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=bubeck@xkrug.com \
--cc=dengler@linutronix.de \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahler@xkrug.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).