From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Holger Dengler <dengler@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Siewior <bigeasy@linutronix.de>,
Juergen Bubeck <bubeck@xkrug.com>,
Peter Mahler <mahler@xkrug.com>,
Benedikt Spranger <b.spranger@linutronix.de>
Subject: Re: [PATCH 08/12] misc: Flexcard misc device support
Date: Tue, 10 Jan 2017 17:59:18 +0100 [thread overview]
Message-ID: <20170110165918.GB19767@kroah.com> (raw)
In-Reply-To: <aa635e90-cf5b-7610-6526-281fd9cc287b@linutronix.de>
On Wed, Dec 14, 2016 at 10:28:25AM +0100, Holger Dengler wrote:
> On 12/14/2016 09:42 AM, Arnd Bergmann wrote:
> > On Wednesday, December 14, 2016 1:11:49 AM CET Holger Dengler wrote:
> >> The Flexcard PCI BAR0 contain registers for configuration but also
> >> for informational purpose like error counter, statistical information
> >> and some timestamps. The read-only mmap of the misc device offers the
> >> userspace a fast access to these registers.
> >>
> >> Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
> >> Signed-off-by: Holger Dengler <dengler@linutronix.de>
> >> cc: Arnd Bergmann <arnd@arndb.de>
> >> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> ---
> >> drivers/mfd/Kconfig | 1 +
> >> drivers/misc/Kconfig | 6 ++
> >> drivers/misc/Makefile | 1 +
> >> drivers/misc/flexcard_misc.c | 165 +++++++++++++++++++++++++++++++++++++++++++
> >> 4 files changed, 173 insertions(+)
> >> create mode 100644 drivers/misc/flexcard_misc.c
> >>
> >
> > Maybe this could fit better in drivers/uio/ than drivers/misc? It
> > seems to only export a memory mapped device.
>
> You're right, this patch only introduce the memory mapping. But the
> next patch in series add also some attributes to the device, therfore
> we put it in drivers/misc.
That's fine, it should still be a uio driver as that's what it does.
You can have sysfs files for a UIO device, right?
thanks,
greg k-h
next prev parent reply other threads:[~2017-01-10 16:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 0:11 [PATCH 00/12] Eberspaecher Flexcard PMC II base support Holger Dengler
2016-12-14 0:11 ` [PATCH 01/12] mfd: Eberspaecher Flexcard PMC II Carrier Board support Holger Dengler
2016-12-14 8:38 ` Arnd Bergmann
2017-01-05 13:52 ` Holger Dengler
2016-12-14 0:11 ` [PATCH 02/12] mfd: flexcard: add flexcard misc mfd-cell Holger Dengler
2016-12-14 0:11 ` [PATCH 03/12] mfd: flexcard: add posix clock mfd-cell Holger Dengler
2016-12-14 0:11 ` [PATCH 04/12] mfd: flexcard: add interrupt support Holger Dengler
2016-12-14 2:47 ` kbuild test robot
2016-12-14 3:37 ` kbuild test robot
2016-12-14 0:11 ` [PATCH 05/12] mfd: flexcard: add DMA interrupts Holger Dengler
2016-12-14 3:08 ` kbuild test robot
2016-12-14 0:11 ` [PATCH 06/12] mfd: flexcard: add DMA device Holger Dengler
2016-12-14 0:11 ` [PATCH 07/12] mfd: flexcard: add UIO IRQ devices Holger Dengler
2016-12-14 0:11 ` [PATCH 08/12] misc: Flexcard misc device support Holger Dengler
2016-12-14 8:42 ` Arnd Bergmann
2016-12-14 9:28 ` Holger Dengler
2017-01-10 16:59 ` Greg Kroah-Hartman [this message]
2016-12-14 0:11 ` [PATCH 09/12] misc: flexcard: add device attributes Holger Dengler
2016-12-14 1:33 ` kbuild test robot
2017-01-10 16:58 ` Greg Kroah-Hartman
2016-12-14 0:11 ` [PATCH 10/12] misc: Flexcard basic timestamp counter support Holger Dengler
2016-12-14 3:28 ` kbuild test robot
2016-12-14 8:46 ` Arnd Bergmann
2016-12-14 9:16 ` Thomas Gleixner
2016-12-14 0:11 ` [PATCH 11/12] misc: flexcard: Support timestamp trigger selection Holger Dengler
2016-12-14 0:11 ` [PATCH 12/12] dma: Flexcard DMA ringbuffer demux driver Holger Dengler
2016-12-14 1:54 ` kbuild test robot
2016-12-15 4:38 ` Vinod Koul
2016-12-19 10:54 ` Holger Dengler
2017-01-04 9:43 ` [PATCH 00/12] Eberspaecher Flexcard PMC II base support Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110165918.GB19767@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=b.spranger@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=bubeck@xkrug.com \
--cc=dengler@linutronix.de \
--cc=dmaengine@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahler@xkrug.com \
--cc=tglx@linutronix.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).