* [PATCH] kthread:fix coding style issue
@ 2016-12-15 8:22 Gaosheng Wu
2016-12-15 17:14 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gaosheng Wu @ 2016-12-15 8:22 UTC (permalink / raw)
To: linux-kernel; +Cc: GaoShengWu
From: GaoShengWu <wugsh15@lzu.edu.cn>
Line 28 of kthread.c violates chapter 3 of CodingStyle - put the opening
brace last on the line, and put the closing brace first.
Signed-off-by: GaoShengWu <wugsh15@lzu.edu.cn>
---
checkpatch.pl complained as the following:
ERROR: open brace '{' following struct go on the same line
#28: FILE: kernel/kthread.c:28:
+struct kthread_create_info
+{
Patch was compile checked with: x86_64_defconfig
Patch is aginst:4.9.0 (localversion-next is next-20161213)
kernel/kthread.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/kthread.c b/kernel/kthread.c
index 2318fba..8888f89 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -24,8 +24,7 @@ static DEFINE_SPINLOCK(kthread_create_lock);
static LIST_HEAD(kthread_create_list);
struct task_struct *kthreadd_task;
-struct kthread_create_info
-{
+struct kthread_create_info {
/* Information passed to kthread() from kthreadd. */
int (*threadfn)(void *data);
void *data;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kthread:fix coding style issue
2016-12-15 8:22 [PATCH] kthread:fix coding style issue Gaosheng Wu
@ 2016-12-15 17:14 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-12-15 17:14 UTC (permalink / raw)
To: Gaosheng Wu; +Cc: linux-kernel
On Thu, Dec 15, 2016 at 04:22:53PM +0800, Gaosheng Wu wrote:
> From: GaoShengWu <wugsh15@lzu.edu.cn>
>
> Line 28 of kthread.c violates chapter 3 of CodingStyle - put the opening
> brace last on the line, and put the closing brace first.
>
> Signed-off-by: GaoShengWu <wugsh15@lzu.edu.cn>
Please do coding style fixes on drivers/staging/* first, so that you can
learn the proper process for doing this and not annoy the core kernel
developers with incorrect patches.
good luck!
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-15 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-15 8:22 [PATCH] kthread:fix coding style issue Gaosheng Wu
2016-12-15 17:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).