From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Irina Tirdea <irina.tirdea@intel.com>,
linux-clk@vger.kernel.org, "x86@kernel.org" <x86@kernel.org>,
platform-driver-x86@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86
Date: Fri, 16 Dec 2016 10:20:45 -0800 [thread overview]
Message-ID: <20161216182045.GA44199@f23x64.localdomain> (raw)
In-Reply-To: <CAHp75VfCgTgWnNmgcY9mp9n-1e_mSci=3dGyrtDquMtTT3OoYw@mail.gmail.com>
On Tue, Dec 13, 2016 at 01:43:31AM +0200, Andy Shevchenko wrote:
> I have been told I have to send my comments here instead of our
> internal ML. I didn't fast enough to comment that during v5. So do it
> right now.
>
> On Fri, Dec 9, 2016 at 8:01 PM, Irina Tirdea <irina.tirdea@intel.com> wrote:
> > The pmc_atom driver does not contain any architecture specific
> > code. It only enables the SOC Power Management Controller Driver
>
> SOC -> SoC
> Driver -> driver
>
> > for BayTrail and CherryTrail platforms.
> >
> > Move the pmc_atom driver from arch/x86/platform/atom to
> > drivers/platform/x86.
> >
> > Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> > ---
> > arch/x86/Kconfig | 4 ----
> > arch/x86/platform/atom/Makefile | 1 -
> > drivers/acpi/acpi_lpss.c | 2 +-
> > drivers/platform/x86/Kconfig | 4 ++++
> > drivers/platform/x86/Makefile | 1 +
> > {arch/x86/platform/atom => drivers/platform/x86}/pmc_atom.c | 3 +--
>
> > {arch/x86/include/asm => include/linux/platform_data/x86}/pmc_atom.h | 0
>
> No, it's not a *platform data*.
>
> Other that that looks good to me.
Where would you recommend instead? It needs a place to serve both acpi_lpss.c
and pmc_atom.c. The include/linux/platform_data/x86 location doesn't seem too
strange as it supports a "platform" driver in the sense that pmc_atom is a
platform driver.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-12-16 18:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 18:01 [PATCH v6 0/3] Add platform clock for BayTrail platforms Irina Tirdea
2016-12-09 18:01 ` [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks Irina Tirdea
2016-12-12 23:39 ` Andy Shevchenko
2016-12-13 0:15 ` Pierre-Louis Bossart
2016-12-13 0:26 ` Andy Shevchenko
2016-12-16 18:36 ` Darren Hart
2016-12-16 18:49 ` Andy Shevchenko
2016-12-16 19:19 ` Darren Hart
2016-12-16 22:29 ` Andy Shevchenko
2016-12-16 22:58 ` Darren Hart
2016-12-19 11:04 ` Mark Brown
2016-12-13 1:16 ` Andy Shevchenko
2016-12-13 23:25 ` Stephen Boyd
2016-12-16 5:15 ` [alsa-devel] " Pierre-Louis Bossart
2016-12-16 8:46 ` Andy Shevchenko
2016-12-16 14:57 ` Pierre-Louis Bossart
2016-12-17 1:33 ` Stephen Boyd
2016-12-17 13:57 ` Andy Shevchenko
2016-12-19 16:11 ` Pierre-Louis Bossart
2016-12-21 23:05 ` Stephen Boyd
2016-12-22 1:07 ` Pierre-Louis Bossart
2016-12-22 18:29 ` Stephen Boyd
2016-12-22 18:42 ` Andy Shevchenko
2017-01-05 0:54 ` Pierre-Louis Bossart
2016-12-09 18:01 ` [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Irina Tirdea
2016-12-12 23:43 ` Andy Shevchenko
2016-12-16 18:20 ` Darren Hart [this message]
2016-12-16 18:39 ` Andy Shevchenko
2016-12-09 18:01 ` [PATCH v6 3/3] platform/x86: Enable Atom PMC platform clocks Irina Tirdea
2016-12-13 0:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216182045.GA44199@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=hpa@zytor.com \
--cc=irina.tirdea@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).