From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Irina Tirdea <irina.tirdea@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"x86@kernel.org" <x86@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Takashi Iwai <tiwai@suse.com>,
platform-driver-x86@vger.kernel.org,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Mark Brown <broonie@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Darren Hart <dvhart@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>, Len Brown <lenb@kernel.org>,
linux-clk@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
Subject: Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks
Date: Fri, 16 Dec 2016 10:46:11 +0200 [thread overview]
Message-ID: <CAHp75Vf7Sfq3_mSb6xf0NHutq8tO1y7Rhi7opDkomu+-vQZCYw@mail.gmail.com> (raw)
In-Reply-To: <32235fb3-0d54-211d-28f4-4655e4bc7812@linux.intel.com>
On Fri, Dec 16, 2016 at 7:15 AM, Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
> Hi Stephen,
>
> can you elaborate on the last comment?
Please don't do top posting.
>>> devm_kasprintf()
>>
>> Please no.
That's why I used modal verb "might" instead of "would".
>> It's all local to this function, devm isn't helping anything.
>> Having one kfree() would be good though. And using init.name for
>> the clkdev lookup is probably wrong and should be replaced with
>> something more generic along with an associated device name.
>
> I am not sure I understand this last comment.
> init.name is not a constant, it's made of the "pmc_plt_clk_" string
> concatenated with an id which directly maps to which hardware clock is
> registered. Clients use devm_clk_get() with a "pmc_plt_clk_<n>" argument.
Giving more thoughts about design and use of this I would propose to
do the following.
1. Create under clock framework something like clk-pmc-atom clock
driver (see, for example, clk-fractional-divider, though this one
should indeed go under x86 folder).
2. In real provider, i.e. pmc_atom, create the necessary clock tree
with *names*.
Scheme with ID is fragile, imagine another version of PMC where
ordering would be mixed up? It's not hypothetical since we used to
have this already in pmc_atom for some registers and bits.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2016-12-16 8:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 18:01 [PATCH v6 0/3] Add platform clock for BayTrail platforms Irina Tirdea
2016-12-09 18:01 ` [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks Irina Tirdea
2016-12-12 23:39 ` Andy Shevchenko
2016-12-13 0:15 ` Pierre-Louis Bossart
2016-12-13 0:26 ` Andy Shevchenko
2016-12-16 18:36 ` Darren Hart
2016-12-16 18:49 ` Andy Shevchenko
2016-12-16 19:19 ` Darren Hart
2016-12-16 22:29 ` Andy Shevchenko
2016-12-16 22:58 ` Darren Hart
2016-12-19 11:04 ` Mark Brown
2016-12-13 1:16 ` Andy Shevchenko
2016-12-13 23:25 ` Stephen Boyd
2016-12-16 5:15 ` [alsa-devel] " Pierre-Louis Bossart
2016-12-16 8:46 ` Andy Shevchenko [this message]
2016-12-16 14:57 ` Pierre-Louis Bossart
2016-12-17 1:33 ` Stephen Boyd
2016-12-17 13:57 ` Andy Shevchenko
2016-12-19 16:11 ` Pierre-Louis Bossart
2016-12-21 23:05 ` Stephen Boyd
2016-12-22 1:07 ` Pierre-Louis Bossart
2016-12-22 18:29 ` Stephen Boyd
2016-12-22 18:42 ` Andy Shevchenko
2017-01-05 0:54 ` Pierre-Louis Bossart
2016-12-09 18:01 ` [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Irina Tirdea
2016-12-12 23:43 ` Andy Shevchenko
2016-12-16 18:20 ` Darren Hart
2016-12-16 18:39 ` Andy Shevchenko
2016-12-09 18:01 ` [PATCH v6 3/3] platform/x86: Enable Atom PMC platform clocks Irina Tirdea
2016-12-13 0:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf7Sfq3_mSb6xf0NHutq8tO1y7Rhi7opDkomu+-vQZCYw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=irina.tirdea@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).