From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Geliang Tang <geliangtang@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/blkback: use rb_entry()
Date: Tue, 20 Dec 2016 12:51:13 -0500 [thread overview]
Message-ID: <20161220175113.GB16671@char.us.oracle.com> (raw)
In-Reply-To: <20161220174406.uewt5mhniwtznran@dhcp-3-221.uk.xensource.com>
On Tue, Dec 20, 2016 at 05:44:06PM +0000, Roger Pau Monné wrote:
> On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote:
> > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote:
> > > To make the code clearer, use rb_entry() instead of container_of() to
> > > deal with rbtree.
> >
> > That is OK but I think 'container_of' is more clear.
> >
> > Roger, thoughts?
>
> I think so, container_of is a global macro that's widely used and everyone
> knows, rb_entry OTOH it's not and it's use doesn't really simply the code at
> all. I'm not really opposed, but it seems kind of a pointless change (not that
> it's wrong).
<nods> I concur.
Geliang Tang,
Thank you for the patch but there is no need for it.
Thanks again!
>
> Roger.
next prev parent reply other threads:[~2016-12-20 17:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 14:02 [PATCH] dm bufio: use rb_entry() Geliang Tang
2016-12-20 14:02 ` [PATCH] drm/nouveau/dma: " Geliang Tang
2016-12-21 23:22 ` [Nouveau] " Ben Skeggs
2016-12-20 14:02 ` [PATCH] IB/qib: " Geliang Tang
2016-12-20 14:21 ` Leon Romanovsky
2016-12-20 15:01 ` Dennis Dalessandro
2016-12-20 19:34 ` Marciniszyn, Mike
2017-01-12 17:09 ` Doug Ledford
2016-12-20 14:02 ` [PATCH] netfilter: xt_connlimit: " Geliang Tang
2017-01-05 12:26 ` Pablo Neira Ayuso
2016-12-20 14:02 ` [PATCH] net/mlx5: " Geliang Tang
2016-12-20 14:19 ` Leon Romanovsky
2016-12-20 19:23 ` David Miller
2016-12-20 14:02 ` [PATCH] net_sched: sch_fq: " Geliang Tang
2016-12-20 16:38 ` Eric Dumazet
2016-12-20 19:23 ` David Miller
2016-12-20 14:02 ` [PATCH] net_sched: sch_netem: " Geliang Tang
2016-12-20 19:23 ` David Miller
2016-12-20 14:02 ` [PATCH] powerpc/perf/24x7: use rb_entry Geliang Tang
2019-07-08 1:19 ` Michael Ellerman
2016-12-20 14:02 ` [PATCH] RDS: use rb_entry() Geliang Tang
2016-12-20 14:20 ` Leon Romanovsky
2016-12-20 16:34 ` Santosh Shilimkar
2016-12-20 19:23 ` David Miller
2016-12-22 3:33 ` Doug Ledford
2016-12-20 14:02 ` [PATCH] xen/blkback: " Geliang Tang
2016-12-20 16:47 ` Konrad Rzeszutek Wilk
2016-12-20 17:44 ` Roger Pau Monné
2016-12-20 17:51 ` Konrad Rzeszutek Wilk [this message]
2016-12-20 21:53 ` Eric Dumazet
2016-12-20 22:07 ` Konrad Rzeszutek Wilk
2016-12-20 14:02 ` [PATCH] xen/evtchn: " Geliang Tang
2016-12-20 16:20 ` Juergen Gross
2016-12-22 9:07 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220175113.GB16671@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=geliangtang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).