From: Ben Skeggs <skeggsb@gmail.com>
To: Geliang Tang <geliangtang@gmail.com>,
Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH] drm/nouveau/dma: use rb_entry()
Date: Thu, 22 Dec 2016 09:22:14 +1000 [thread overview]
Message-ID: <f5c3fb4b-ba2a-daab-9654-57ca4c35ca49@gmail.com> (raw)
In-Reply-To: <5a188bc5a22daa80cf7a43dc75003b31f9e3abcd.1482203355.git.geliangtang@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1361 bytes --]
On 12/21/2016 12:02 AM, Geliang Tang wrote:
> To make the code clearer, use rb_entry() instead of container_of() to
> deal with rbtree.
Thanks, I've grabbed the patch.
Ben.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/dma/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/dma/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/dma/base.c
> index f11ebdd..4655d17 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/dma/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/dma/base.c
> @@ -34,7 +34,7 @@ nvkm_dma_search(struct nvkm_dma *dma, struct nvkm_client *client, u64 object)
> struct rb_node *node = client->dmaroot.rb_node;
> while (node) {
> struct nvkm_dmaobj *dmaobj =
> - container_of(node, typeof(*dmaobj), rb);
> + rb_entry(node, typeof(*dmaobj), rb);
> if (object < dmaobj->handle)
> node = node->rb_left;
> else
> @@ -67,7 +67,7 @@ nvkm_dma_oclass_new(struct nvkm_device *device,
> dmaobj->handle = oclass->object;
>
> while (*ptr) {
> - struct nvkm_dmaobj *obj = container_of(*ptr, typeof(*obj), rb);
> + struct nvkm_dmaobj *obj = rb_entry(*ptr, typeof(*obj), rb);
> parent = *ptr;
> if (dmaobj->handle < obj->handle)
> ptr = &parent->rb_left;
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2016-12-21 23:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 14:02 [PATCH] dm bufio: use rb_entry() Geliang Tang
2016-12-20 14:02 ` [PATCH] drm/nouveau/dma: " Geliang Tang
2016-12-21 23:22 ` Ben Skeggs [this message]
2016-12-20 14:02 ` [PATCH] IB/qib: " Geliang Tang
2016-12-20 14:21 ` Leon Romanovsky
2016-12-20 15:01 ` Dennis Dalessandro
2016-12-20 19:34 ` Marciniszyn, Mike
2017-01-12 17:09 ` Doug Ledford
2016-12-20 14:02 ` [PATCH] netfilter: xt_connlimit: " Geliang Tang
2017-01-05 12:26 ` Pablo Neira Ayuso
2016-12-20 14:02 ` [PATCH] net/mlx5: " Geliang Tang
2016-12-20 14:19 ` Leon Romanovsky
2016-12-20 19:23 ` David Miller
2016-12-20 14:02 ` [PATCH] net_sched: sch_fq: " Geliang Tang
2016-12-20 16:38 ` Eric Dumazet
2016-12-20 19:23 ` David Miller
2016-12-20 14:02 ` [PATCH] net_sched: sch_netem: " Geliang Tang
2016-12-20 19:23 ` David Miller
2016-12-20 14:02 ` [PATCH] powerpc/perf/24x7: use rb_entry Geliang Tang
2019-07-08 1:19 ` Michael Ellerman
2016-12-20 14:02 ` [PATCH] RDS: use rb_entry() Geliang Tang
2016-12-20 14:20 ` Leon Romanovsky
2016-12-20 16:34 ` Santosh Shilimkar
2016-12-20 19:23 ` David Miller
2016-12-22 3:33 ` Doug Ledford
2016-12-20 14:02 ` [PATCH] xen/blkback: " Geliang Tang
2016-12-20 16:47 ` Konrad Rzeszutek Wilk
2016-12-20 17:44 ` Roger Pau Monné
2016-12-20 17:51 ` Konrad Rzeszutek Wilk
2016-12-20 21:53 ` Eric Dumazet
2016-12-20 22:07 ` Konrad Rzeszutek Wilk
2016-12-20 14:02 ` [PATCH] xen/evtchn: " Geliang Tang
2016-12-20 16:20 ` Juergen Gross
2016-12-22 9:07 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5c3fb4b-ba2a-daab-9654-57ca4c35ca49@gmail.com \
--to=skeggsb@gmail.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geliangtang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).