From: Greg KH <greg@kroah.com>
To: greg@enjellic.com
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org,
xen-users@lists.xen.org, stable@vger.kernel.org,
dgdegra@tycho.nsa.gov
Subject: Re: [PATCH] tpm: Restore functionality to xen vtpm driver.
Date: Fri, 23 Dec 2016 08:17:48 +0100 [thread overview]
Message-ID: <20161223071748.GA23493@kroah.com> (raw)
In-Reply-To: <201612222041.uBMKfqKC018662@wind.enjellic.com>
On Thu, Dec 22, 2016 at 02:41:52PM -0600, Dr. Greg Wettstein wrote:
> Functionality of the xen-tpmfront driver was lost secondary to
> the introduction of xenbus multi-page support in the following
> commit:
>
> ccc9d90a9a8b5c4ad7e9708ec41f75ff9e98d61d
>
> xenbus_client: Extend interface to support multi-page ring
>
> In this commit a pointer to the shared page address was being
> passed to the xenbus_grant_ring() function rather then the
> address of the shared page itself. This resulted in a situation
> where the driver would attach to the vtpm-stubdom but any attempt
> to send a command to the stub domain would timeout.
>
> A diagnostic finding for this regression is the following error
> message being generated when the xen-tpmfront driver probes for a
> device:
>
> <3>vtpm vtpm-0: tpm_transmit: tpm_send: error -62
>
> <3>vtpm vtpm-0: A TPM error (-62) occurred attempting to determine the timeouts
>
> This fix is relevant to all kernels from 4.1 forward which is the
> release in which multi-page xenbus support was introduced.
>
> Daniel De Graaf formulated the fix by code inspection after the
> regression point was located.
>
> Signed-off-by: Dr. Greg Wettstein <greg@enjellic.com>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2016-12-23 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 20:41 [PATCH] tpm: Restore functionality to xen vtpm driver Dr. Greg Wettstein
2016-12-23 7:17 ` Greg KH [this message]
2017-01-10 15:39 ` [Xen-devel] " Boris Ostrovsky
2017-01-20 15:00 Dr. Greg Wettstein
2017-01-20 22:22 ` Boris Ostrovsky
2017-01-21 0:29 Dr. Greg Wettstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223071748.GA23493@kroah.com \
--to=greg@kroah.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=greg@enjellic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
--cc=xen-users@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).