From: Dave Jones <davej@codemonkey.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Guenter Roeck <linux@roeck-us.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: hwmon: (coretemp) Simplify package management
Date: Wed, 28 Dec 2016 16:55:14 -0500 [thread overview]
Message-ID: <20161228215514.cuqhp5kkgepombag@codemonkey.org.uk> (raw)
In-Reply-To: <20161214005838.1F41F66102A@gitolite.kernel.org>
On Wed, Dec 14, 2016 at 12:58:38AM +0000, Linux Kernel wrote:
> Web: https://git.kernel.org/torvalds/c/712668460594294d74c13f2a023398a597fbe95f
> Commit: 712668460594294d74c13f2a023398a597fbe95f
> Parent: 2195c31b127def509c806fe8a9d3b4092a28ce31
> Refname: refs/heads/master
> Author: Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Tue Nov 22 17:42:06 2016 +0000
> Committer: Guenter Roeck <linux@roeck-us.net>
> CommitDate: Fri Dec 9 21:54:13 2016 -0800
>
> hwmon: (coretemp) Simplify package management
>
> Keeping track of the per package platform devices requires an extra object,
> which is held in a linked list.
>
> The maximum number of packages is known at init() time. So the extra object
> and linked list management can be replaced by an array of platform device
> pointers in which the per package devices pointers can be stored. Lookup
> becomes a simple array lookup instead of a list walk.
>
> The mutex protecting the list can be removed as well because the array is
> only accessed from cpu hotplug callbacks which are already serialized.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 1 file changed, 38 insertions(+), 82 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index c364bfd..3ac4c03 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -127,7 +122,7 @@ static ssize_t show_label(struct device *dev,
> struct temp_data *tdata = pdata->core_data[attr->index];
>
> if (tdata->is_pkg_data)
> - return sprintf(buf, "Physical id %u\n", pdata->phys_proc_id);
> + return sprintf(buf, "Package id %u\n", pdata->pkg_id);
>
> return sprintf(buf, "Core %u\n", tdata->cpu_core_id);
> }
This is breakage of a userspace ABI.
Fixing up my mrtg config to cope was simple enough, but do we want to
force everyone to have to do that if they upgrade their kernel ?
Dave
parent reply other threads:[~2016-12-28 22:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20161214005838.1F41F66102A@gitolite.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161228215514.cuqhp5kkgepombag@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).