* [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline
@ 2016-11-27 19:54 Andreas Färber
2016-11-27 21:17 ` Andrew Lunn
2016-12-30 7:10 ` Shawn Guo
0 siblings, 2 replies; 6+ messages in thread
From: Andreas Färber @ 2016-11-27 19:54 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Andreas Färber, Andrew Lunn, David S . Miller, Shawn Guo,
Sascha Hauer, Stefan Agner, Rob Herring, Mark Rutland,
Russell King, devicetree, linux-kernel
Found while reviewing Marvell dsa bindings usage.
Fixes: f283745b3caf ("arm: vf610: zii devel b: Add support for switch interrupts")
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
index 7ea617e47fe4..958b4c42d320 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
@@ -153,7 +153,8 @@
switch0phy1: switch1phy0@1 {
reg = <1>;
interrupt-parent = <&switch0>;
- interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; };
+ interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
+ };
switch0phy2: switch1phy0@2 {
reg = <2>;
interrupt-parent = <&switch0>;
--
2.6.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline
2016-11-27 19:54 [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline Andreas Färber
@ 2016-11-27 21:17 ` Andrew Lunn
2016-11-27 21:30 ` Andreas Färber
2016-12-30 7:10 ` Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2016-11-27 21:17 UTC (permalink / raw)
To: Andreas Färber
Cc: linux-arm-kernel, David S . Miller, Shawn Guo, Sascha Hauer,
Stefan Agner, Rob Herring, Mark Rutland, Russell King,
devicetree, linux-kernel
On Sun, Nov 27, 2016 at 08:54:44PM +0100, Andreas Färber wrote:
> Found while reviewing Marvell dsa bindings usage.
Hi Andreas
It is good practice to put the maintainer you expect to accept the
patch on the To: line. You have at least two different maintainers on
Cc: so it is currently ambiguous. And these lists can be high volume,
so without a copy in the maintainers inbox, patches can be overlooked.
> Fixes: f283745b3caf ("arm: vf610: zii devel b: Add support for switch interrupts")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> index 7ea617e47fe4..958b4c42d320 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> @@ -153,7 +153,8 @@
> switch0phy1: switch1phy0@1 {
> reg = <1>;
> interrupt-parent = <&switch0>;
> - interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; };
> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> + };
> switch0phy2: switch1phy0@2 {
> reg = <2>;
> interrupt-parent = <&switch0>;
> --
> 2.6.6
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline
2016-11-27 21:17 ` Andrew Lunn
@ 2016-11-27 21:30 ` Andreas Färber
2016-11-27 21:35 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Färber @ 2016-11-27 21:30 UTC (permalink / raw)
To: Andrew Lunn, Shawn Guo
Cc: linux-arm-kernel, David S . Miller, Sascha Hauer, Stefan Agner,
Rob Herring, Mark Rutland, Russell King, devicetree,
linux-kernel
Hi,
Am 27.11.2016 um 22:17 schrieb Andrew Lunn:
> On Sun, Nov 27, 2016 at 08:54:44PM +0100, Andreas Färber wrote:
>> Found while reviewing Marvell dsa bindings usage.
>
> Hi Andreas
>
> It is good practice to put the maintainer you expect to accept the
> patch on the To: line. You have at least two different maintainers on
> Cc: so it is currently ambiguous. And these lists can be high volume,
> so without a copy in the maintainers inbox, patches can be overlooked.
As a vf610 DT patch with LAKML in To I am expecting it to be handled by
Shawn or anyone from the NXP/ARM side.
>> Fixes: f283745b3caf ("arm: vf610: zii devel b: Add support for switch interrupts")
>> Cc: Andrew Lunn <andrew@lunn.ch>
>> Cc: David S. Miller <davem@davemloft.net>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline
2016-11-27 21:30 ` Andreas Färber
@ 2016-11-27 21:35 ` Andrew Lunn
2016-12-30 7:07 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2016-11-27 21:35 UTC (permalink / raw)
To: Andreas Färber
Cc: Shawn Guo, linux-arm-kernel, David S . Miller, Sascha Hauer,
Stefan Agner, Rob Herring, Mark Rutland, Russell King,
devicetree, linux-kernel
On Sun, Nov 27, 2016 at 10:30:54PM +0100, Andreas Färber wrote:
> Hi,
>
> Am 27.11.2016 um 22:17 schrieb Andrew Lunn:
> > On Sun, Nov 27, 2016 at 08:54:44PM +0100, Andreas Färber wrote:
> >> Found while reviewing Marvell dsa bindings usage.
> >
> > Hi Andreas
> >
> > It is good practice to put the maintainer you expect to accept the
> > patch on the To: line. You have at least two different maintainers on
> > Cc: so it is currently ambiguous. And these lists can be high volume,
> > so without a copy in the maintainers inbox, patches can be overlooked.
>
> As a vf610 DT patch with LAKML in To I am expecting it to be handled by
> Shawn or anyone from the NXP/ARM side.
So please have Shawn as To:
The patch you are fixing went through Dave Miller, who is also on Cc:,
hence the ambiguity.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline
2016-11-27 21:35 ` Andrew Lunn
@ 2016-12-30 7:07 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2016-12-30 7:07 UTC (permalink / raw)
To: Andrew Lunn
Cc: Andreas Färber, linux-arm-kernel, David S . Miller,
Sascha Hauer, Stefan Agner, Rob Herring, Mark Rutland,
Russell King, devicetree, linux-kernel
On Sun, Nov 27, 2016 at 10:35:16PM +0100, Andrew Lunn wrote:
> On Sun, Nov 27, 2016 at 10:30:54PM +0100, Andreas Färber wrote:
> > Hi,
> >
> > Am 27.11.2016 um 22:17 schrieb Andrew Lunn:
> > > On Sun, Nov 27, 2016 at 08:54:44PM +0100, Andreas Färber wrote:
> > >> Found while reviewing Marvell dsa bindings usage.
> > >
> > > Hi Andreas
> > >
> > > It is good practice to put the maintainer you expect to accept the
> > > patch on the To: line. You have at least two different maintainers on
> > > Cc: so it is currently ambiguous. And these lists can be high volume,
> > > so without a copy in the maintainers inbox, patches can be overlooked.
> >
> > As a vf610 DT patch with LAKML in To I am expecting it to be handled by
> > Shawn or anyone from the NXP/ARM side.
>
> So please have Shawn as To:
>
> The patch you are fixing went through Dave Miller, who is also on Cc:,
> hence the ambiguity.
The good practice was broken from the beginning when patch "arm: vf610:
zii devel b: Add support for switch interrupts") went through net tree,
even without me on copy.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline
2016-11-27 19:54 [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline Andreas Färber
2016-11-27 21:17 ` Andrew Lunn
@ 2016-12-30 7:10 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2016-12-30 7:10 UTC (permalink / raw)
To: Andreas Färber
Cc: linux-arm-kernel, Andrew Lunn, David S . Miller, Sascha Hauer,
Stefan Agner, Rob Herring, Mark Rutland, Russell King,
devicetree, linux-kernel
On Sun, Nov 27, 2016 at 08:54:44PM +0100, Andreas Färber wrote:
> Found while reviewing Marvell dsa bindings usage.
>
> Fixes: f283745b3caf ("arm: vf610: zii devel b: Add support for switch interrupts")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-12-30 7:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-27 19:54 [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline Andreas Färber
2016-11-27 21:17 ` Andrew Lunn
2016-11-27 21:30 ` Andreas Färber
2016-11-27 21:35 ` Andrew Lunn
2016-12-30 7:07 ` Shawn Guo
2016-12-30 7:10 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).