* [PATCH] auxdisplay: fix new ht16k33 build errors
@ 2016-12-26 17:58 Randy Dunlap
2017-01-02 7:45 ` Robin van der Gracht
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2016-12-26 17:58 UTC (permalink / raw)
To: LKML, Greg Kroah-Hartman, Fengguang Wu
Cc: Robin van der Gracht, Miguel Ojeda Sandonis
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors caused by selecting incorrect kconfig symbols.
drivers/built-in.o:(.data+0x19cec): undefined reference to `sys_fillrect'
drivers/built-in.o:(.data+0x19cf0): undefined reference to `sys_copyarea'
drivers/built-in.o:(.data+0x19cf4): undefined reference to `sys_imageblit'
Fixes: 31114fa95bdb (auxdisplay: ht16k33: select framebuffer helper modules)
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Robin van der Gracht <robin@protonic.nl>
Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
---
drivers/auxdisplay/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- lnx-410-rc1.orig/drivers/auxdisplay/Kconfig
+++ lnx-410-rc1/drivers/auxdisplay/Kconfig
@@ -132,9 +132,9 @@ config HT16K33
tristate "Holtek Ht16K33 LED controller with keyscan"
depends on FB && OF && I2C && INPUT
select FB_SYS_FOPS
- select FB_CFB_FILLRECT
- select FB_CFB_COPYAREA
- select FB_CFB_IMAGEBLIT
+ select FB_SYS_FILLRECT
+ select FB_SYS_COPYAREA
+ select FB_SYS_IMAGEBLIT
select INPUT_MATRIXKMAP
select FB_BACKLIGHT
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] auxdisplay: fix new ht16k33 build errors
2016-12-26 17:58 [PATCH] auxdisplay: fix new ht16k33 build errors Randy Dunlap
@ 2017-01-02 7:45 ` Robin van der Gracht
0 siblings, 0 replies; 2+ messages in thread
From: Robin van der Gracht @ 2017-01-02 7:45 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Greg Kroah-Hartman, Fengguang Wu, Miguel Ojeda Sandonis
On Mon, 26 Dec 2016 09:58:34 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors caused by selecting incorrect kconfig symbols.
>
> drivers/built-in.o:(.data+0x19cec): undefined reference to `sys_fillrect'
> drivers/built-in.o:(.data+0x19cf0): undefined reference to `sys_copyarea'
> drivers/built-in.o:(.data+0x19cf4): undefined reference to `sys_imageblit'
>
> Fixes: 31114fa95bdb (auxdisplay: ht16k33: select framebuffer helper modules)
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Robin van der Gracht <robin@protonic.nl>
> Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> ---
> drivers/auxdisplay/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-410-rc1.orig/drivers/auxdisplay/Kconfig
> +++ lnx-410-rc1/drivers/auxdisplay/Kconfig
> @@ -132,9 +132,9 @@ config HT16K33
> tristate "Holtek Ht16K33 LED controller with keyscan"
> depends on FB && OF && I2C && INPUT
> select FB_SYS_FOPS
> - select FB_CFB_FILLRECT
> - select FB_CFB_COPYAREA
> - select FB_CFB_IMAGEBLIT
> + select FB_SYS_FILLRECT
> + select FB_SYS_COPYAREA
> + select FB_SYS_IMAGEBLIT
> select INPUT_MATRIXKMAP
> select FB_BACKLIGHT
> help
Acked-by: Robin van der Gracht <robin@protonic.nl>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-02 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-26 17:58 [PATCH] auxdisplay: fix new ht16k33 build errors Randy Dunlap
2017-01-02 7:45 ` Robin van der Gracht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).