From: Petr Mladek <pmladek@suse.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jessica Yu <jeyu@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] taint/module: Fix problems when out-of-kernel driver defines true or false
Date: Mon, 2 Jan 2017 11:51:43 +0100 [thread overview]
Message-ID: <20170102105142.GE14894@pathway.suse.cz> (raw)
In-Reply-To: <20170102022525.29661-1-Larry.Finger@lwfinger.net>
On Sun 2017-01-01 20:25:25, Larry Finger wrote:
> Commit 7fd8329ba502 ("taint/module: Clean up global and module taint
> flags handling") used the key words true and false as character members
> of a new struct. These names cause problems when out-of-kernel modules
> such as VirtualBox include their own definitions of true and false.
>
> Fixes: 7fd8329ba502 ("taint/module: Clean up global and module taint flags handling")
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Petr Mladek <pmladek@suse.com>
> Cc: Jessica Yu <jeyu@redhat.com>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
I like this variant a bit more than the tainted/untainted one.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2017-01-02 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 2:25 [PATCH] taint/module: Fix problems when out-of-kernel driver defines true or false Larry Finger
2017-01-02 5:50 ` Christoph Hellwig
2017-01-02 10:51 ` Petr Mladek [this message]
2017-01-04 3:08 ` Jessica Yu
[not found] ` <CAP71bdULb5BReYmouqE7CLX3uS=3EdD0t46Wp_uGAFD+hxRRYA@mail.gmail.com>
2017-01-17 17:55 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102105142.GE14894@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=Larry.Finger@lwfinger.net \
--cc=jeyu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).