* [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM
@ 2017-01-02 2:58 Randy Dunlap
2017-01-02 8:33 ` Neil Armstrong
2017-01-03 8:20 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2017-01-02 2:58 UTC (permalink / raw)
To: LKML, linux-mtd
Cc: kbuild test robot, Boris Brezillon, Neil Armstrong, Jeff Dike,
Richard Weinberger, user-mode-linux-devel
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors on arch/um, which does not support HAS_IOMEM,
while the oxnas_nand.c driver uses interfaces that are
supplied by HAS_IOMEM.
(loadable module build:)
ERROR: "devm_ioremap_resource" [drivers/mtd/nand/oxnas_nand.ko] undefined!
or (built-in build:)
drivers/built-in.o: In function `oxnas_nand_probe':
drivers/mtd/nand/oxnas_nand.c:102: undefined reference to `devm_ioremap_resource'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/nand/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- lnx-410-rc2.orig/drivers/mtd/nand/Kconfig
+++ lnx-410-rc2/drivers/mtd/nand/Kconfig
@@ -426,6 +426,7 @@ config MTD_NAND_ORION
config MTD_NAND_OXNAS
tristate "NAND Flash support for Oxford Semiconductor SoC"
+ depends on HAS_IOMEM
help
This enables the NAND flash controller on Oxford Semiconductor SoCs.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM
2017-01-02 2:58 [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM Randy Dunlap
@ 2017-01-02 8:33 ` Neil Armstrong
2017-01-03 8:20 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2017-01-02 8:33 UTC (permalink / raw)
To: Randy Dunlap, LKML, linux-mtd
Cc: kbuild test robot, Boris Brezillon, Jeff Dike,
Richard Weinberger, user-mode-linux-devel
On 01/02/2017 03:58 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors on arch/um, which does not support HAS_IOMEM,
> while the oxnas_nand.c driver uses interfaces that are
> supplied by HAS_IOMEM.
>
> (loadable module build:)
> ERROR: "devm_ioremap_resource" [drivers/mtd/nand/oxnas_nand.ko] undefined!
> or (built-in build:)
> drivers/built-in.o: In function `oxnas_nand_probe':
> drivers/mtd/nand/oxnas_nand.c:102: undefined reference to `devm_ioremap_resource'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Cc: linux-mtd@lists.infradead.org
> ---
> drivers/mtd/nand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-410-rc2.orig/drivers/mtd/nand/Kconfig
> +++ lnx-410-rc2/drivers/mtd/nand/Kconfig
> @@ -426,6 +426,7 @@ config MTD_NAND_ORION
>
> config MTD_NAND_OXNAS
> tristate "NAND Flash support for Oxford Semiconductor SoC"
> + depends on HAS_IOMEM
> help
> This enables the NAND flash controller on Oxford Semiconductor SoCs.
>
>
Thanks Randy,
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM
2017-01-02 2:58 [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM Randy Dunlap
2017-01-02 8:33 ` Neil Armstrong
@ 2017-01-03 8:20 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-01-03 8:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, linux-mtd, kbuild test robot, Neil Armstrong, Jeff Dike,
Richard Weinberger, user-mode-linux-devel
On Sun, 1 Jan 2017 18:58:27 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors on arch/um, which does not support HAS_IOMEM,
> while the oxnas_nand.c driver uses interfaces that are
> supplied by HAS_IOMEM.
>
> (loadable module build:)
> ERROR: "devm_ioremap_resource" [drivers/mtd/nand/oxnas_nand.ko] undefined!
> or (built-in build:)
> drivers/built-in.o: In function `oxnas_nand_probe':
> drivers/mtd/nand/oxnas_nand.c:102: undefined reference to `devm_ioremap_resource'
Applied to nand/fixes. It should appear in one of the next -rc
(probably not -rc3 though).
Thanks,
Boris
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Cc: linux-mtd@lists.infradead.org
> ---
> drivers/mtd/nand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-410-rc2.orig/drivers/mtd/nand/Kconfig
> +++ lnx-410-rc2/drivers/mtd/nand/Kconfig
> @@ -426,6 +426,7 @@ config MTD_NAND_ORION
>
> config MTD_NAND_OXNAS
> tristate "NAND Flash support for Oxford Semiconductor SoC"
> + depends on HAS_IOMEM
> help
> This enables the NAND flash controller on Oxford Semiconductor SoCs.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-03 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-02 2:58 [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM Randy Dunlap
2017-01-02 8:33 ` Neil Armstrong
2017-01-03 8:20 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).