From: Greg KH <gregkh@linuxfoundation.org>
To: Ozgur Karatas <okaratas@member.fsf.org>
Cc: Scott Matheina <scott@matheina.com>,
"thomas.petazzoni@free-electrons.com"
<thomas.petazzoni@free-electrons.com>,
"noralf@tronnes.org" <noralf@tronnes.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay
Date: Tue, 3 Jan 2017 16:26:23 +0100 [thread overview]
Message-ID: <20170103152623.GA26457@kroah.com> (raw)
In-Reply-To: <83861482169482@web2o.yandex.ru>
On Mon, Dec 19, 2016 at 07:44:42PM +0200, Ozgur Karatas wrote:
> 19.12.2016, 08:35, "Greg KH" <gregkh@linuxfoundation.org>:
> > On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote:
> >> These changes where identified by checkpatch.pl as needed changes to
> >> align the code with the linux development coding style. The several
> >> lines of text where aligned with the precending parenthesis.
> >>
> >> Signed-off-by: Scott Matheina <scott@matheina.com>
> >>
> >> Changes to be committed:
> >> modified: drivers/staging/fbtft/fb_agm1264k-fl.c
> >
> > Why are these lines in the changelog text?
>
> I checked with checkpatch script to code and give a some errors.
> So, the code have to "udelay(20)".
>
> udelay(20);
>
> I read to Documentation/timers/timers-howto.txt and
> this line incorrect, usleep_range need must be add defined U_DELAY and fixed.
>
> udelay(U_DELAY, U_DELAY + 10);
>
> finally:
>
> $ checkpatch.pl drivers/staging/fbtft/fb_agm1264k-fl.c | grep total
> total: 0 errors
>
> Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
>
> ---
> drivers/staging/fbtft/fb_agm1264k-fl.c | 31 ++++++++++++-------------------
> 1 file changed, 12 insertions(+), 19 deletions(-)
You do realize there's nothing I can do with this patch as-is, right?
Please fix up the changelog text and resend it properly if you wish to
have it included.
thanks,
greg k-h
next prev parent reply other threads:[~2017-01-03 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 17:47 [PATCH v2] fix code alignment with open parenthesis Scott Matheina
2016-12-19 6:35 ` Greg KH
2016-12-19 17:44 ` [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay Ozgur Karatas
2017-01-03 15:26 ` Greg KH [this message]
2016-12-20 0:29 ` [PATCH v2] fix code alignment with open parenthesis Scott Matheina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103152623.GA26457@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=okaratas@member.fsf.org \
--cc=scott@matheina.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).