* [PATCH] USB: ohci-omap: defer probe if PHY is missing
@ 2017-01-02 20:53 Aaro Koskinen
2017-01-03 16:51 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Aaro Koskinen @ 2017-01-02 20:53 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, Felipe Balbi, linux-usb,
linux-omap, linux-kernel
Cc: Aaro Koskinen
Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
to be loaded to get the PHY going and ohci-omap should wait for those.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/usb/host/ohci-omap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
index 495c145..fe6f6b5 100644
--- a/drivers/usb/host/ohci-omap.c
+++ b/drivers/usb/host/ohci-omap.c
@@ -230,8 +230,7 @@ static int ohci_omap_reset(struct usb_hcd *hcd)
return status;
}
} else {
- dev_err(hcd->self.controller, "can't find phy\n");
- return -ENODEV;
+ return -EPROBE_DEFER;
}
ohci->start_hnp = start_hnp;
}
--
2.9.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing
2017-01-02 20:53 [PATCH] USB: ohci-omap: defer probe if PHY is missing Aaro Koskinen
@ 2017-01-03 16:51 ` Greg Kroah-Hartman
2017-01-03 18:50 ` Aaro Koskinen
0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2017-01-03 16:51 UTC (permalink / raw)
To: Aaro Koskinen
Cc: Alan Stern, Felipe Balbi, linux-usb, linux-omap, linux-kernel
On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote:
> Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
> to be loaded to get the PHY going and ohci-omap should wait for those.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Is this a new bug? The 770 has been around for forever, why has this
not been a problem before now?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing
2017-01-03 16:51 ` Greg Kroah-Hartman
@ 2017-01-03 18:50 ` Aaro Koskinen
2017-01-03 19:05 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Aaro Koskinen @ 2017-01-03 18:50 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alan Stern, Felipe Balbi, linux-usb, linux-omap, linux-kernel
Hi,
On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote:
> > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
> > to be loaded to get the PHY going and ohci-omap should wait for those.
> >
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>
> Is this a new bug? The 770 has been around for forever, why has this
> not been a problem before now?
PHY/OTG support for 770 has been around only since v3.14. I was previously
compiling phy-tahvo as built-in, and bumped into this issue when compiling
it as a module.
A.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing
2017-01-03 18:50 ` Aaro Koskinen
@ 2017-01-03 19:05 ` Greg Kroah-Hartman
2017-01-03 19:11 ` Felipe Balbi
2017-01-03 20:12 ` Aaro Koskinen
0 siblings, 2 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2017-01-03 19:05 UTC (permalink / raw)
To: Aaro Koskinen
Cc: Alan Stern, Felipe Balbi, linux-usb, linux-omap, linux-kernel
On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote:
> > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
> > > to be loaded to get the PHY going and ohci-omap should wait for those.
> > >
> > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> >
> > Is this a new bug? The 770 has been around for forever, why has this
> > not been a problem before now?
>
> PHY/OTG support for 770 has been around only since v3.14.
3.14 was released March, 2014. A long time ago in kernel development :)
> I was previously compiling phy-tahvo as built-in, and bumped into this
> issue when compiling it as a module.
Why not just make the defconfig as built-in?
I'm not objecting to this patch, just really curious why no one else has
ever hit it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing
2017-01-03 19:05 ` Greg Kroah-Hartman
@ 2017-01-03 19:11 ` Felipe Balbi
2017-01-03 20:12 ` Aaro Koskinen
1 sibling, 0 replies; 7+ messages in thread
From: Felipe Balbi @ 2017-01-03 19:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, Aaro Koskinen
Cc: Alan Stern, linux-usb, linux-omap, linux-kernel
Hi,
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote:
>> Hi,
>>
>> On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote:
>> > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote:
>> > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
>> > > to be loaded to get the PHY going and ohci-omap should wait for those.
>> > >
>> > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>> >
>> > Is this a new bug? The 770 has been around for forever, why has this
>> > not been a problem before now?
>>
>> PHY/OTG support for 770 has been around only since v3.14.
>
> 3.14 was released March, 2014. A long time ago in kernel development :)
>
>> I was previously compiling phy-tahvo as built-in, and bumped into this
>> issue when compiling it as a module.
>
> Why not just make the defconfig as built-in?
>
> I'm not objecting to this patch, just really curious why no one else has
> ever hit it.
Aaro is likely to be the last active OMAP1 user (let alone hacker)
around. This is probably just a reflection of that fact. No-one else was
using N770 with upstream (at least with USB in mind) :-)
--
balbi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing
2017-01-03 19:05 ` Greg Kroah-Hartman
2017-01-03 19:11 ` Felipe Balbi
@ 2017-01-03 20:12 ` Aaro Koskinen
2017-01-04 17:41 ` Tony Lindgren
1 sibling, 1 reply; 7+ messages in thread
From: Aaro Koskinen @ 2017-01-03 20:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alan Stern, Felipe Balbi, linux-usb, linux-omap, linux-kernel
Hi,
On Tue, Jan 03, 2017 at 08:05:04PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote:
> > On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote:
> > > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
> > > > to be loaded to get the PHY going and ohci-omap should wait for those.
> > > >
> > > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > >
> > > Is this a new bug? The 770 has been around for forever, why has this
> > > not been a problem before now?
> >
> > PHY/OTG support for 770 has been around only since v3.14.
>
> 3.14 was released March, 2014. A long time ago in kernel development :)
>
> > I was previously compiling phy-tahvo as built-in, and bumped into this
> > issue when compiling it as a module.
>
> Why not just make the defconfig as built-in?
I have reverted back to using built-in in my .config.
> I'm not objecting to this patch, just really curious why no one else has
> ever hit it.
Maybe I'm the only user...
The only other board using OHCI OMAP with PHY driver is H2/H3, and they
have solved the issue making USB_OHCI_HCD_OMAP1 depend on the PHY driver:
depends on ISP1301_OMAP || !(MACH_OMAP_H2 || MACH_OMAP_H3)
This way modprobe will handle the loading order automatically.
BTW, I just realized the same issue is with omap_udc. So I guess this patch
should be just dropped, or resent so that both drivers are fixed.
A.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing
2017-01-03 20:12 ` Aaro Koskinen
@ 2017-01-04 17:41 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2017-01-04 17:41 UTC (permalink / raw)
To: Aaro Koskinen
Cc: Greg Kroah-Hartman, Alan Stern, Felipe Balbi, linux-usb,
linux-omap, linux-kernel
* Aaro Koskinen <aaro.koskinen@iki.fi> [170103 12:13]:
> On Tue, Jan 03, 2017 at 08:05:04PM +0100, Greg Kroah-Hartman wrote:
> > I'm not objecting to this patch, just really curious why no one else has
> > ever hit it.
>
> Maybe I'm the only user...
I still have 770 in my test rack :) I don't boot it much though as
it needs a smaller kernel than what I typically build..
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-04 18:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-02 20:53 [PATCH] USB: ohci-omap: defer probe if PHY is missing Aaro Koskinen
2017-01-03 16:51 ` Greg Kroah-Hartman
2017-01-03 18:50 ` Aaro Koskinen
2017-01-03 19:05 ` Greg Kroah-Hartman
2017-01-03 19:11 ` Felipe Balbi
2017-01-03 20:12 ` Aaro Koskinen
2017-01-04 17:41 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).