* [PATCH] drivers/virt: use get_user_pages_unlocked()
@ 2016-11-01 19:43 Lorenzo Stoakes
2017-01-03 21:14 ` Lorenzo Stoakes
0 siblings, 1 reply; 4+ messages in thread
From: Lorenzo Stoakes @ 2016-11-01 19:43 UTC (permalink / raw)
To: linux-mm
Cc: linux-kernel, Paolo Bonzini, Michal Hocko, Timur Tabi,
Kumar Gala, Lorenzo Stoakes
Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code
and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.
Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
---
drivers/virt/fsl_hypervisor.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
index 150ce2a..d3eca87 100644
--- a/drivers/virt/fsl_hypervisor.c
+++ b/drivers/virt/fsl_hypervisor.c
@@ -243,11 +243,8 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p)
sg_list = PTR_ALIGN(sg_list_unaligned, sizeof(struct fh_sg_list));
/* Get the physical addresses of the source buffer */
- down_read(¤t->mm->mmap_sem);
- num_pinned = get_user_pages(param.local_vaddr - lb_offset,
- num_pages, (param.source == -1) ? 0 : FOLL_WRITE,
- pages, NULL);
- up_read(¤t->mm->mmap_sem);
+ num_pinned = get_user_pages_unlocked(param.local_vaddr - lb_offset,
+ num_pages, pages, (param.source == -1) ? 0 : FOLL_WRITE);
if (num_pinned != num_pages) {
/* get_user_pages() failed */
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/virt: use get_user_pages_unlocked()
2016-11-01 19:43 [PATCH] drivers/virt: use get_user_pages_unlocked() Lorenzo Stoakes
@ 2017-01-03 21:14 ` Lorenzo Stoakes
2017-01-03 21:36 ` Michal Hocko
0 siblings, 1 reply; 4+ messages in thread
From: Lorenzo Stoakes @ 2017-01-03 21:14 UTC (permalink / raw)
To: linux-mm
Cc: Linux Kernel Mailing List, Paolo Bonzini, Michal Hocko,
Kumar Gala, Mihai Caraman, Greg KH
Just a gentle ping on this :) I think this might be a slightly
abandoned corner of the kernel so not sure who else to ping to get
this moving.
On 1 November 2016 at 19:43, Lorenzo Stoakes <lstoakes@gmail.com> wrote:
> Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code
> and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> ---
> drivers/virt/fsl_hypervisor.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
> index 150ce2a..d3eca87 100644
> --- a/drivers/virt/fsl_hypervisor.c
> +++ b/drivers/virt/fsl_hypervisor.c
> @@ -243,11 +243,8 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p)
> sg_list = PTR_ALIGN(sg_list_unaligned, sizeof(struct fh_sg_list));
>
> /* Get the physical addresses of the source buffer */
> - down_read(¤t->mm->mmap_sem);
> - num_pinned = get_user_pages(param.local_vaddr - lb_offset,
> - num_pages, (param.source == -1) ? 0 : FOLL_WRITE,
> - pages, NULL);
> - up_read(¤t->mm->mmap_sem);
> + num_pinned = get_user_pages_unlocked(param.local_vaddr - lb_offset,
> + num_pages, pages, (param.source == -1) ? 0 : FOLL_WRITE);
>
> if (num_pinned != num_pages) {
> /* get_user_pages() failed */
> --
> 2.10.2
>
--
Lorenzo Stoakes
https://ljs.io
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/virt: use get_user_pages_unlocked()
2017-01-03 21:14 ` Lorenzo Stoakes
@ 2017-01-03 21:36 ` Michal Hocko
2017-02-20 18:34 ` Lorenzo Stoakes
0 siblings, 1 reply; 4+ messages in thread
From: Michal Hocko @ 2017-01-03 21:36 UTC (permalink / raw)
To: Lorenzo Stoakes
Cc: linux-mm, Linux Kernel Mailing List, Paolo Bonzini, Kumar Gala,
Mihai Caraman, Greg KH, Andrew Morton
On Tue 03-01-17 21:14:20, Lorenzo Stoakes wrote:
> Just a gentle ping on this :) I think this might be a slightly
> abandoned corner of the kernel so not sure who else to ping to get
> this moving.
Maybe Andrew can pick it up?
http://lkml.kernel.org/r/20161101194332.23961-1-lstoakes@gmail.com
> On 1 November 2016 at 19:43, Lorenzo Stoakes <lstoakes@gmail.com> wrote:
> > Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code
> > and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.
> >
> > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> > ---
> > drivers/virt/fsl_hypervisor.c | 7 ++-----
> > 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
> > index 150ce2a..d3eca87 100644
> > --- a/drivers/virt/fsl_hypervisor.c
> > +++ b/drivers/virt/fsl_hypervisor.c
> > @@ -243,11 +243,8 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p)
> > sg_list = PTR_ALIGN(sg_list_unaligned, sizeof(struct fh_sg_list));
> >
> > /* Get the physical addresses of the source buffer */
> > - down_read(¤t->mm->mmap_sem);
> > - num_pinned = get_user_pages(param.local_vaddr - lb_offset,
> > - num_pages, (param.source == -1) ? 0 : FOLL_WRITE,
> > - pages, NULL);
> > - up_read(¤t->mm->mmap_sem);
> > + num_pinned = get_user_pages_unlocked(param.local_vaddr - lb_offset,
> > + num_pages, pages, (param.source == -1) ? 0 : FOLL_WRITE);
> >
> > if (num_pinned != num_pages) {
> > /* get_user_pages() failed */
> > --
> > 2.10.2
> >
>
>
>
> --
> Lorenzo Stoakes
> https://ljs.io
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/virt: use get_user_pages_unlocked()
2017-01-03 21:36 ` Michal Hocko
@ 2017-02-20 18:34 ` Lorenzo Stoakes
0 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Stoakes @ 2017-02-20 18:34 UTC (permalink / raw)
To: Michal Hocko
Cc: linux-mm, Linux Kernel Mailing List, Paolo Bonzini, Kumar Gala,
Mihai Caraman, Greg KH, Andrew Morton
On 3 January 2017 at 21:36, Michal Hocko <mhocko@kernel.org> wrote:
> On Tue 03-01-17 21:14:20, Lorenzo Stoakes wrote:
>> Just a gentle ping on this :) I think this might be a slightly
>> abandoned corner of the kernel so not sure who else to ping to get
>> this moving.
>
> Maybe Andrew can pick it up?
> http://lkml.kernel.org/r/20161101194332.23961-1-lstoakes@gmail.com
>
Hi all, since the merge window has opened thought I'd give another
gentle nudge on this - Andrew, are you ok to pick this up? For
convenience the raw patch is at
https://marc.info/?l=linux-mm&m=147802941732512&q=raw I've checked and
it still applies. Let me know if you want me to simply resend this or
if there is anything else I can do to nudge this along!
Thanks, Lorenzo
>> On 1 November 2016 at 19:43, Lorenzo Stoakes <lstoakes@gmail.com> wrote:
>> > Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code
>> > and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.
>> >
>> > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
>> > ---
>> > drivers/virt/fsl_hypervisor.c | 7 ++-----
>> > 1 file changed, 2 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
>> > index 150ce2a..d3eca87 100644
>> > --- a/drivers/virt/fsl_hypervisor.c
>> > +++ b/drivers/virt/fsl_hypervisor.c
>> > @@ -243,11 +243,8 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p)
>> > sg_list = PTR_ALIGN(sg_list_unaligned, sizeof(struct fh_sg_list));
>> >
>> > /* Get the physical addresses of the source buffer */
>> > - down_read(¤t->mm->mmap_sem);
>> > - num_pinned = get_user_pages(param.local_vaddr - lb_offset,
>> > - num_pages, (param.source == -1) ? 0 : FOLL_WRITE,
>> > - pages, NULL);
>> > - up_read(¤t->mm->mmap_sem);
>> > + num_pinned = get_user_pages_unlocked(param.local_vaddr - lb_offset,
>> > + num_pages, pages, (param.source == -1) ? 0 : FOLL_WRITE);
>> >
>> > if (num_pinned != num_pages) {
>> > /* get_user_pages() failed */
>> > --
>> > 2.10.2
>> >
>>
>>
>>
>> --
>> Lorenzo Stoakes
>> https://ljs.io
>
> --
> Michal Hocko
> SUSE Labs
--
Lorenzo Stoakes
https://ljs.io
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-20 18:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-01 19:43 [PATCH] drivers/virt: use get_user_pages_unlocked() Lorenzo Stoakes
2017-01-03 21:14 ` Lorenzo Stoakes
2017-01-03 21:36 ` Michal Hocko
2017-02-20 18:34 ` Lorenzo Stoakes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).