From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mfd: arizona: Use regmap_read_poll_timeout instead of hard coding it
Date: Thu, 5 Jan 2017 08:07:01 +0000 [thread overview]
Message-ID: <20170105080701.GJ24225@dell> (raw)
In-Reply-To: <1483542655-19980-3-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Wed, 04 Jan 2017, Charles Keepax wrote:
> arizona_poll_reg essentially hard-codes regmap_read_poll_timeout, this
> patch updates the implementation to use regmap_read_poll_timeout. We
> still keep arizona_poll_reg around as regmap_read_poll_timeout is a
> macro so rather than expand this for each caller keep it wrapped in
> arizona_poll_reg.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 28 +++++++++++-----------------
> 1 file changed, 11 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 4cb34c3..e6fae3c 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -236,28 +236,22 @@ static irqreturn_t arizona_overclocked(int irq, void *data)
> }
>
> static int arizona_poll_reg(struct arizona *arizona,
> - int timeout, unsigned int reg,
> + int npolls, unsigned int reg,
> unsigned int mask, unsigned int target)
> {
> + const int poll_us = 7500;
Get rid of this and replace its usage with a nice #define describing
exactly what the timeout is for i.e what timed out.
... okay, I just read the doc. This should really be 'SLEEP'.
Where did 7500 come from anyway? Is it documented?
> unsigned int val = 0;
> - int ret, i;
> -
> - for (i = 0; i < timeout; i++) {
> - ret = regmap_read(arizona->regmap, reg, &val);
> - if (ret != 0) {
> - dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n",
> - reg, ret);
> - continue;
> - }
> -
> - if ((val & mask) == target)
> - return 0;
> + int ret;
>
> - usleep_range(1000, 5000);
> - }
> + ret = regmap_read_poll_timeout(arizona->regmap,
> + ARIZONA_INTERRUPT_RAW_STATUS_5, val,
> + ((val & mask) == target), poll_us,
> + npolls * poll_us);
What's the relevance of npolls? Is this number documented, or was it
pulled from your ... err, the air?
> + if (ret)
> + dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n",
> + reg, val);
>
> - dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", reg, val);
> - return -ETIMEDOUT;
> + return ret;
> }
>
> static int arizona_wait_for_boot(struct arizona *arizona)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-05 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 15:10 [PATCH 1/3] mfd: arizona: Remove duplicate set of ret variable Charles Keepax
2017-01-04 15:10 ` [PATCH 2/3] mfd: arizona: Display register addresses in hex Charles Keepax
2017-01-05 8:07 ` Lee Jones
2017-01-04 15:10 ` [PATCH 3/3] mfd: arizona: Use regmap_read_poll_timeout instead of hard coding it Charles Keepax
2017-01-05 8:07 ` Lee Jones [this message]
2017-01-05 10:05 ` Charles Keepax
2017-01-05 14:48 ` Lee Jones
2017-01-06 9:28 ` Charles Keepax
2017-01-05 8:07 ` [PATCH 1/3] mfd: arizona: Remove duplicate set of ret variable Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105080701.GJ24225@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).