From: Andi Shyti <andi@etezian.org>
To: Chanwoo Choi <cwchoi00@gmail.com>
Cc: Andi Shyti <andi@etezian.org>,
Andi Shyti <andi.shyti@samsung.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Beomho Seo <beomho.seo@samsung.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-input@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Jaechul Lee <jcsing.lee@samsung.com>,
Jaechul Lee <galaxyra@gmail.com>
Subject: Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node
Date: Sun, 8 Jan 2017 14:45:04 +0900 [thread overview]
Message-ID: <20170108054504.fssqicmeovufar2r@jack.zhora.eu> (raw)
In-Reply-To: <CAGTfZH35sx5v-XcxkDG7TVRmW8cLirAXRxA=kGZQDBnpw3vYhg@mail.gmail.com>
Hi Chanwoo,
> >> >>> + touchkey@20 {
> >> >>> + compatible = "samsung,tm2-touchkey";
> >> >>> + reg = <0x20>;
> >> >>> + interrupt-parent = <&gpa3>;
> >> >>> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> >> >>> + vcc-supply = <&ldo32_reg>;
> >> >>> + vdd-supply = <&ldo33_reg>;
> >> >>> + };
> >> >>> +};
> >> >>> +
> >> >>> &ldo31_reg {
> >> >>> regulator-name = "TSP_VDD_1.85V_AP";
> >> >>> regulator-min-microvolt = <1850000>;
> >>
> >> I repiled the touchkey driver against compatible name.
> >> Usually, when developing the device driver, we use the specific h/w name
> >> but in this patch, the touckey dt node uses the h/w board name instead of
> >> original touckhey name.
> >
> > this should be a device specifically done for the tm2 and we are
> > not sure who is the manufacturer of the device. In order to not
>
> As I knew, this touchkey was made by Cypress semiconductor.
> But, for more correct information, you may try to find it.
The Android Kernel says that this is the cy8cmbr3xxx. I
downloaded the datasheets, but it doesn't have any similarity
with the device. Which means that on tm2 we don't the
cy8cmbr3xxx bot something else that I even doubt comes from
cypress, but I strongly believe it's a dedicated hardware.
Now we have two choices:
1. drop support because we are not 100% sure on the device and
supplier.
2. call it Samsung and provide support anyway as, at the end, it
is a samsung hardware.
With Jaechul we chose option 2.
> > assign the device to the wrong manufacturer, we preferred calling
> > it Samsung as it is in a Samsung device.
>
> As you mentioned, Samsung made not this touchkey device. It is
> certainly wrong manufacturer. I have not seen to use the h/w board
> name as the peripheral device name.
>
> I don't prefer to use the inaccurate manufacturer and device name.
Eventually, Jaechul can assign the device to cypress, but the
name has to remain tm2-touchkey. Something like this:
compatible = "cypress,tm2-touchkey";
What do you think?
Andi
next prev parent reply other threads:[~2017-01-08 5:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170106134355epcas1p171f1f3b3c20c6a92e7736c1639ea2dd8@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 0/5] Add touch key driver support for TM2 Andi Shyti
[not found] ` <CGME20170106134355epcas1p1c201edf5dabed68506eb6bf9f9e0a1ee@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong values for ldo23 and ldo25 Andi Shyti
2017-01-06 14:01 ` Krzysztof Kozlowski
[not found] ` <CGME20170106134356epcas1p19be459900aec43b2b9ea343cdaf0a2bf@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Andi Shyti
2017-01-06 13:49 ` Krzysztof Kozlowski
2017-01-06 13:53 ` Andi Shyti
2017-01-06 14:01 ` Krzysztof Kozlowski
2017-01-06 14:02 ` Javier Martinez Canillas
2017-01-06 21:26 ` Chanwoo Choi
[not found] ` <CGME20170106134356epcas1p1758fadaa2b12ad29d90e2da525456a28@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 3/5] input: Add support for the tm2 touchkey device driver Andi Shyti
2017-01-06 21:34 ` Chanwoo Choi
[not found] ` <CGME20170106134356epcas1p19a931a3b8bb0880d14e3eeeea800c831@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 4/5] input: tm2-touchkey: Add touchkey driver support for TM2 Andi Shyti
2017-01-06 22:04 ` Chanwoo Choi
[not found] ` <CGME20170106134356epcas1p1aee9f715c58b50f6056bf0b43b849497@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti
2017-01-06 14:03 ` Krzysztof Kozlowski
2017-01-06 21:31 ` Chanwoo Choi
2017-01-06 22:09 ` Chanwoo Choi
2017-01-06 22:15 ` Chanwoo Choi
2017-01-07 12:40 ` Andi Shyti
2017-01-08 5:14 ` Chanwoo Choi
2017-01-08 5:45 ` Andi Shyti [this message]
2017-01-08 6:07 ` Chanwoo Choi
2017-01-08 6:13 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108054504.fssqicmeovufar2r@jack.zhora.eu \
--to=andi@etezian.org \
--cc=andi.shyti@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galaxyra@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jcsing.lee@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).