From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Andi Shyti <andi.shyti@samsung.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Beomho Seo <beomho.seo@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Jaechul Lee <jcsing.lee@samsung.com>,
Andi Shyti <andi@etezian.org>, Jaechul Lee <galaxyra@gmail.com>
Subject: Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other
Date: Fri, 6 Jan 2017 11:02:20 -0300 [thread overview]
Message-ID: <9e4fe0ee-0c33-9a5f-a954-b13d35b0113f@osg.samsung.com> (raw)
In-Reply-To: <20170106134929.mj7wqalp7lpkfm6b@kozik-lap>
Hello Krzysztof,
On 01/06/2017 10:49 AM, Krzysztof Kozlowski wrote:
> On Fri, Jan 06, 2017 at 10:43:47PM +0900, Andi Shyti wrote:
>> Currently tm2e dts includes tm2 but there are some differences
>> between the two boards and tm2 has some properties that tm2e
>> doesn't have.
>>
>> That's why it's important to keep the two dts files independent
>> and put all the commonalities in a tm2-common.dtsi file.
>>
>> At the current status the only two differences between the two
>> dts files (besides the board name) are ldo31 and ldo38.
>>
>> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
[snip]
> Beside that it is starting to look good. I didn't find anything else but
> maybe Javier's eagle eye will catch something.
>
I didn't find anything else, the patch looks good to me now.
>
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2017-01-06 14:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170106134355epcas1p171f1f3b3c20c6a92e7736c1639ea2dd8@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 0/5] Add touch key driver support for TM2 Andi Shyti
[not found] ` <CGME20170106134355epcas1p1c201edf5dabed68506eb6bf9f9e0a1ee@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong values for ldo23 and ldo25 Andi Shyti
2017-01-06 14:01 ` Krzysztof Kozlowski
[not found] ` <CGME20170106134356epcas1p19be459900aec43b2b9ea343cdaf0a2bf@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Andi Shyti
2017-01-06 13:49 ` Krzysztof Kozlowski
2017-01-06 13:53 ` Andi Shyti
2017-01-06 14:01 ` Krzysztof Kozlowski
2017-01-06 14:02 ` Javier Martinez Canillas [this message]
2017-01-06 21:26 ` Chanwoo Choi
[not found] ` <CGME20170106134356epcas1p1758fadaa2b12ad29d90e2da525456a28@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 3/5] input: Add support for the tm2 touchkey device driver Andi Shyti
2017-01-06 21:34 ` Chanwoo Choi
[not found] ` <CGME20170106134356epcas1p19a931a3b8bb0880d14e3eeeea800c831@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 4/5] input: tm2-touchkey: Add touchkey driver support for TM2 Andi Shyti
2017-01-06 22:04 ` Chanwoo Choi
[not found] ` <CGME20170106134356epcas1p1aee9f715c58b50f6056bf0b43b849497@epcas1p1.samsung.com>
2017-01-06 13:43 ` [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti
2017-01-06 14:03 ` Krzysztof Kozlowski
2017-01-06 21:31 ` Chanwoo Choi
2017-01-06 22:09 ` Chanwoo Choi
2017-01-06 22:15 ` Chanwoo Choi
2017-01-07 12:40 ` Andi Shyti
2017-01-08 5:14 ` Chanwoo Choi
2017-01-08 5:45 ` Andi Shyti
2017-01-08 6:07 ` Chanwoo Choi
2017-01-08 6:13 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4fe0ee-0c33-9a5f-a954-b13d35b0113f@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=beomho.seo@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galaxyra@gmail.com \
--cc=jcsing.lee@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).