* Re: [linux-sunxi] Re: [PATCH 3/6] clk: sunxi-ng: Add H5 clocks
[not found] <20170106014959.nqPebrUB@smtp1p.mail.yandex.net>
@ 2017-01-09 11:01 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2017-01-09 11:01 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Rob Herring, linux-clk, linux-kernel, Andre Przywara, devicetree,
linux-gpio, Linus Walleij, linux-arm-kernel, linux-sunxi,
Chen-Yu Tsai
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Fri, Jan 06, 2017 at 06:48:31AM +0800, Icenowy Zheng wrote:
>
> 2017年1月6日 06:04于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
> >
> > On Tue, Dec 27, 2016 at 12:25:15AM +0800, Icenowy Zheng wrote:
> > > Add the H5 CCU clocks set based on the H3 one.
> > >
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >
> > Is there any difference with H3's?
>
> One more Transport Stream controller, so one more bus gate and bus
> reset for it.
There's no need to duplicate more than 1000 lines of code just for
that then. Just add a new compatible and reuse the clocks already
defined.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-sunxi] Re: [PATCH 3/6] clk: sunxi-ng: Add H5 clocks
[not found] <20170109161500.Ep9GCmIb@smtp2p.mail.yandex.net>
@ 2017-01-10 19:10 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2017-01-10 19:10 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Rob Herring, Andre Przywara, linux-kernel, linux-clk, linux-gpio,
devicetree, Linus Walleij, linux-arm-kernel, Chen-Yu Tsai,
linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]
On Mon, Jan 09, 2017 at 09:13:12PM +0800, Icenowy Zheng wrote:
>
> 2017年1月9日 下午7:01于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
> >
> > On Fri, Jan 06, 2017 at 06:48:31AM +0800, Icenowy Zheng wrote:
> > >
> > > 2017年1月6日 06:04于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
> > > >
> > > > On Tue, Dec 27, 2016 at 12:25:15AM +0800, Icenowy Zheng wrote:
> > > > > Add the H5 CCU clocks set based on the H3 one.
> > > > >
> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> > > >
> > > > Is there any difference with H3's?
> > >
> > > One more Transport Stream controller, so one more bus gate and bus
> > > reset for it.
> >
> > There's no need to duplicate more than 1000 lines of code just for
> > that then. Just add a new compatible and reuse the clocks already
> > defined.
>
> How can I do this? Add them in ccu-sun8i-h3.c ?
Yes, you can have a look at how I did it for sun5i for example if you
want.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-10 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170106014959.nqPebrUB@smtp1p.mail.yandex.net>
2017-01-09 11:01 ` [linux-sunxi] Re: [PATCH 3/6] clk: sunxi-ng: Add H5 clocks Maxime Ripard
[not found] <20170109161500.Ep9GCmIb@smtp2p.mail.yandex.net>
2017-01-10 19:10 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).