From: Jiri Pirko <jiri@resnulli.us>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>
Subject: Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2
Date: Mon, 9 Jan 2017 18:58:42 +0100 [thread overview]
Message-ID: <20170109175842.GH1862@nanopsycho> (raw)
In-Reply-To: <89492624-84f2-ca73-75dd-7fa10819ad09@gmail.com>
Mon, Jan 09, 2017 at 06:42:07PM CET, f.fainelli@gmail.com wrote:
>On 01/09/2017 08:06 AM, Jiri Pirko wrote:
>> Mon, Jan 09, 2017 at 04:45:33PM CET, vivien.didelot@savoirfairelinux.com wrote:
>>> Hi Jiri,
>>>
>>> Jiri Pirko <jiri@resnulli.us> writes:
>>>
>>>>> Extra question: shouldn't phys_port_{id,name} be switchdev attributes in
>>>>
>>>> Again, phys_port_id has nothing to do with switches. Should be removed
>>>> from dsa because its use there is incorrect.
>>>
>>> Florian, since 3a543ef just got in, can it be reverted?
>>
>> Yes, please revert it. It is only in net-next.
>
>Maybe the use case can be understood before reverting the change. How do
>we actually the physical port number of an Ethernet switch per-port
>network device? The name is not enough, because there are plenty of
>cases where we need to manipulate a physical port number (be it just for
>informational purposes).
Like what?
Why the name is not enough? This is something propagated to userspace
and never used internally in kernel.
Btw, ndo_get_phys_port_id does not give you number, but arbitrary binary.
>
>Should we just amend the existing description of ndo_get_phys_port_id()?
>Should we introduce another ndo for that?
>--
>Florian
next prev parent reply other threads:[~2017-01-09 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 23:15 [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Vivien Didelot
2017-01-08 23:30 ` Andrew Lunn
2017-01-09 2:56 ` Vivien Didelot
2017-01-09 7:32 ` Jiri Pirko
2017-01-09 15:04 ` Vivien Didelot
2017-01-09 15:11 ` Jiri Pirko
2017-01-09 15:45 ` Vivien Didelot
2017-01-09 16:00 ` Andrew Lunn
2017-01-09 16:07 ` Jiri Pirko
2017-01-09 16:06 ` Jiri Pirko
2017-01-09 17:42 ` Florian Fainelli
2017-01-09 17:58 ` Jiri Pirko [this message]
2017-01-09 18:06 ` Florian Fainelli
2017-01-10 9:55 ` Jiri Pirko
2017-01-10 17:58 ` Florian Fainelli
2017-01-11 7:26 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109175842.GH1862@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew.smirnov@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=uwe@kleine-koenig.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).