Re: [PATCH v11 2/8] power: add power sequence library

From: Peter Chen <hzpeterchen@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, rjw@rjwysocki.net
Cc: Peter Chen <peter.chen@nxp.com>,
	mark.rutland@arm.com, ulf.hansson@linaro.org, heiko@sntech.de,
	stephen.boyd@linaro.org, linux-kernel@vger.kernel.org,
	gary.bisson@boundarydevices.com, festevam@gmail.com,
	stillcompiling@gmail.com, arnd@arndb.de, dbaryshkov@gmail.com,
	vaibhav.hiremath@linaro.org, mka@chromium.org,
	stern@rowland.harvard.edu, devicetree@vger.kernel.org,
	mail@maciej.szmigiero.name, pawel.moll@arm.com,
	linux-pm@vger.kernel.org, s.hauer@pengutronix.de,
	troy.kisky@boundarydevices.com, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, hverkuil@xs4all.nl,
	oscar@naiandei.net, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, rjw@rjwysocki.net, sre@kernel.org,
	broonie@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v11 2/8] power: add power sequence library
Date: Tue, 10 Jan 2017 15:02:41 +0800	[thread overview]
Message-ID: <20170110070240.GA29454@b29397-desktop> (raw)
In-Reply-To: <20170107085456.w5dhm7qadqa6tc7v@kozik-lap>

On Sat, Jan 07, 2017 at 10:54:56AM +0200, Krzysztof Kozlowski wrote:
> On Thu, Jan 05, 2017 at 02:01:53PM +0800, Peter Chen wrote:
> > We have an well-known problem that the device needs to do some power
> > sequence before it can be recognized by related host, the typical
> > example like hard-wired mmc devices and usb devices.
> > 
> > This power sequence is hard to be described at device tree and handled by
> > related host driver, so we have created a common power sequence
> > library to cover this requirement. The core code has supplied
> > some common helpers for host driver, and individual power sequence
> > libraries handle kinds of power sequence for devices. The pwrseq
> > librares always need to allocate extra instance for compatible
> > string match.
> > 
> > pwrseq_generic is intended for general purpose of power sequence, which
> > handles gpios and clocks currently, and can cover other controls in
> > future. The host driver just needs to call of_pwrseq_on/of_pwrseq_off
> > if only one power sequence is needed, else call of_pwrseq_on_list
> > /of_pwrseq_off_list instead (eg, USB hub driver).
> > 
> > For new power sequence library, it can add its compatible string
> > to pwrseq_of_match_table, then the pwrseq core will match it with
> > DT's, and choose this library at runtime.
> > 
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> > Tested-by Joshua Clayton <stillcompiling@gmail.com>
> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > Tested-by: Matthias Kaehlcke <mka@chromium.org>
> 
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> Tested on Odroid U3 (reset sequence for LAN9730):
> Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
> 

A nice ping...

-- 

Best Regards,
Peter Chen