From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Peter Chen <peter.chen@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Stephen Boyd <stephen.boyd@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gary Bisson <gary.bisson@boundarydevices.com>,
Fabio Estevam <festevam@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Vaibhav Hiremath <vaibhav.hiremath@linaro.org>,
mka@chromium.org, Alan Stern <stern@rowland.harvard.edu>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
mail@maciej.szmigiero.name, Pawel Moll <pawel.moll@arm.com>,
Linux PM <linux-pm@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
troy.kisky@boundarydevices.com, Rob Herring <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
hverkuil@xs4all.nl, oscar@naiandei.net,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:"
<linux-usb@vger.kernel.org>, Sebastian Reichel <sre@kernel.org>,
Mark Brown <broonie@kernel.org>,
p.zabel@pengutronix.de, Shawn Guo <shawnguo@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v11 2/8] power: add power sequence library
Date: Fri, 20 Jan 2017 11:21:27 +0100 [thread overview]
Message-ID: <CAJZ5v0h09A2XWLEk7v9XPe+4fP7HDr6AqZzBmvBi_V5nhLoiRw@mail.gmail.com> (raw)
In-Reply-To: <20170120075239.GC21013@b29397-desktop>
On Fri, Jan 20, 2017 at 8:52 AM, Peter Chen <hzpeterchen@gmail.com> wrote:
> On Tue, Jan 10, 2017 at 03:02:41PM +0800, Peter Chen wrote:
>> On Sat, Jan 07, 2017 at 10:54:56AM +0200, Krzysztof Kozlowski wrote:
>> > On Thu, Jan 05, 2017 at 02:01:53PM +0800, Peter Chen wrote:
>> > > We have an well-known problem that the device needs to do some power
>> > > sequence before it can be recognized by related host, the typical
>> > > example like hard-wired mmc devices and usb devices.
>> > >
>> > > This power sequence is hard to be described at device tree and handled by
>> > > related host driver, so we have created a common power sequence
>> > > library to cover this requirement. The core code has supplied
>> > > some common helpers for host driver, and individual power sequence
>> > > libraries handle kinds of power sequence for devices. The pwrseq
>> > > librares always need to allocate extra instance for compatible
>> > > string match.
>> > >
>> > > pwrseq_generic is intended for general purpose of power sequence, which
>> > > handles gpios and clocks currently, and can cover other controls in
>> > > future. The host driver just needs to call of_pwrseq_on/of_pwrseq_off
>> > > if only one power sequence is needed, else call of_pwrseq_on_list
>> > > /of_pwrseq_off_list instead (eg, USB hub driver).
>> > >
>> > > For new power sequence library, it can add its compatible string
>> > > to pwrseq_of_match_table, then the pwrseq core will match it with
>> > > DT's, and choose this library at runtime.
>> > >
>> > > Signed-off-by: Peter Chen <peter.chen@nxp.com>
>> > > Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
>> > > Tested-by Joshua Clayton <stillcompiling@gmail.com>
>> > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> > > Tested-by: Matthias Kaehlcke <mka@chromium.org>
>> >
>> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>> > Tested on Odroid U3 (reset sequence for LAN9730):
>> > Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
>> >
>>
>> A nice ping...
>>
>
> Rafael, would you please review it? This series was discussed about
> half a year, and many people need it, I hope it can be in v4.11-rc1,
> thanks.
I'm travelling now
(http://marc.info/?l=linux-pm&m=148410629024194&w=2) and (as stated in
this message) I'll get to the patches when I'm back home.
There is a good chance for your code to go into 4.11-rc1 if the review
comments so far have been addressed.
Thanks,
Rafael
next prev parent reply other threads:[~2017-01-20 10:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 6:01 [PATCH v11 0/8] power: add power sequence library Peter Chen
2017-01-05 6:01 ` [PATCH v11 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2017-01-07 8:53 ` Krzysztof Kozlowski
2017-01-05 6:01 ` [PATCH v11 2/8] power: add " Peter Chen
2017-01-07 8:54 ` Krzysztof Kozlowski
2017-01-10 7:02 ` Peter Chen
2017-01-20 7:52 ` Peter Chen
2017-01-20 10:21 ` Rafael J. Wysocki [this message]
2017-01-22 2:14 ` Peter Chen
2017-01-05 6:01 ` [PATCH v11 3/8] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2017-01-07 8:55 ` Krzysztof Kozlowski
2017-01-05 6:01 ` [PATCH v11 4/8] usb: core: add power sequence handling for USB devices Peter Chen
2017-01-07 8:56 ` Krzysztof Kozlowski
2017-01-05 6:01 ` [PATCH v11 5/8] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node Peter Chen
2017-01-05 6:01 ` [PATCH v11 6/8] ARM: dts: imx6qdl: Enable usb node children with <reg> Peter Chen
2017-01-05 6:01 ` [PATCH v11 7/8] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
2017-01-05 6:01 ` [PATCH v11 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line Peter Chen
2017-01-06 15:18 ` [PATCH v11 0/8] power: add power sequence library Krzysztof Kozlowski
2017-01-06 17:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0h09A2XWLEk7v9XPe+4fP7HDr6AqZzBmvBi_V5nhLoiRw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gary.bisson@boundarydevices.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=hzpeterchen@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=oscar@naiandei.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=peter.chen@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=stillcompiling@gmail.com \
--cc=troy.kisky@boundarydevices.com \
--cc=ulf.hansson@linaro.org \
--cc=vaibhav.hiremath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).