* [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h
@ 2017-01-10 15:30 Arnd Bergmann
2017-01-10 16:40 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-01-10 15:30 UTC (permalink / raw)
To: Mark Brown
Cc: Arnd Bergmann, Krzysztof Kozlowski, Sangbeom Kim,
Sylwester Nawrocki, Liam Girdwood, Charles Keepax, Inha Song,
alsa-devel, linux-kernel
gpiod_set_value_cansleep is declared in linux/gpio/consumer.h, but that
is not always included implicitly, so we have to include both
gpio.h and gpio/consumer.h here:
sound/soc/samsung/tm2_wm5110.c: In function 'tm2_mic_bias':
sound/soc/samsung/tm2_wm5110.c:220:3: error: implicit declaration of function 'gpiod_set_value_cansleep';did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration]
Fixes: 1bfbc260a5b4 ("ASoC: samsung: Add machine driver for Exynos5433 based TM2 board")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/samsung/tm2_wm5110.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
index 5cdf7d19b87f..24cc9d63ce87 100644
--- a/sound/soc/samsung/tm2_wm5110.c
+++ b/sound/soc/samsung/tm2_wm5110.c
@@ -12,6 +12,7 @@
#include <linux/clk.h>
#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/of.h>
#include <sound/pcm_params.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h
2017-01-10 15:30 [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h Arnd Bergmann
@ 2017-01-10 16:40 ` Mark Brown
2017-01-10 16:48 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2017-01-10 16:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Krzysztof Kozlowski, Sangbeom Kim, Sylwester Nawrocki,
Liam Girdwood, Charles Keepax, Inha Song, alsa-devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
On Tue, Jan 10, 2017 at 04:30:50PM +0100, Arnd Bergmann wrote:
> gpiod_set_value_cansleep is declared in linux/gpio/consumer.h, but that
> is not always included implicitly, so we have to include both
> gpio.h and gpio/consumer.h here:
This doesn't apply against current code, it looks like someone already
made the same change.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h
2017-01-10 16:40 ` Mark Brown
@ 2017-01-10 16:48 ` Arnd Bergmann
2017-01-10 16:59 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-01-10 16:48 UTC (permalink / raw)
To: Mark Brown
Cc: Krzysztof Kozlowski, Sangbeom Kim, Sylwester Nawrocki,
Liam Girdwood, Charles Keepax, Inha Song, alsa-devel,
linux-kernel
On Tue, Jan 10, 2017 at 5:40 PM, Mark Brown <broonie@kernel.org> wrote:
> This doesn't apply against current code, it looks like someone already
> made the same change.Ok, I was sending out m
y final set of patches that I found build-testing v4.10-rc, which
still needs the change,
and have moved on to linux-next testing now.
In case you have queued up that change for v4.11 but not also v4.10,
maybe move it into the fixes branch.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h
2017-01-10 16:48 ` Arnd Bergmann
@ 2017-01-10 16:59 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2017-01-10 16:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Krzysztof Kozlowski, Sangbeom Kim, Sylwester Nawrocki,
Liam Girdwood, Charles Keepax, Inha Song, alsa-devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
On Tue, Jan 10, 2017 at 05:48:06PM +0100, Arnd Bergmann wrote:
> In case you have queued up that change for v4.11 but not also v4.10,
> maybe move it into the fixes branch.
There's a merge in there as well.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-10 16:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-10 15:30 [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h Arnd Bergmann
2017-01-10 16:40 ` Mark Brown
2017-01-10 16:48 ` Arnd Bergmann
2017-01-10 16:59 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).