* Re: [PATCH 1/5] arm: sunxi: add support for V3s SoC
[not found] ` <20170103151629.19447-2-icenowy@aosc.xyz>
@ 2017-01-10 18:09 ` Maxime Ripard
[not found] ` <2706391484163632@web1g.yandex.ru>
0 siblings, 1 reply; 7+ messages in thread
From: Maxime Ripard @ 2017-01-10 18:09 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Chen-Yu Tsai, Stephen Boyd, Linus Walleij, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-gpio, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
On Tue, Jan 03, 2017 at 11:16:25PM +0800, Icenowy Zheng wrote:
> Allwinner V3s is a low-end single-core Cortex-A7 SoC, with 64MB
> integrated DRAM, and several peripherals.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> Documentation/arm/sunxi/README | 4 ++++
> arch/arm/mach-sunxi/sunxi.c | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/arm/sunxi/README b/Documentation/arm/sunxi/README
> index cd0243302bc1..91ec8f2055be 100644
> --- a/Documentation/arm/sunxi/README
> +++ b/Documentation/arm/sunxi/README
> @@ -67,6 +67,10 @@ SunXi family
> + Datasheet
> http://dl.linux-sunxi.org/H3/Allwinner_H3_Datasheet_V1.0.pdf
>
> + - Allwinner V3s (sun8i)
> + + Datasheet
> + https://www.goprawn.com/forum/allwinner-cams/783-allwinner-v3s-soc-datasheet
> +
Please don't put random links in there, but at least something that we
know will be there in a couple of weeks/monthes/years
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/5] clk: sunxi-ng: add support for V3s CCU
[not found] ` <20170103151629.19447-3-icenowy@aosc.xyz>
@ 2017-01-10 18:10 ` Maxime Ripard
[not found] ` <2705031484163593@web1g.yandex.ru>
0 siblings, 1 reply; 7+ messages in thread
From: Maxime Ripard @ 2017-01-10 18:10 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Chen-Yu Tsai, Stephen Boyd, Linus Walleij, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-gpio, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
On Tue, Jan 03, 2017 at 11:16:26PM +0800, Icenowy Zheng wrote:
> V3s has a similar but cut-down CCU to H3.
>
> Add support for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
It looks like there's nothing different but the clocks that you
register with the H3, please just use the H3 driver.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/5] pinctrl: sunxi: add driver for V3s SoC
[not found] ` <20170103151629.19447-4-icenowy@aosc.xyz>
@ 2017-01-10 18:18 ` Maxime Ripard
2017-01-11 15:24 ` Linus Walleij
1 sibling, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-01-10 18:18 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Chen-Yu Tsai, Stephen Boyd, Linus Walleij, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-gpio, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
On Tue, Jan 03, 2017 at 11:16:27PM +0800, Icenowy Zheng wrote:
> V3s SoC features only a pin controller (for the lack of CPUs part).
>
> Add a driver for this controller.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC
[not found] ` <20170103151629.19447-5-icenowy@aosc.xyz>
@ 2017-01-10 18:21 ` Maxime Ripard
0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-01-10 18:21 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Chen-Yu Tsai, Stephen Boyd, Linus Walleij, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-gpio, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
On Tue, Jan 03, 2017 at 11:16:28PM +0800, Icenowy Zheng wrote:
> + uart0_pins_a: uart0@0 {
> + pins = "PB8", "PB9";
> + function = "uart0";
> + bias-pull-up;
Why do you need a pullup here?
Looks good otherwise.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/5] pinctrl: sunxi: add driver for V3s SoC
[not found] ` <20170103151629.19447-4-icenowy@aosc.xyz>
2017-01-10 18:18 ` [PATCH 3/5] pinctrl: sunxi: add driver " Maxime Ripard
@ 2017-01-11 15:24 ` Linus Walleij
1 sibling, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2017-01-11 15:24 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Maxime Ripard, Chen-Yu Tsai, Stephen Boyd, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-gpio, linux-sunxi
On Tue, Jan 3, 2017 at 4:16 PM, Icenowy Zheng <icenowy@aosc.xyz> wrote:
> V3s SoC features only a pin controller (for the lack of CPUs part).
>
> Add a driver for this controller.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Patch applied with Maxime's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/5] arm: sunxi: add support for V3s SoC
[not found] ` <2706391484163632@web1g.yandex.ru>
@ 2017-01-12 17:17 ` Maxime Ripard
0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-01-12 17:17 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Chen-Yu Tsai, Stephen Boyd, Linus Walleij, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-gpio, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]
1;4601;0c
On Thu, Jan 12, 2017 at 03:40:32AM +0800, Icenowy Zheng wrote:
>
>
> 11.01.2017, 02:09, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > On Tue, Jan 03, 2017 at 11:16:25PM +0800, Icenowy Zheng wrote:
> >> Allwinner V3s is a low-end single-core Cortex-A7 SoC, with 64MB
> >> integrated DRAM, and several peripherals.
> >>
> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >> ---
> >> Documentation/arm/sunxi/README | 4 ++++
> >> arch/arm/mach-sunxi/sunxi.c | 1 +
> >> 2 files changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/arm/sunxi/README b/Documentation/arm/sunxi/README
> >> index cd0243302bc1..91ec8f2055be 100644
> >> --- a/Documentation/arm/sunxi/README
> >> +++ b/Documentation/arm/sunxi/README
> >> @@ -67,6 +67,10 @@ SunXi family
> >> + Datasheet
> >> http://dl.linux-sunxi.org/H3/Allwinner_H3_Datasheet_V1.0.pdf
> >>
> >> + - Allwinner V3s (sun8i)
> >> + + Datasheet
> >> + https://www.goprawn.com/forum/allwinner-cams/783-allwinner-v3s-soc-datasheet
> >> +
> >
> > Please don't put random links in there, but at least something that we
> > know will be there in a couple of weeks/monthes/years
>
> Is http://linux-sunxi.org/File:Allwinner_V3s_Datasheet_V1.0.pdf acceptable?
It's much better, yes.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/5] clk: sunxi-ng: add support for V3s CCU
[not found] ` <2714901484163893@web1g.yandex.ru>
@ 2017-01-12 17:19 ` Maxime Ripard
0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-01-12 17:19 UTC (permalink / raw)
To: Icenowy Zheng
Cc: devicetree, linux-doc, Linus Walleij, linux-sunxi, Stephen Boyd,
linux-kernel, linux-gpio, Chen-Yu Tsai, linux-clk,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On Thu, Jan 12, 2017 at 03:44:53AM +0800, Icenowy Zheng wrote:
>
>
> 12.01.2017, 03:40, "Icenowy Zheng" <icenowy@aosc.xyz>:
> > 11.01.2017, 02:10, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> >> On Tue, Jan 03, 2017 at 11:16:26PM +0800, Icenowy Zheng wrote:
> >>> V3s has a similar but cut-down CCU to H3.
> >>>
> >>> Add support for it.
> >>>
> >>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >>
> >> It looks like there's nothing different but the clocks that you
> >> register with the H3, please just use the H3 driver.
> >
> > Nope.
> >
> > It has a different PLL (PLL_ISP) at different address, and some
> > different muxes.
>
> Forgot to mention the missing of PLL_DE and related misses.
Those are not conflicting, it's just a slightly different set of
clocks.
So there's really nothing undoable.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-12 17:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170103151629.19447-1-icenowy@aosc.xyz>
[not found] ` <20170103151629.19447-2-icenowy@aosc.xyz>
2017-01-10 18:09 ` [PATCH 1/5] arm: sunxi: add support for V3s SoC Maxime Ripard
[not found] ` <2706391484163632@web1g.yandex.ru>
2017-01-12 17:17 ` Maxime Ripard
[not found] ` <20170103151629.19447-3-icenowy@aosc.xyz>
2017-01-10 18:10 ` [PATCH 2/5] clk: sunxi-ng: add support for V3s CCU Maxime Ripard
[not found] ` <2705031484163593@web1g.yandex.ru>
[not found] ` <2714901484163893@web1g.yandex.ru>
2017-01-12 17:19 ` Maxime Ripard
[not found] ` <20170103151629.19447-5-icenowy@aosc.xyz>
2017-01-10 18:21 ` [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC Maxime Ripard
[not found] ` <20170103151629.19447-4-icenowy@aosc.xyz>
2017-01-10 18:18 ` [PATCH 3/5] pinctrl: sunxi: add driver " Maxime Ripard
2017-01-11 15:24 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).