linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bin Liu <b-liu@ti.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero
Date: Tue, 10 Jan 2017 14:24:43 -0600	[thread overview]
Message-ID: <20170110202443.GC2479@uda0271908> (raw)
In-Reply-To: <20170103152534.20118-5-icenowy@aosc.xyz>

On Tue, Jan 03, 2017 at 11:25:34PM +0800, Icenowy Zheng wrote:
> Lichee Pi Zero features a USB OTG port.
> 
> Add support for it.
> 
> Note: in order to use the Host mode, the board must be powered via the
> +5V and GND pins.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
> index 0099affc6ce3..3d9168cbaeca 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
> @@ -71,3 +71,13 @@
>  	pinctrl-names = "default";
>  	status = "okay";
>  };
> +
> +&usb_otg {
> +	dr_mode = "otg";

Why not set this default mode in dtsi instead?

Regards,
-Bin.

> +	status = "okay";
> +};
> +
> +&usbphy {
> +	usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>;
> +	status = "okay";
> +};
> -- 
> 2.11.0
> 

  parent reply	other threads:[~2017-01-10 20:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170103152534.20118-1-icenowy@aosc.xyz>
     [not found] ` <20170103152534.20118-2-icenowy@aosc.xyz>
2017-01-06 13:56   ` [PATCH 1/4] phy: sun4i-usb: add support for V3s USB PHY Maxime Ripard
2017-01-16  9:06     ` Kishon Vijay Abraham I
     [not found] ` <20170103152534.20118-3-icenowy@aosc.xyz>
2017-01-06 13:57   ` [PATCH 2/4] musb: sunxi: add support for the variant in H3/V3s SoC Maxime Ripard
2017-01-17 14:38     ` Bin Liu
     [not found] ` <20170103152534.20118-4-icenowy@aosc.xyz>
2017-01-06 14:19   ` [PATCH 3/4] ARM: dts: sunxi: add usb_otg and usbphy node for V3s SoC Maxime Ripard
     [not found] ` <20170103152534.20118-5-icenowy@aosc.xyz>
2017-01-10 20:24   ` Bin Liu [this message]
     [not found]     ` <2733831484164533@web1g.yandex.ru>
2017-01-11 20:08       ` [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Bin Liu
     [not found]         ` <418251484165614@web21h.yandex.ru>
2017-01-11 20:33           ` Bin Liu
2017-01-11 21:06         ` Maxime Ripard
2017-01-12 14:50           ` Bin Liu
2017-01-12 17:39             ` Maxime Ripard
2017-01-13 21:00               ` Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110202443.GC2479@uda0271908 \
    --to=b-liu@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.xyz \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).