From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: "Christian König" <deathsimple@vodafone.de>,
"Rainer Hochecker" <fernetmenta@kodi.tv>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, fernetmenta@online.de
Subject: Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG
Date: Wed, 11 Jan 2017 18:41:27 +0200 [thread overview]
Message-ID: <20170111164127.GN31595@intel.com> (raw)
In-Reply-To: <20170111154405.GA1916@mail.bwidawsk.net>
On Wed, Jan 11, 2017 at 07:44:05AM -0800, Ben Widawsky wrote:
> On 17-01-11 17:05:04, Ville Syrjälä wrote:
> >On Thu, Jan 05, 2017 at 02:45:37PM +0100, Christian König wrote:
> >> Am 05.01.2017 um 12:37 schrieb Ville Syrjälä:
> >> > On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote:
> >> >> From: Rainer Hochecker <fernetmenta@online.de>
> >> >>
> >> >> This adds fourcc codes for 16bit planes required for DRM buffer
> >> >> export to mesa.
> >> >>
> >> >> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
> >> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> Good to see some work landing on that part, patch is Acked-by: Christian
> >> König <christian.koenig@amd.com>.
> >
> >Has the userspace side of this been reviewed already?
> >
> >/me wonders if it's safe to push this...
> >
>
> I acked the mesa side, and Rainer sent a version 2 which also looked fine to me.
> Let me bump that thread...
Thanks everyone. I've pushed this patch to drm-misc-next.
>
> >>
> >> >
> >> >> ---
> >> >> include/uapi/drm/drm_fourcc.h | 7 +++++++
> >> >> 1 file changed, 7 insertions(+)
> >> >>
> >> >> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> >> >> index a5890bf..d230e58 100644
> >> >> --- a/include/uapi/drm/drm_fourcc.h
> >> >> +++ b/include/uapi/drm/drm_fourcc.h
> >> >> @@ -41,10 +41,17 @@ extern "C" {
> >> >> /* 8 bpp Red */
> >> >> #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
> >> >>
> >> >> +/* 16 bpp Red */
> >> >> +#define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */
> >> >> +
> >> >> /* 16 bpp RG */
> >> >> #define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
> >> >> #define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
> >> >>
> >> >> +/* 32 bpp RG */
> >> >> +#define DRM_FORMAT_RG1616 fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
> >> >> +#define DRM_FORMAT_GR1616 fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
> >> >> +
> >> >> /* 8 bpp RGB */
> >> >> #define DRM_FORMAT_RGB332 fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
> >> >> #define DRM_FORMAT_BGR233 fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
> >> >> --
> >> >> 2.9.3
> >>
> >
> >--
> >Ville Syrjälä
> >Intel OTC
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2017-01-11 16:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 10:41 [PATCH] drm: add fourcc codes for 16bit R and GR Rainer Hochecker
2017-01-02 12:23 ` David Herrmann
2017-01-02 14:05 ` Ville Syrjälä
[not found] ` <CAH0Sn6Em0v8aUnN8mD0-JfJo5zz897+8v9TdDMiPH4fFkp48hQ@mail.gmail.com>
2017-01-03 16:56 ` Rainer Hochecker
2017-01-03 18:21 ` Eric Engestrom
2017-01-03 19:02 ` [PATCH v2] " Rainer Hochecker
2017-01-04 8:52 ` Daniel Vetter
2017-01-04 9:06 ` [Intel-gfx] " Jani Nikula
2017-01-04 10:19 ` Eric Engestrom
2017-01-04 13:45 ` [PATCH v3] drm: add fourcc codes for 16bit R and RG Rainer Hochecker
2017-01-04 13:50 ` [PATCH v4] " Rainer Hochecker
2017-01-04 18:04 ` Eric Engestrom
2017-01-04 18:24 ` [PATCH v5] " Rainer Hochecker
2017-01-04 18:28 ` Ville Syrjälä
2017-01-04 18:38 ` [PATCH v6] " Rainer Hochecker
2017-01-05 11:37 ` Ville Syrjälä
2017-01-05 13:45 ` Christian König
2017-01-11 15:05 ` Ville Syrjälä
2017-01-11 15:44 ` Ben Widawsky
2017-01-11 16:41 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111164127.GN31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=fernetmenta@kodi.tv \
--cc=fernetmenta@online.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).